From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix ASAN failure in DWO code
Date: Tue, 9 Jan 2024 15:29:24 -0500 [thread overview]
Message-ID: <2c2cf36a-f274-4940-882c-4935aa38f2e9@simark.ca> (raw)
In-Reply-To: <20240109195143.291756-1-tom@tromey.com>
On 1/9/24 14:51, Tom Tromey wrote:
> Simon pointed out that my recent change to the DWO code caused a
> failure in ASAN testing.
>
> The bug here was I updated the code to use a different search type in
> the hash table; but then did not change the search code to use
> htab_find_slot_with_hash.
>
> Note that this bug would not be possible with my type-safe hash table
> series, hint, hint.
I tested it locally, it seems fine to me.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
prev parent reply other threads:[~2024-01-09 20:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 19:51 Tom Tromey
2024-01-09 20:29 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c2cf36a-f274-4940-882c-4935aa38f2e9@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).