From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: new $_inferior_threads convenience variable
Date: Wed, 2 Nov 2022 10:56:18 -0400 [thread overview]
Message-ID: <2c4aba2a-f30b-d73c-2988-d76c18849226@simark.ca> (raw)
In-Reply-To: <20221102143416.3307157-1-aburgess@redhat.com>
On 11/2/22 10:34, Andrew Burgess via Gdb-patches wrote:
> Add a new convenience variable $_inferior_threads that contains the
> number of (non-exited) threads in the current inferior. This can be
> used in command scripts, or breakpoint conditions, etc to adjust the
> behaviour for multi-threaded inferiors.
I don't really have time to look at the code, but here's a naming nit: I
think the name should contain "number" or "count" or something like
that. The name "_inferior_threads" makes me think it yields a list of
threads, somehow.
Simon
next prev parent reply other threads:[~2022-11-02 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 14:34 Andrew Burgess
2022-11-02 14:56 ` Simon Marchi [this message]
2022-11-02 15:07 ` Luis Machado
2022-11-03 14:42 ` [PATCHv2] gdb: new $_inferior_thread_count " Andrew Burgess
2022-11-03 14:48 ` Eli Zaretskii
2022-11-03 15:03 ` Luis Machado
2022-11-17 14:51 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c4aba2a-f30b-d73c-2988-d76c18849226@simark.ca \
--to=simark@simark.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).