gdb build broken in sim with -Wall -Werror

gdb build broken in sim with -Wall -Werror

[Tom de Vries]

Hi,

this morning I tried to rebuild gdb from trunk @ f4fdd84587e (with
--enable-werror and CFLAGS="-O0 -g -Wall", as usual) and ran into build
errors in sim.

Specifically:
...
$ grep error: build/MAKELOG \
  | grep -v handle_error \
  | sed "s/.*error: //" \
  | sort \
  | uniq -c
      6 comparison between 'attach_type {aka enum _attach_type}' and
'enum <anonymous>' [-Werror=enum-compare]
     54 'cpu_create' defined but not used [-Werror=unused-function]
     42 'cpu_data_map' defined but not used [-Werror=unused-function]
     54 'cpu_instruction_map' defined but not used [-Werror=unused-function]
     54 'cpu_interrupts' defined but not used [-Werror=unused-function]
     42 'cpu_model' defined but not used [-Werror=unused-function]
     51 'cpu_monitor' defined but not used [-Werror=unused-function]
     54 'cpu_os_emulation' defined but not used [-Werror=unused-function]
     27 'cpu_registers' defined but not used [-Werror=unused-function]
     51 'cpu_reservation' defined but not used [-Werror=unused-function]
     45 'cpu_system' defined but not used [-Werror=unused-function]
      3 'device_event_queue_deschedule' declared 'static' but never
defined [-Werror=unused-function]
      3 'device_event_queue_time' declared 'static' but never defined
[-Werror=unused-function]
      3 'event_queue_create' defined but not used [-Werror=unused-function]
      3 'mon_cpu' defined but not used [-Werror=unused-function]
      3 'mon_create' defined but not used [-Werror=unused-function]
      3 null argument where non-null required (argument 1) [-Werror=nonnull]
     15 pointer targets in passing argument 4 of
'device_find_integer_array_property' differ in signedness
[-Werror=pointer-sign]
...

Thanks,
- Tom

Re: gdb build broken in sim with -Wall -Werror

[Mike Frysinger]

On 17 May 2021 09:02, Tom de Vries wrote:
> this morning I tried to rebuild gdb from trunk @ f4fdd84587e (with
> --enable-werror and CFLAGS="-O0 -g -Wall", as usual)

the build will add appropriate warning flags for you.  you shouldn't be
forcing your own set into the mix.

> and ran into build errors in sim.
> 
> Specifically:

these snippets are much too truncated to be actionable.
-mike

Re: gdb build broken in sim with -Wall -Werror

[Tom de Vries]

On 5/17/21 5:02 PM, Mike Frysinger wrote:
> On 17 May 2021 09:02, Tom de Vries wrote:
>> this morning I tried to rebuild gdb from trunk @ f4fdd84587e (with
>> --enable-werror and CFLAGS="-O0 -g -Wall", as usual)
> 
> the build will add appropriate warning flags for you.  you shouldn't be
> forcing your own set into the mix.
> 

True.  This configuration did build before though, so it actually seems
to work quite well.

>> and ran into build errors in sim.
>>
>> Specifically:
> 
> these snippets are much too truncated to be actionable.

I'll send you the build log off-list.

Thanks,
- Tom

Re: gdb build broken in sim with -Wall -Werror

[Tom de Vries]

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

On 5/17/21 5:39 PM, Tom de Vries wrote:
> On 5/17/21 5:02 PM, Mike Frysinger wrote:
>> On 17 May 2021 09:02, Tom de Vries wrote:
>>> this morning I tried to rebuild gdb from trunk @ f4fdd84587e (with
>>> --enable-werror and CFLAGS="-O0 -g -Wall", as usual)
>>
>> the build will add appropriate warning flags for you.  you shouldn't be
>> forcing your own set into the mix.
>>
> 
> True.  This configuration did build before though, so it actually seems
> to work quite well.
> 
>>> and ran into build errors in sim.
>>>
>>> Specifically:
>>
>> these snippets are much too truncated to be actionable.
> 
> I'll send you the build log off-list.
> 

There you go.

Thanks,
- Tom


[-- Attachment #2: MAKELOG.gz --]
[-- Type: application/gzip, Size: 85231 bytes --]

Re: gdb build broken in sim with -Wall -Werror

[Mike Frysinger]

On 17 May 2021 17:39, Tom de Vries wrote:
> On 5/17/21 5:39 PM, Tom de Vries wrote:
> > On 5/17/21 5:02 PM, Mike Frysinger wrote:
> >> On 17 May 2021 09:02, Tom de Vries wrote:
> >>> this morning I tried to rebuild gdb from trunk @ f4fdd84587e (with
> >>> --enable-werror and CFLAGS="-O0 -g -Wall", as usual)
> >>
> >> the build will add appropriate warning flags for you.  you shouldn't be
> >> forcing your own set into the mix.
> >>
> > 
> > True.  This configuration did build before though, so it actually seems
> > to work quite well.
> > 
> >>> and ran into build errors in sim.
> >>>
> >>> Specifically:
> >>
> >> these snippets are much too truncated to be actionable.
> > 
> > I'll send you the build log off-list.
> 
> There you go.

it's a bit hard to read ... you should pass -O to make to avoid all of
the intermingling of jobs.

it looks like all the errors are coming from sim/ppc/.  it's built with
-Werror now, but not -Wall, so that's why it's not failing in general.
prob not too hard to cleanup & add -Wall, but i'm not looking into that
atm.
-mike

Re: gdb build broken in sim with -Wall -Werror

[Tom de Vries]

On 5/18/21 5:12 PM, Mike Frysinger wrote:
> On 17 May 2021 17:39, Tom de Vries wrote:
>> On 5/17/21 5:39 PM, Tom de Vries wrote:
>>> On 5/17/21 5:02 PM, Mike Frysinger wrote:
>>>> On 17 May 2021 09:02, Tom de Vries wrote:
>>>>> this morning I tried to rebuild gdb from trunk @ f4fdd84587e (with
>>>>> --enable-werror and CFLAGS="-O0 -g -Wall", as usual)
>>>>
>>>> the build will add appropriate warning flags for you.  you shouldn't be
>>>> forcing your own set into the mix.
>>>>
>>>
>>> True.  This configuration did build before though, so it actually seems
>>> to work quite well.
>>>
>>>>> and ran into build errors in sim.
>>>>>
>>>>> Specifically:
>>>>
>>>> these snippets are much too truncated to be actionable.
>>>
>>> I'll send you the build log off-list.
>>
>> There you go.
> 
> it's a bit hard to read ... you should pass -O to make to avoid all of
> the intermingling of jobs.
> 

Yeah, unfortunately I'm keeping building with make 3.81 alive, and
consequently I don't have that available.

> it looks like all the errors are coming from sim/ppc/.  it's built with
> -Werror now, but not -Wall, so that's why it's not failing in general.
> prob not too hard to cleanup & add -Wall, but i'm not looking into that
> atm.

Ack, understood.

Thanks,
- Tom