[PATCH] testsuite/gdb.dwarf2: avoid dead code in dw2-inline-with-lexical-scope.c

[PATCH] testsuite/gdb.dwarf2: avoid dead code in dw2-inline-with-lexical-scope.c

[Tankut Baris Aktemur]

The test in gdb.dwarf2/dw2-inline-with-lexical-scope.c fails with icc.
The reason is, icc did not emit code for a dead statement, which in
turn caused some labels to be collapsed.  Fix this by replacing the
dead code with assignment to a global value.  The statement itself
does not change the test scenario.

Also fix a whitespacing problem around an assignment operator.

gdb/testsuite/ChangeLog:
2021-05-19  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>

	* gdb.dwarf2/dw2-inline-with-lexical-scope.c (func): Replace
	a dead code with an assignment to a global var.  Fix a
	whitespacing problem around an assignment operator.
---
 gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.c b/gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.c
index ef9b71af4e0..c5f42806a22 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.c
+++ b/gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.c
@@ -30,14 +30,14 @@ static void
 func ()
 { /* func prologue */
   global_num = 42;
-  int num= 42;
+  int num = 42;
   if (num > 2)
     {
       asm ("scope_label1: .globl scope_label1");
       global_value = num;
       int value = num;
       asm ("breakpoint_label: .globl breakpoint_label");
-      value += 10;
+      global_value += value;
       asm ("scope_label2: .globl scope_label2");
     }
 } /* func end */
-- 
2.17.1

Re: [PATCH] testsuite/gdb.dwarf2: avoid dead code in dw2-inline-with-lexical-scope.c

[Simon Marchi]

On 2021-05-19 8:56 a.m., Tankut Baris Aktemur via Gdb-patches wrote:
> The test in gdb.dwarf2/dw2-inline-with-lexical-scope.c fails with icc.
> The reason is, icc did not emit code for a dead statement, which in
> turn caused some labels to be collapsed.  Fix this by replacing the
> dead code with assignment to a global value.  The statement itself
> does not change the test scenario.
> 
> Also fix a whitespacing problem around an assignment operator.

LGTM, thanks.

Simon