Re: [PATCH 05/12] gdb: add breakpoint::first_loc methods

[Simon Marchi <simark@simark.ca>]

On 5/18/23 08:50, Andrew Burgess via Gdb-patches wrote:
> Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
>> Add convenience first_loc methods to struct breakpoint (const and
>> non-const overloads).  A subsequent patch changes the list of locations
>> to be an intrusive_list and makes the actual list private, so these
>> spots would need to become something ugly like:
>>
>>   -b->loc
>>   +*b->locations ().begin ()
> 
> It took me longer than I'd like to admit to realise the leading -/+ here
> were indicating that this was an extract from a diff.  Maybe there's
> some way to make it clearer?  Or just drop the first line, I think the
> second line is clear enough (given the description before).

Sorry, I thought I was being smart writing it this way.  I'll change it
to say, these spots would need from:

  b->loc

to something ugly like:

  b->locations ().begin ()

>> @@ -8178,17 +8177,18 @@ momentary_breakpoint_from_master (struct breakpoint *orig,
>>    std::unique_ptr<breakpoint> copy
>>      (new_momentary_breakpoint (orig->gdbarch, type, orig->pspace,
>>  			       orig->frame_id, thread));
>> +  bp_location &orig_loc = orig->first_loc ();
> 
> Maybe 'const bp_location &' ?

Yes, changed.

> Otherwise, looks good.

Thanks,

Simon