Re: [PATCH 12/12] gdb: remove breakpoint_pointer_iterator

[Simon Marchi <simon.marchi@efficios.com>]

>> @@ -3055,12 +3052,12 @@ breakpoint_program_space_exit (struct program_space *pspace)
>>  void
>>  insert_breakpoints (void)
>>  {
>> -  for (breakpoint *bpt : all_breakpoints ())
>> -    if (is_hardware_watchpoint (bpt))
>> +  for (breakpoint &bpt : all_breakpoints ())
>> +    if (is_hardware_watchpoint (&bpt))
>>        {
>> -	struct watchpoint *w = (struct watchpoint *) bpt;
>> +	watchpoint &w = static_cast<watchpoint &> (bpt);
> 
> Could possibly use gdb::checked_static_cast here?  And in other places
> throughout this patch?

checked_static_cast doesn't work with references though... so I would
have to write:

  watchpoint &w = *gdb::checked_static_cast<watchpoint *> (&bpt);

Do you think it's possible to make checked_static_cast work for
references?  I'll give it a try.

>> diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
>> index a03b57734b9d..c0d73d374cb0 100644
>> --- a/gdb/breakpoint.h
>> +++ b/gdb/breakpoint.h
> 
> In patch #7 you added:
> 
>   #include "gdbsupport/reference-to-pointer-iterator.h"
> 
> Is this still needed after this patch?  I haven't checked, but it feels
> like maybe it could be removed now.

Yep removed.

Simon