From: Tom de Vries <tdevries@suse.de>
To: Guinevere Larsen <blarsen@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 1/2] gdb/testsuite: fix gdb.threads/threadcrash.exp on 32-bit arm targets
Date: Fri, 8 Mar 2024 11:01:53 +0100 [thread overview]
Message-ID: <30e8c69c-e5ef-4fd5-8328-85413b21de4c@suse.de> (raw)
In-Reply-To: <20240214091712.223928-3-blarsen@redhat.com>
On 2/14/24 10:17, Guinevere Larsen wrote:
> -test_gcore
> +if { [is_aarch32_target] } {
> + kfail "gcore tests fail on 32-bit arm, see PR corefiles/31294"
> +} else {
> + test_gcore
> +}
The xfail and kfail procs don't have the same args:
...
$ egrep -d skip "proc (xfail|kfail)" /usr/share/dejagnu/*
/usr/share/dejagnu/framework.exp:proc xfail { message } {
/usr/share/dejagnu/framework.exp:proc kfail { bugid message } {
...
and consequently this patch runs into an error.
Furthermore, I don't run into the reported problem on my setup (pinebook
aarch64 manjaro, chroot debian 32-bit), so this style of kfail actually
prevents me from successfully running the tests.
I proposed a more precise fix in v4, though I can't test it ...
Thanks,
- Tom
next prev parent reply other threads:[~2024-03-08 10:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 9:17 [PATCH v3 0/2] Fixes to gdb.threads/threadcrash.exp Guinevere Larsen
2024-02-14 9:17 ` [PATCH v3 1/2] gdb/testsuite: fix gdb.threads/threadcrash.exp on 32-bit arm targets Guinevere Larsen
2024-02-15 14:37 ` Lancelot SIX
2024-03-08 10:01 ` Tom de Vries [this message]
2024-03-08 10:12 ` Tom de Vries
2024-02-14 9:17 ` [PATCH v3 2/2] gdb/testsuite: reduce gdb.threads/threadcrash.exp reliance on libc symbols Guinevere Larsen
2024-03-06 17:16 ` Tom de Vries
2024-03-07 9:11 ` Guinevere Larsen
2024-03-07 18:23 ` Tom de Vries
2024-03-06 13:02 ` [PING][PATCH v3 0/2] Fixes to gdb.threads/threadcrash.exp Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30e8c69c-e5ef-4fd5-8328-85413b21de4c@suse.de \
--to=tdevries@suse.de \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).