From: Guinevere Larsen <blarsen@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/2] gdb/testsuite: reduce gdb.threads/threadcrash.exp reliance on libc symbols
Date: Thu, 7 Mar 2024 10:11:33 +0100 [thread overview]
Message-ID: <b962915d-e3a5-4368-87e3-2f55e9545e55@redhat.com> (raw)
In-Reply-To: <d42902af-984e-4ef5-8cce-f991023238e8@suse.de>
On 06/03/2024 18:16, Tom de Vries wrote:
> On 2/14/24 10:17, Guinevere Larsen wrote:
>> The test gdb.threads/threadcrash.exp demanded GDB to fully unwind and
>> print the names of all functions. However, some of the functions are
>> from the libc library, and so the test implicitly demanded libc symbols
>> to be available, and would fail otherwise, as was raised in PR
>> gdb/31293.
>>
>> This commit changes it so we only explicitly check for functions that
>> are provided by threadcrash.c to fix that
>
> Hi Gwen,
>
> Nit: Missing dot at end of line.
>
> With that fixed, LGTM.
>
> Approved-By: Tom de Vries <tdevries@suse.de>
Thanks for the review!
Would this apply to both patches or just this second one?
--
Cheers,
Guinevere Larsen
She/Her/Hers
>
> Thanks,
> - Tom
>
>>
>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31293
>> ---
>> gdb/testsuite/gdb.threads/threadcrash.exp | 17 +++++++----------
>> 1 file changed, 7 insertions(+), 10 deletions(-)
>>
>> diff --git a/gdb/testsuite/gdb.threads/threadcrash.exp
>> b/gdb/testsuite/gdb.threads/threadcrash.exp
>> index bf4534179e2..2bbedcce58e 100644
>> --- a/gdb/testsuite/gdb.threads/threadcrash.exp
>> +++ b/gdb/testsuite/gdb.threads/threadcrash.exp
>> @@ -40,26 +40,23 @@ proc thread_apply_all {} {
>> exp_continue
>> }
>> -re "\[^\n\]*syscall_task
>> .location=SIGNAL_ALT_STACK\[^\n\]*" {
>> - lappend test_list [multi_line ".*sleep.*" \
>> - ".*do_syscall_task
>> .location=SIGNAL_ALT_STACK.*" \
>> + lappend test_list [multi_line ".*do_syscall_task
>> .location=SIGNAL_ALT_STACK.*" \
>> ".*signal_handler.*" \
>> ".*signal handler called.*" \
>> - ".*pthread_kill.*" \
>> + ".*" \
>> ".*thread_function.*"]
>> exp_continue
>> }
>> -re "\[^\n\]*syscall_task .location=SIGNAL_HANDLER\[^\n\]*" {
>> - lappend test_list [multi_line ".*sleep.*" \
>> - ".*do_syscall_task
>> .location=SIGNAL_HANDLER.*" \
>> + lappend test_list [multi_line ".*do_syscall_task
>> .location=SIGNAL_HANDLER.*" \
>> ".*signal_handler.*" \
>> ".*signal handler called.*" \
>> - ".*pthread_kill.*" \
>> + ".*" \
>> ".*thread_function.*"]
>> exp_continue
>> }
>> -re "\[^\n\]*syscall_task .location=NORMAL\[^\n\]*" {
>> - lappend test_list [multi_line ".*sleep.*" \
>> - ".*do_syscall_task .location=NORMAL.*" \
>> + lappend test_list [multi_line ".*do_syscall_task
>> .location=NORMAL.*" \
>> ".*thread_function.*"]
>> exp_continue
>> }
>> @@ -67,7 +64,7 @@ proc thread_apply_all {} {
>> lappend test_list [multi_line ".*do_spin_task
>> .location=SIGNAL_ALT_STACK.*" \
>> ".*signal_handler.*" \
>> ".*signal handler called.*" \
>> - ".*pthread_kill.*" \
>> + ".*" \
>> ".*thread_function.*"]
>> exp_continue
>> }
>> @@ -75,7 +72,7 @@ proc thread_apply_all {} {
>> lappend test_list [multi_line ".*do_spin_task
>> .location=SIGNAL_HANDLER.*" \
>> ".*signal_handler.*" \
>> ".*signal handler called.*" \
>> - ".*pthread_kill.*" \
>> + ".*" \
>> ".*thread_function.*"]
>> exp_continue
>> }
>
next prev parent reply other threads:[~2024-03-07 9:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 9:17 [PATCH v3 0/2] Fixes to gdb.threads/threadcrash.exp Guinevere Larsen
2024-02-14 9:17 ` [PATCH v3 1/2] gdb/testsuite: fix gdb.threads/threadcrash.exp on 32-bit arm targets Guinevere Larsen
2024-02-15 14:37 ` Lancelot SIX
2024-03-08 10:01 ` Tom de Vries
2024-03-08 10:12 ` Tom de Vries
2024-02-14 9:17 ` [PATCH v3 2/2] gdb/testsuite: reduce gdb.threads/threadcrash.exp reliance on libc symbols Guinevere Larsen
2024-03-06 17:16 ` Tom de Vries
2024-03-07 9:11 ` Guinevere Larsen [this message]
2024-03-07 18:23 ` Tom de Vries
2024-03-06 13:02 ` [PING][PATCH v3 0/2] Fixes to gdb.threads/threadcrash.exp Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b962915d-e3a5-4368-87e3-2f55e9545e55@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).