* [pushed] [gdb/testsuite] Fix regexp in gdb.base/foll-vfork.exp
@ 2021-11-12 16:12 Tom de Vries
2021-11-12 16:18 ` Simon Marchi
0 siblings, 1 reply; 4+ messages in thread
From: Tom de Vries @ 2021-11-12 16:12 UTC (permalink / raw)
To: gdb-patches
On OBS I ran into:
...
(gdb) PASS: gdb.base/foll-vfork.exp: exit: \
vfork relations in info inferiors: continue to child exit
info inferiors^M
Num Description Connection Executable ^M
1 <null> foll-vfork-exit ^M
* 2 <null> foll-vfork-exit ^M
(gdb) I'm the proud parent of child #5044!^M
FAIL: gdb.base/foll-vfork.exp: exit: vfork relations in info inferiors: \
vfork relation no longer appears in info inferiors (timeout)
...
Fix this by removing the '$' anchor in the corresponding '$gdb_prompt $'
regexps.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.base/foll-vfork.exp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/gdb.base/foll-vfork.exp b/gdb/testsuite/gdb.base/foll-vfork.exp
index 577bd4d573b..a781a5c2087 100644
--- a/gdb/testsuite/gdb.base/foll-vfork.exp
+++ b/gdb/testsuite/gdb.base/foll-vfork.exp
@@ -374,13 +374,13 @@ proc vfork_relations_in_info_inferiors { variant } {
set test "vfork relation no longer appears in info inferiors"
gdb_test_multiple "info inferiors" $test {
- -re "is vfork child of inferior 1.*$gdb_prompt $" {
+ -re "is vfork child of inferior 1.*$gdb_prompt " {
fail $test
}
- -re "is vfork parent of inferior 2.*$gdb_prompt $" {
+ -re "is vfork parent of inferior 2.*$gdb_prompt " {
fail $test
}
- -re "$gdb_prompt $" {
+ -re "$gdb_prompt " {
pass $test
}
}
base-commit: 0b32f05baccc6e1ab7f74a55254c5db86e22522b
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pushed] [gdb/testsuite] Fix regexp in gdb.base/foll-vfork.exp
2021-11-12 16:12 [pushed] [gdb/testsuite] Fix regexp in gdb.base/foll-vfork.exp Tom de Vries
@ 2021-11-12 16:18 ` Simon Marchi
2021-11-12 17:13 ` Tom de Vries
0 siblings, 1 reply; 4+ messages in thread
From: Simon Marchi @ 2021-11-12 16:18 UTC (permalink / raw)
To: Tom de Vries, gdb-patches
On 2021-11-12 11:12 a.m., Tom de Vries via Gdb-patches wrote:
> On OBS I ran into:
> ...
> (gdb) PASS: gdb.base/foll-vfork.exp: exit: \
> vfork relations in info inferiors: continue to child exit
> info inferiors^M
> Num Description Connection Executable ^M
> 1 <null> foll-vfork-exit ^M
> * 2 <null> foll-vfork-exit ^M
> (gdb) I'm the proud parent of child #5044!^M
> FAIL: gdb.base/foll-vfork.exp: exit: vfork relations in info inferiors: \
> vfork relation no longer appears in info inferiors (timeout)
> ...
>
> Fix this by removing the '$' anchor in the corresponding '$gdb_prompt $'
> regexps.
Alternatively, can we just remove the "I'm the proud parent of..."
printout? It doesn't seem to be used for anything useful.
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pushed] [gdb/testsuite] Fix regexp in gdb.base/foll-vfork.exp
2021-11-12 16:18 ` Simon Marchi
@ 2021-11-12 17:13 ` Tom de Vries
2021-11-15 11:22 ` Tom de Vries
0 siblings, 1 reply; 4+ messages in thread
From: Tom de Vries @ 2021-11-12 17:13 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
On 11/12/21 5:18 PM, Simon Marchi wrote:
> On 2021-11-12 11:12 a.m., Tom de Vries via Gdb-patches wrote:
>> On OBS I ran into:
>> ...
>> (gdb) PASS: gdb.base/foll-vfork.exp: exit: \
>> vfork relations in info inferiors: continue to child exit
>> info inferiors^M
>> Num Description Connection Executable ^M
>> 1 <null> foll-vfork-exit ^M
>> * 2 <null> foll-vfork-exit ^M
>> (gdb) I'm the proud parent of child #5044!^M
>> FAIL: gdb.base/foll-vfork.exp: exit: vfork relations in info inferiors: \
>> vfork relation no longer appears in info inferiors (timeout)
>> ...
>>
>> Fix this by removing the '$' anchor in the corresponding '$gdb_prompt $'
>> regexps.
>
> Alternatively, can we just remove the "I'm the proud parent of..."
> printout? It doesn't seem to be used for anything useful.
That's not a bad idea. I could put it under '#if DEBUG' or some such to
disable it by default.
Thanks,
- Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pushed] [gdb/testsuite] Fix regexp in gdb.base/foll-vfork.exp
2021-11-12 17:13 ` Tom de Vries
@ 2021-11-15 11:22 ` Tom de Vries
0 siblings, 0 replies; 4+ messages in thread
From: Tom de Vries @ 2021-11-15 11:22 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
On 11/12/21 6:13 PM, Tom de Vries via Gdb-patches wrote:
> On 11/12/21 5:18 PM, Simon Marchi wrote:
>> On 2021-11-12 11:12 a.m., Tom de Vries via Gdb-patches wrote:
>>> On OBS I ran into:
>>> ...
>>> (gdb) PASS: gdb.base/foll-vfork.exp: exit: \
>>> vfork relations in info inferiors: continue to child exit
>>> info inferiors^M
>>> Num Description Connection Executable ^M
>>> 1 <null> foll-vfork-exit ^M
>>> * 2 <null> foll-vfork-exit ^M
>>> (gdb) I'm the proud parent of child #5044!^M
>>> FAIL: gdb.base/foll-vfork.exp: exit: vfork relations in info inferiors: \
>>> vfork relation no longer appears in info inferiors (timeout)
>>> ...
>>>
>>> Fix this by removing the '$' anchor in the corresponding '$gdb_prompt $'
>>> regexps.
>>
>> Alternatively, can we just remove the "I'm the proud parent of..."
>> printout? It doesn't seem to be used for anything useful.
>
> That's not a bad idea. I could put it under '#if DEBUG' or some such to
> disable it by default.
>
Submitted here:
https://sourceware.org/pipermail/gdb-patches/2021-November/183405.html .
Thanks,
- Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-15 11:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 16:12 [pushed] [gdb/testsuite] Fix regexp in gdb.base/foll-vfork.exp Tom de Vries
2021-11-12 16:18 ` Simon Marchi
2021-11-12 17:13 ` Tom de Vries
2021-11-15 11:22 ` Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).