Re: [PATCH] gdb/DAP Few bug fixes & Evaluate Array Watch vars

[Simon Farre <simon.farre.cx@gmail.com>]

No, not necessarily, if we for instance is retrieving children of an 
array, or the expression
el[3]@7; then each "name" of the children will be, 1,2,3 ..., i.e. 
numbers. This will make displaying any of them in VSCode not work.

On 6/20/23 16:49, Tom Tromey wrote:
>>>>>> "Simon" == Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:
> Simon> First of all, name of VariableReferences must always be of string type.
>
> Do you mean if it is not None?
>
> If so then the EvaluateResult change isn't needed.
> But if None shouldn't be accepted, then BaseReference.to_object could be
> changed.
>
> Did this cause a problem somewhere?
>
> Simon> The result[self.result_name] also f-strings the printer.to_string()
> Simon> value, because this can potentially be a LazyString (which is a Python
> Simon> object, not a string) and is not serializable by json.dumps.
>
> We've been avoiding f-strings because some LTS distros are stuck on
> versions of Python without them.  I think using str() is fine though.
>
> Tom