From: Tom Tromey <tom@tromey.com>
To: Simon Farre via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Farre <simon.farre.cx@gmail.com>, tom@tromey.com
Subject: Re: [PATCH] gdb/DAP Few bug fixes & Evaluate Array Watch vars
Date: Tue, 20 Jun 2023 08:49:24 -0600 [thread overview]
Message-ID: <87fs6m2npn.fsf@tromey.com> (raw)
In-Reply-To: <20230620081549.202591-1-simon.farre.cx@gmail.com> (Simon Farre via Gdb-patches's message of "Tue, 20 Jun 2023 10:15:49 +0200")
>>>>> "Simon" == Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> First of all, name of VariableReferences must always be of string type.
Do you mean if it is not None?
If so then the EvaluateResult change isn't needed.
But if None shouldn't be accepted, then BaseReference.to_object could be
changed.
Did this cause a problem somewhere?
Simon> The result[self.result_name] also f-strings the printer.to_string()
Simon> value, because this can potentially be a LazyString (which is a Python
Simon> object, not a string) and is not serializable by json.dumps.
We've been avoiding f-strings because some LTS distros are stuck on
versions of Python without them. I think using str() is fine though.
Tom
next prev parent reply other threads:[~2023-06-20 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 8:15 Simon Farre
2023-06-20 8:25 ` Simon Farre
2023-06-20 14:49 ` Tom Tromey [this message]
2023-06-20 18:41 ` Simon Farre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs6m2npn.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.farre.cx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).