public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
	Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] [gdb/tui] Add set tui border-kind acs-or-space/acs-or-ascii
Date: Sat, 16 Dec 2023 10:50:07 +0100	[thread overview]
Message-ID: <32ce8d21-fe2c-469d-b4d9-2b59a6c3890d@suse.de> (raw)
In-Reply-To: <87wmtf5k1i.fsf@tromey.com>

On 12/15/23 20:43, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> I don't recall if we discussed or finished discussing this...
> 
> Tom> The gdb TUI testsuite uses a custom ansi terminal emulator (tuiterm.exp) in
> Tom> order to be able to inspect the state of the terminal, and consequently runs
> Tom> all test-cases using TERM=ansi.
> 
> Tom> Once in a while I manually replay a test-case on an actual terminal emulator,
> Tom> using TERM=ansi to make sure I trigger the same behaviour, and run into funny
> Tom> looking borders, like this:
> Tom> ...
> Tom> ÚÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄ¿
> Tom> ³                             ³
> Tom> ³ [ No Source Available ]     ³
> Tom> ³                             ³
> Tom> ÀÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÙ
> Tom> ...
> Tom> This is PR tui/30370.
> 
> IIUC, you are not using an actual ANSI terminal, but some other thing,
> and then setting TERM=ansi?
> 

Yes (and some other thing meaning xterm, gnome-terminal or konsole).

> I think in this case you should just expect that things will go wrong.
> TERM has to reflect the capabilities of the actual terminal.  I tend to
> think gdb shouldn't try to work around this kind of thing, if a user
> does this it will probably affect any terminal-aware program.

Agreed.

FWIW, my meta concern here was difference in behaviour between 
test-cases run in the testsuite, and replaying those scenarios in an xterm.

I think this concern is better addressed by the ansi-for-tui proposal (
https://sourceware.org/pipermail/gdb-patches/2023-May/199761.html ).

Thanks,
- Tom


      reply	other threads:[~2023-12-16  9:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 13:37 Tom de Vries
2023-12-15 19:43 ` Tom Tromey
2023-12-16  9:50   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32ce8d21-fe2c-469d-b4d9-2b59a6c3890d@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).