From: Keith Seitz <keiths@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix "spawn id XYZ not open" errors in gdb.mi/mi-exec-run.exp
Date: Mon, 28 Feb 2022 11:57:56 -0800 [thread overview]
Message-ID: <337376b8-74f4-8e09-81c7-88452ba656e9@redhat.com> (raw)
In-Reply-To: <87k0dezykj.fsf@redhat.com>
On 2/28/22 09:32, Andrew Burgess wrote:
> Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> [1] Anyone know why this test doesn't simply use gdb_test_multiple? I can only
>> assume that it was intentionally written this way, and I've modified the code with
>> that assumption. I have tested a version using gdb_test_multiple, and that appears
>> to work fine, too, if that is preferred. [It still employs exp_continue to fix the
>> spawn_id errors.]
>
> As the reasoning isn't discussed in the .exp file, the commit message,
> or in the original mailing list thread, I'd assume it was just an
> oversight. If you see the same pass/fail using the gdb_test_multiple,
> then I think it woud be a nice cleanup to switch over.
I've tried testing this a bit more, and it looks like gdb_test_multiple
"interferes" with the testing because of all the built-in matches. So we see
"spurious" (as far as this test is concerned) "Process no longer exists" errors,
and these end up racy between runs.
So in that case, I will retract the gdb_test_multiple bit. I wonder if this
was discussed this on IRC in the distant past?
Thanks for the review!
Keith
prev parent reply other threads:[~2022-02-28 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 17:41 Keith Seitz
2022-02-28 14:31 ` Alexandra Petlanova Hajkova
2022-02-28 17:32 ` Andrew Burgess
2022-02-28 19:57 ` Keith Seitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=337376b8-74f4-8e09-81c7-88452ba656e9@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).