* [PATCH] gdb/show_args_command: print to the ui_file argument
@ 2023-05-03 11:07 Lancelot SIX
2023-05-03 14:50 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Lancelot SIX @ 2023-05-03 11:07 UTC (permalink / raw)
To: gdb-patches; +Cc: lsix, Lancelot SIX
The show_args_command uses gdb_printf without specifying the ui_file.
This means that it prints to gdb_stdout instead of the stream given as
an argument to the function.
This commit fixes this.
---
gdb/infcmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index b8134665f3f..e42927858ba 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -144,7 +144,7 @@ show_args_command (struct ui_file *file, int from_tty,
{
/* Ignore the passed in value, pull the argument directly from the
inferior. However, these should always be the same. */
- gdb_printf (_("\
+ gdb_printf (file, _("\
Argument list to give program being debugged when it is started is \"%s\".\n"),
current_inferior ()->args ().c_str ());
}
base-commit: a07223191bdda5e85a500e3b8206ee8fe8bcdfed
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdb/show_args_command: print to the ui_file argument
2023-05-03 11:07 [PATCH] gdb/show_args_command: print to the ui_file argument Lancelot SIX
@ 2023-05-03 14:50 ` Tom Tromey
2023-05-03 15:31 ` Lancelot SIX
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2023-05-03 14:50 UTC (permalink / raw)
To: Lancelot SIX via Gdb-patches; +Cc: Lancelot SIX, lsix
>>>>> Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:
> The show_args_command uses gdb_printf without specifying the ui_file.
> This means that it prints to gdb_stdout instead of the stream given as
> an argument to the function.
> This commit fixes this.
Thanks, this is ok.
Reviewed-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdb/show_args_command: print to the ui_file argument
2023-05-03 14:50 ` Tom Tromey
@ 2023-05-03 15:31 ` Lancelot SIX
0 siblings, 0 replies; 3+ messages in thread
From: Lancelot SIX @ 2023-05-03 15:31 UTC (permalink / raw)
To: Tom Tromey, Lancelot SIX via Gdb-patches; +Cc: lsix
Thanks.
I have just pushed this patch.
Lancelot.
On 03/05/2023 15:50, Tom Tromey wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
>>>>>> Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> The show_args_command uses gdb_printf without specifying the ui_file.
>> This means that it prints to gdb_stdout instead of the stream given as
>> an argument to the function.
>
>> This commit fixes this.
>
> Thanks, this is ok.
> Reviewed-By: Tom Tromey <tom@tromey.com>
>
> Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-03 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-03 11:07 [PATCH] gdb/show_args_command: print to the ui_file argument Lancelot SIX
2023-05-03 14:50 ` Tom Tromey
2023-05-03 15:31 ` Lancelot SIX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).