From: Guinevere Larsen <blarsen@redhat.com>
To: Tom Tromey <tom@tromey.com>,
Guinevere Larsen via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 3/4] gdb/testsuite: fix testing gdb.reverse/step-reverse.exp with clang
Date: Mon, 21 Aug 2023 09:23:53 +0200 [thread overview]
Message-ID: <3491d433-6d44-51d7-daee-20eae03012f5@redhat.com> (raw)
In-Reply-To: <87ttsww567.fsf@tromey.com>
On 18/08/2023 20:56, Tom Tromey wrote:
>>>>>> "Guinevere" == Guinevere Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
> Guinevere> It also adds a new parameter to get_hexadecimal_valueof, so that we can
> Guinevere> use it without generating new passes, otherwise we'd get multiple
> Guinevere> duplicate test names. This change shouldn't affect any other test using
> Guinevere> this proc.
>
> I thought there was a different thread about this?
>
> To me it seems weirder to have the potential for a fail without a
> corresponding pass. Though I suppose both situations are lame.
You're right, there was a thread about this!
I actually removed this change, but forgot to change the commit message.
I'll remove this last paragraph completely.
--
Cheers,
Guinevere Larsen
She/Her/Hers
next prev parent reply other threads:[~2023-08-21 7:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 10:48 [PATCH v3 0/4] Many fixes to gdb.reverse tests when testing Guinevere Larsen
2023-08-14 10:48 ` [PATCH v3 1/4] gdb/testsuite: Fix many errors in gdb.reverse with clang Guinevere Larsen
2023-08-14 10:48 ` [PATCH v3 2/4] gdb/testsuite: fix gdb.reverse/solib-*.exp tests when using clang Guinevere Larsen
2023-08-14 10:48 ` [PATCH v3 3/4] gdb/testsuite: fix testing gdb.reverse/step-reverse.exp with clang Guinevere Larsen
2023-08-18 18:56 ` Tom Tromey
2023-08-21 7:23 ` Guinevere Larsen [this message]
2023-08-14 10:48 ` [PATCH v3 4/4] gdb/testsuite: Multiple improvements for gdb.reverse/insn-reverse.exp Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3491d433-6d44-51d7-daee-20eae03012f5@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).