From: Tom de Vries <tdevries@suse.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/cli] Add maint info screen
Date: Fri, 21 Apr 2023 17:21:39 +0200 [thread overview]
Message-ID: <3871cc3c-9108-06c2-d23a-f54d1adf12e6@suse.de> (raw)
In-Reply-To: <83edoia0kz.fsf@gnu.org>
On 4/17/23 19:19, Eli Zaretskii wrote:
>> Date: Mon, 17 Apr 2023 16:09:06 +0200
>> From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
>>
>> gdb/doc/gdb.texinfo | 7 +++++
>> gdb/utils.c | 70 +++++++++++++++++++++++++++++++++++++++++++--
>> 2 files changed, 75 insertions(+), 2 deletions(-)
>
> Thanks for working on this.
>
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -41363,6 +41363,13 @@ This option is @samp{on} by default for supported architectures.
>> This option is useful for debugging @value{GDBN}'s use of the Pygments
>> library when @value{GDBN} is built for an architecture that supports
>> styling with the builtin disassembler
>> +
>> +@kindex maint info screen
>> +@cindex Show screen characteristics
> ^^^^
> Please avoid capital letters in index entries as much as possible.
> That's because differences in letter-case can cause the index entries
> be sorted in different order depending on the locale where the manual
> is built, and we want to avoid this locale dependency if possible.
>
Ack, done.
>> +@item maint info screen
>> +Print various characteristics of the screen, such as various notions
>> +of width and height.
>
> Maybe say what will this be useful for?
>
I haven't managed to come up with something meaningful here, so I've
left it as is.
I'm open to further suggestions, but I've committed to be able to use it
in test-cases.
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Thanks for the review.
- Tom
next prev parent reply other threads:[~2023-04-21 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 14:09 Tom de Vries
2023-04-17 17:19 ` Eli Zaretskii
2023-04-21 15:21 ` Tom de Vries [this message]
2023-04-21 13:54 ` Tom Tromey
2023-04-27 20:49 ` John Baldwin
2023-04-27 21:06 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3871cc3c-9108-06c2-d23a-f54d1adf12e6@suse.de \
--to=tdevries@suse.de \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).