From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdbsupport, gdbserver, gdb: use -Wno-vla-cxx-extension
Date: Wed, 17 Apr 2024 10:52:32 -0400 [thread overview]
Message-ID: <39009b0a-8a19-42a5-a0bc-afe1290d15aa@simark.ca> (raw)
In-Reply-To: <8734rkhq6j.fsf@tromey.com>
On 2024-04-16 18:56, Tom Tromey wrote:
> Simon> Here's the list of those I see in my build (x86-64 Linux all targets):
>
> Simon> I think we should have a vector type with "small vector optimization",
> Simon> it would be great to replace these uses of VLAs. I might give it a shot
> Simon> at some point (or maybe someone else wants to try?). But until then, I
> Simon> think it makes sense to silence the warning.
>
> I suppose I'm ok with that.
Ok, pushed. Whoever takes on the project of removing VLAs can remove
the flag.
> On the whole I'd prefer we remove VLAs (since they aren't standard) and
> alloca (since it is bad). I don't really care if we have a small vector
> unless it's proven we need it.
Agreed.
Simon
prev parent reply other threads:[~2024-04-17 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 17:51 Simon Marchi
2024-04-15 16:22 ` Tom Tromey
2024-04-15 16:32 ` Luis Machado
2024-04-15 16:48 ` Simon Marchi
2024-04-16 22:56 ` Tom Tromey
2024-04-17 14:52 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39009b0a-8a19-42a5-a0bc-afe1290d15aa@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).