From: Carl Love <cel@us.ibm.com>
To: gdb-patches@sourceware.org,
will schmidt <will_schmidt@vnet.ibm.com>,
Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Subject: [PING 2] [PATCH] Fix for gdb.base/stap-probe.c
Date: Thu, 30 Jun 2022 08:14:11 -0700 [thread overview]
Message-ID: <39ca01e864cfeb37c2b84252bd84529142d4703a.camel@us.ibm.com> (raw)
In-Reply-To: <dbaf3cb0822ecbf4550bae9e20193197f1ada435.camel@us.ibm.com>
On Wed, 2022-06-22 at 08:11 -0700, Carl Love wrote:
> Ping?
>
> On Tue, 2022-06-14 at 16:54 -0700, Carl Love wrote:
> > GDB maintainers:
> >
> > The gdb.base/stap-probe.exp test fails on Power 10 with a compile
> > error
> > due to a missing include file. The include file provides the
> > definition for ATTRIBUTE_NOCLONE. The following patch add the
> > missing
> > include file.
> >
> > The test now runs on Power 10 with 98 expected passes and 4
> > unsupported
> > tests.
> >
> > Please let me know if this patch is acceptable for mainline.
> >
> > Carl Love
> >
> > -----------------------------------------------------------------
> > ----
> > Fix for gdb.base/stap-probe.c
> >
> > On PowePC, the test fails on a compile error:
> >
> > /../binutils-gdb-current/gdb/testsuite/gdb.base/stap-
> > probe.c:107:1:
> > error: expected '=', ',', ';',
> > 'asm' or 'attribute' before 'use_xmm_reg'
> > 107 | use_xmm_reg (int val)
> > | ^~~~~~~~~~~
> >
> > Where the source code for stap-probe.c is:
> >
> > ...
> > static const char * __attribute__((noinline)) ATTRIBUTE_NOCLONE
> > use_xmm_reg (int val) <-- line 107
> > {
> > ...
> >
> > The issue is the ATTRIBUTE_NOCLONE is not defined as an attribute
> > as
> > expected. The #define for ATTRIBUTE_NOCLONE can be found in
> > ../lib/attributes.h.
> >
> > This patch adds the missing include statement for the definition of
> > ATTRIBUTE_NOCLONE.
> >
> > The patch has been tested and verified on a Power10 system.
> > ---
> > gdb/testsuite/gdb.base/stap-probe.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/gdb/testsuite/gdb.base/stap-probe.c
> > b/gdb/testsuite/gdb.base/stap-probe.c
> > index d1482c35caf..527f7e187eb 100644
> > --- a/gdb/testsuite/gdb.base/stap-probe.c
> > +++ b/gdb/testsuite/gdb.base/stap-probe.c
> > @@ -15,6 +15,8 @@
> > You should have received a copy of the GNU General Public
> > License
> > along with this program. If not, see <
> > http://www.gnu.org/licenses/>. */
> >
> > +#include "../lib/attributes.h"
> > +
> > #if USE_SEMAPHORES
> >
> > #define _SDT_HAS_SEMAPHORES
next prev parent reply other threads:[~2022-06-30 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 23:54 Carl Love
2022-06-22 15:11 ` [PING] " Carl Love
2022-06-30 15:14 ` Carl Love [this message]
2022-07-11 15:11 ` [PING 3] " Carl Love
2022-07-11 15:14 ` [PING 2] " Carl Love
2022-07-12 10:35 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39ca01e864cfeb37c2b84252bd84529142d4703a.camel@us.ibm.com \
--to=cel@us.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).