[PING] [PATCH] Fix for gdb.base/stap-probe.c

[Carl Love <cel@us.ibm.com>]

Ping?

On Tue, 2022-06-14 at 16:54 -0700, Carl Love wrote:
> GDB maintainers:
> 
> The gdb.base/stap-probe.exp test fails on Power 10 with a compile
> error
> due to a missing include file.  The include file provides the
> definition for ATTRIBUTE_NOCLONE.  The following patch add the
> missing
> include file.  
> 
> The test now runs on Power 10 with 98 expected passes and 4
> unsupported
> tests.
> 
> Please let me know if this patch is acceptable for mainline.
> 
>                         Carl Love
> 
> ---------------------------------------------------------------------
> Fix for gdb.base/stap-probe.c
> 
> On PowePC, the test fails on a compile error:
> 
>   /../binutils-gdb-current/gdb/testsuite/gdb.base/stap-probe.c:107:1: 
> error: expected '=', ',', ';', 
>   'asm' or 'attribute' before 'use_xmm_reg'
>   107 | use_xmm_reg (int val)
>   | ^~~~~~~~~~~
> 
> Where the source code for stap-probe.c is:
> 
>   ...
>   static const char * __attribute__((noinline)) ATTRIBUTE_NOCLONE
>   use_xmm_reg (int val)                         <-- line 107
>   {
>   ...
> 
> The issue is the ATTRIBUTE_NOCLONE is not defined as an attribute as
> expected.  The #define for ATTRIBUTE_NOCLONE can be found in
> ../lib/attributes.h.
> 
> This patch adds the missing include statement for the definition of
> ATTRIBUTE_NOCLONE.
> 
> The patch has been tested and verified on a Power10 system.
> ---
>  gdb/testsuite/gdb.base/stap-probe.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.base/stap-probe.c
> b/gdb/testsuite/gdb.base/stap-probe.c
> index d1482c35caf..527f7e187eb 100644
> --- a/gdb/testsuite/gdb.base/stap-probe.c
> +++ b/gdb/testsuite/gdb.base/stap-probe.c
> @@ -15,6 +15,8 @@
>     You should have received a copy of the GNU General Public License
>     along with this program.  If not, see <
> http://www.gnu.org/licenses/>.  */
> 
> +#include "../lib/attributes.h"
> +
>  #if USE_SEMAPHORES
> 
>  #define _SDT_HAS_SEMAPHORES