public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 3/5] sim/ppc: mark device_error function as ATTRIBUTE_NORETURN
Date: Wed, 12 Oct 2022 13:38:33 +0100	[thread overview]
Message-ID: <39eeb655ef7a1a8b3ea3c2f120e7d67693ec3f93.1665578246.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1665578246.git.aburgess@redhat.com>

The device_error function always ends up calling the error function,
which is itself marked as ATTRIBUTE_NORETURN, so it makes sense that
device_error should also be marked ATTRIBUTE_NORETURN.

Doing this resolves a few warnings from hw_ide.c about possibly
uninitialized variables - the variables are only uninitialized after
passing through a call to device_error, which obviously means the
variables are never really used uninitialized, the simulation will
terminate with the device_error call.
---
 sim/ppc/device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sim/ppc/device.h b/sim/ppc/device.h
index bd539095160..65c85e4ddd3 100644
--- a/sim/ppc/device.h
+++ b/sim/ppc/device.h
@@ -729,7 +729,7 @@ EXTERN_DEVICE\
 (void) device_error
 (device *me,
  const char *fmt,
- ...) ATTRIBUTE_PRINTF_2;
+ ...) ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF_2;
 
 INLINE_DEVICE\
 (int) device_trace
-- 
2.25.4


  parent reply	other threads:[~2022-10-12 12:38 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 12:38 [PATCH 0/5] Silence some build warnings in various simulators Andrew Burgess
2022-10-12 12:38 ` [PATCH 1/5] sim/cgen: mask uninitialized variable warning in cgen-run.c Andrew Burgess
2022-10-23 12:30   ` Mike Frysinger
2022-10-24 15:57     ` Andrew Burgess
2022-10-24 15:59       ` Mike Frysinger
2022-10-27 15:53         ` Andrew Burgess
2022-10-12 12:38 ` [PATCH 2/5] sim/ppc: fix warnings related to printf format strings Andrew Burgess
2022-10-12 12:46   ` Tsukasa OI
2022-10-12 13:50     ` Andrew Burgess
2022-10-23 12:20   ` Mike Frysinger
2022-10-24 15:41     ` Andrew Burgess
2022-10-12 12:38 ` Andrew Burgess [this message]
2022-10-12 12:38 ` [PATCH 4/5] sim/erc32: avoid dereferencing type-punned pointer warnings Andrew Burgess
2022-10-12 14:11   ` Pedro Alves
2022-10-12 17:02     ` Lancelot SIX
2022-10-13 10:35       ` Andrew Burgess
2022-10-13 10:49         ` Pedro Alves
2022-10-23 12:34   ` Mike Frysinger
2022-10-24 15:42     ` Andrew Burgess
2022-10-12 12:38 ` [PATCH 5/5] sim/iq2000: silence pointer-sign warnings Andrew Burgess
2022-10-23 12:32   ` Mike Frysinger
2022-10-24 15:45     ` Andrew Burgess
2022-10-26  8:51       ` Mike Frysinger
2022-10-14 17:50 ` [PATCH 0/5] Silence some build warnings in various simulators Tom Tromey
2022-10-19 13:34   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39eeb655ef7a1a8b3ea3c2f120e7d67693ec3f93.1665578246.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).