Re: [RFC 0/3] [gdb/testsuite] Introduce is_x86_64_m64_target

[Tom de Vries <tdevries@suse.de>]

On 1/25/23 22:26, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> I used a refactoring setup I wrote in python for another refactoring to
> Tom> rewrite:
> Tom> ...
> Tom> if { ![istarget x86_64-*-* ] || ![is_lp64_target] } {
> Tom>     verbose "Skipping ${testfile}."
> Tom>     return
> Tom> }
> Tom> ...
> Tom> into:
> Tom> ...
> Tom> require is_x86_64_m64_target
> Tom> ...
> 
> Tom> It also handles the elseif case.
> 
> Tom> Due to a recent commit, only the elseif cases are transformed, the others
> Tom> have been handled already.
> 
> If you want the existing requires could be converted to use the new
> proc.  Seems a little simpler.
> 

Done.

> I sent a comment to one patch but otherwise this looks good to me.
> Thanks for doing it.
> 
> FWIW I also have some refactoring scripts, but mine are
> idiosyncratically written in emacs lisp, which is convenient in some
> ways (easier to do multi-line edits, and back in the day I could have
> them make ChangeLog entries) but worse in others (slow).

I see.  I love to use emacs, but I'm not familiar with lisp, so that's 
not an option for me :)

Anyway, I don't think that the refactoring scripts I've posted here are 
ready for contribution, but ideally I'd love to have some refactoring 
tool commonly used, with the idea that it would enable not only posting 
the result of the transformation, put also the transformation itself, 
and you could get feedback on the transformation, people could try it 
out themselves, find cases they think could be handled in addition, post 
improved versions.  And something in python seems not a bad choice, 
considering the popularity of it.

FWIW, I've started out with the idea of using cocinelle for some gdb 
source transformation, but pretty soon found out that c++ support is 
missing/poor, so I abandoned that idea.

Thanks,
- Tom