From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>, Tom Tromey <tom@tromey.com>
Subject: Re: [RFC 0/3] [gdb/testsuite] Introduce is_x86_64_m64_target
Date: Wed, 25 Jan 2023 14:26:44 -0700 [thread overview]
Message-ID: <87v8kutiej.fsf@tromey.com> (raw)
In-Reply-To: <20230125200626.29340-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 25 Jan 2023 21:06:23 +0100")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> I used a refactoring setup I wrote in python for another refactoring to
Tom> rewrite:
Tom> ...
Tom> if { ![istarget x86_64-*-* ] || ![is_lp64_target] } {
Tom> verbose "Skipping ${testfile}."
Tom> return
Tom> }
Tom> ...
Tom> into:
Tom> ...
Tom> require is_x86_64_m64_target
Tom> ...
Tom> It also handles the elseif case.
Tom> Due to a recent commit, only the elseif cases are transformed, the others
Tom> have been handled already.
If you want the existing requires could be converted to use the new
proc. Seems a little simpler.
I sent a comment to one patch but otherwise this looks good to me.
Thanks for doing it.
FWIW I also have some refactoring scripts, but mine are
idiosyncratically written in emacs lisp, which is convenient in some
ways (easier to do multi-line edits, and back in the day I could have
them make ChangeLog entries) but worse in others (slow).
Tom
next prev parent reply other threads:[~2023-01-25 21:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 20:06 Tom de Vries
2023-01-25 20:06 ` [RFC 1/3] [gdb/contrib] Add refactor.py Tom de Vries
2023-01-25 20:06 ` [RFC 2/3] [gdb/contrib] Add refactor_require.py Tom de Vries
2023-01-25 20:06 ` [RFC 3/3] [gdb/testsuite] Add and use is_x86_64_m64_target Tom de Vries
2023-01-25 21:25 ` Tom Tromey
2023-01-26 9:17 ` [pushed] " Tom de Vries
2023-01-26 15:48 ` Tom de Vries
2023-01-26 16:10 ` Tom Tromey
2023-01-26 16:36 ` Tom de Vries
2023-01-26 16:38 ` Pedro Alves
2023-01-26 17:08 ` Tom de Vries
2023-01-26 18:25 ` Tom Tromey
2023-01-26 18:34 ` Pedro Alves
2023-01-25 21:26 ` Tom Tromey [this message]
2023-01-26 9:30 ` [RFC 0/3] [gdb/testsuite] Introduce is_x86_64_m64_target Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8kutiej.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).