From: Keith Seitz <keiths@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb/s390: Add packed-stack support to the backchain unwinder
Date: Fri, 26 Jan 2024 08:34:51 -0800 [thread overview]
Message-ID: <3ba8d70a-62d1-4594-9912-7f14fc197304@redhat.com> (raw)
In-Reply-To: <20231128223702.869501-1-iii@linux.ibm.com>
Hi,
Thank you for your patience. It comes sometimes be a very lengthy
process to get patches accepted.
Since I've already "granted" (???) my Reviewed-by, this is effectively
just a "ping" for you.
On 11/28/23 14:36, Ilya Leoshkevich wrote:
> Regtested on s390x-redhat-linux. Ok for master?
>
>
>
> v1: https://sourceware.org/pipermail/gdb-patches/2023-October/203562.html
> https://sourceware.org/pipermail/gdb-patches/2023-November/204230.html
>
> Move variable declarations closer to their first usages, add a test
> (Keith).
>
> Ignore the return value of the 2nd try_backchain() call, it does
> not cause any warnings, since try_backchain() is not marked with
> __attribute__ ((__warn_unused_result__)). Furthermore, the logic
> does not require any special actions if it fails.
I've retested this internally and reviewed the revision, and everything
looks okay.
I hope a global or area maintainer will be able to help push this
forward. forward.
Keith
prev parent reply other threads:[~2024-01-26 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 22:36 Ilya Leoshkevich
2024-01-26 16:34 ` Keith Seitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba8d70a-62d1-4594-9912-7f14fc197304@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=iii@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).