Re: [PATCH][gdb/symtab] Factor out have_complaint

[Bruno Larsen <blarsen@redhat.com>]

On 04/10/2022 18:43, Tom de Vries via Gdb-patches wrote:
> On 10/4/22 17:51, Tom de Vries wrote:
>> On 10/4/22 17:10, Tom de Vries via Gdb-patches wrote:
>>> Hi,
>>>
>>> After committing 8ba677d3560 ("[gdb/symtab] Don't complain about 
>>> function
>>> decls") I noticed that quite a bit of code in read_func_scope is 
>>> used to decide
>>> whether to issue the "cannot get low and high bounds for subprogram 
>>> DIE at
>>> $hex" complaint, which executes unnecessarily if we have the default
>>> "set complaints 0".
>>>
>>> Fix this by (NFC):
>>> - factoring out new static function have_complaint from macro 
>>> complaint, and
>>> - using it to wrap the relevant code in read_func_scope.
>>>
>>> Tested on x86_64-linux.
>>>
>>> Any comments?
>>>
>>
>> Well, I didn't check properly, this doesn't even build, I'll repost 
>> once I got a properly build & tested version.
>
> And here it is.
I tested this locally and it introduces no regressions. And the changes 
themselves look contained enough, so I recommend you approve your patch!

Cheers,
Bruno

>
> Thanks,
> - Tom