From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/symtab] Factor out have_complaint
Date: Tue, 4 Oct 2022 17:51:44 +0200 [thread overview]
Message-ID: <6eee2cfa-f428-12fe-4808-039373ef7bd0@suse.de> (raw)
In-Reply-To: <20221004151058.GA20304@delia.home>
On 10/4/22 17:10, Tom de Vries via Gdb-patches wrote:
> Hi,
>
> After committing 8ba677d3560 ("[gdb/symtab] Don't complain about function
> decls") I noticed that quite a bit of code in read_func_scope is used to decide
> whether to issue the "cannot get low and high bounds for subprogram DIE at
> $hex" complaint, which executes unnecessarily if we have the default
> "set complaints 0".
>
> Fix this by (NFC):
> - factoring out new static function have_complaint from macro complaint, and
> - using it to wrap the relevant code in read_func_scope.
>
> Tested on x86_64-linux.
>
> Any comments?
>
Well, I didn't check properly, this doesn't even build, I'll repost once
I got a properly build & tested version.
Sorry for the noise.
Thanks,
- Tom
next prev parent reply other threads:[~2022-10-04 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 15:10 Tom de Vries
2022-10-04 15:51 ` Tom de Vries [this message]
2022-10-04 16:43 ` Tom de Vries
2022-10-05 9:43 ` Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eee2cfa-f428-12fe-4808-039373ef7bd0@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).