Re: [PATCH v8 00/10] Extensions for PTWRITE

[Simon Marchi <simark@simark.ca>]

On 3/21/23 11:46, Felix Willgerodt via Gdb-patches wrote:
> Eli already approved the documentation parts.
> Markus reviewed every patch and approved the btrace bits.
> The only thing that is missing is a maintainers approval for the Python
> bits.
> 
> v7 can be found here:
> https://sourceware.org/pipermail/gdb-patches/2022-October/192830.html
> 
> I pinged this version 12 times, but didn't get any response.
> Since the last time I posted this was half a year ago, I decided to re-post a
> rebased version again.  I only had to solve some minor conflicts.  The
> biggest change was using the new require logic for the testing.

Hi Felix,

Sorry for that.  With the amount of stuff on the list, it's easy to
overlook things and think "ehhh, I'm not comfortable reviewing this,
I'll let someone else do it".  I will check the Python bits.

git shows these little things to fix when applying the series:

    ➜  binutils-gdb git:(master) ✗ git am ./v8_20230321_felix_willgerodt_extensions_for_ptwrite.mbx
    Applying: btrace: Introduce auxiliary instructions.
    Applying: btrace: Enable auxiliary instructions in record instruction-history.
    Applying: btrace: Enable auxiliary instructions in record function-call-history.
    Applying: btrace: Handle stepping and goto for auxiliary instructions.
    .git/rebase-apply/patch:29: indent with spaces.
            {
    .git/rebase-apply/patch:30: indent with spaces.
              *replay = start;
    .git/rebase-apply/patch:31: indent with spaces.
              return btrace_step_no_history ();
    .git/rebase-apply/patch:32: indent with spaces.
            }
    warning: 4 lines add whitespace errors.
    Applying: python: Introduce gdb.RecordAuxiliary class.
    Applying: python: Add clear() to gdb.Record.
    .git/rebase-apply/patch:106: trailing whitespace.
        gdb_test "python print(i.is_speculative)" "False"
    warning: 1 line adds whitespace errors.
    Applying: btrace, gdbserver: Add ptwrite to btrace_config_pt.
    Applying: btrace, linux: Enable ptwrite packets.
    Applying: btrace, python: Enable ptwrite filter registration.
    Applying: btrace: Extend ptwrite event decoding.
    .git/rebase-apply/patch:285: trailing whitespace.
    (gdb) info threads
    .git/rebase-apply/patch:1187: trailing whitespace.
    # SUCC: EXIT [always]
    .git/rebase-apply/patch:1227: trailing whitespace.
    # SUCC: EXIT [always]
    .git/rebase-apply/patch:1261: trailing whitespace.
    # SUCC: EXIT [always]
    warning: 4 lines add whitespace errors.

Simon