From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Felix Willgerodt <felix.willgerodt@intel.com>
Subject: Re: [PATCH v8 00/10] Extensions for PTWRITE
Date: Fri, 24 Mar 2023 14:28:49 -0400 [thread overview]
Message-ID: <c0639b3b-df71-e2a1-fb83-8da756854b0e@simark.ca> (raw)
In-Reply-To: <87bkkidn4x.fsf@tromey.com>
On 3/24/23 14:23, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> Sorry for that. With the amount of stuff on the list, it's easy to
> Simon> overlook things and think "ehhh, I'm not comfortable reviewing this,
> Simon> I'll let someone else do it".
>
> This is exactly what I did as well. I see it as a kind of collective
> action problem.
>
> It's clear we need a new system here, but I don't know what it is. I
> was hoping patchworks, but that turned out to require too much manual
> intervention, IMO.
>
> Maybe we should simply go back to gerrit, despite its issues. Perhaps
> we could do it in conjunction with a robot that auto-assigns reviews.
I don't think just Gerrit would have helped, I would have ignored it on
Gerrit as well. Perhaps some robot, as you said, would have helped, but
I'm not sure it's good to just randomly assign reviews. We all have our
areas of knowledge, and I think it's good to respect that.
Perhaps some interactive patch triage / review session like glibc has
would help, but I'm not sure people (including me) want to commit to a
regular meeting for that.
Simon
next prev parent reply other threads:[~2023-03-24 18:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 15:46 Felix Willgerodt
2023-03-21 15:46 ` [PATCH v8 01/10] btrace: Introduce auxiliary instructions Felix Willgerodt
2023-03-21 15:46 ` [PATCH v8 02/10] btrace: Enable auxiliary instructions in record instruction-history Felix Willgerodt
2023-03-21 15:46 ` [PATCH v8 03/10] btrace: Enable auxiliary instructions in record function-call-history Felix Willgerodt
2023-03-21 15:46 ` [PATCH v8 04/10] btrace: Handle stepping and goto for auxiliary instructions Felix Willgerodt
2023-03-24 14:09 ` Simon Marchi
2023-03-31 10:58 ` Willgerodt, Felix
2023-03-21 15:46 ` [PATCH v8 05/10] python: Introduce gdb.RecordAuxiliary class Felix Willgerodt
2023-03-24 14:27 ` Simon Marchi
2023-03-31 10:58 ` Willgerodt, Felix
2023-04-03 19:06 ` Simon Marchi
2023-04-04 6:57 ` Metzger, Markus T
2023-04-04 14:17 ` Simon Marchi
2023-04-04 14:26 ` Willgerodt, Felix
2023-03-21 15:46 ` [PATCH v8 06/10] python: Add clear() to gdb.Record Felix Willgerodt
2023-03-24 14:36 ` Simon Marchi
2023-03-31 10:58 ` Willgerodt, Felix
2023-03-21 15:46 ` [PATCH v8 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt Felix Willgerodt
2023-03-21 15:46 ` [PATCH v8 08/10] btrace, linux: Enable ptwrite packets Felix Willgerodt
2023-03-21 15:46 ` [PATCH v8 09/10] btrace, python: Enable ptwrite filter registration Felix Willgerodt
2023-03-24 15:23 ` Simon Marchi
2023-03-31 10:58 ` Willgerodt, Felix
2023-04-03 20:44 ` Simon Marchi
2023-04-04 14:42 ` Willgerodt, Felix
2023-04-04 15:06 ` Simon Marchi
2023-04-05 10:20 ` Willgerodt, Felix
2023-04-05 20:27 ` Simon Marchi
2023-04-06 9:44 ` Willgerodt, Felix
2023-03-21 15:46 ` [PATCH v8 10/10] btrace: Extend ptwrite event decoding Felix Willgerodt
2023-03-24 15:40 ` Simon Marchi
2023-03-31 10:58 ` Willgerodt, Felix
2023-04-04 14:23 ` Simon Marchi
2023-03-24 13:56 ` [PATCH v8 00/10] Extensions for PTWRITE Simon Marchi
2023-03-24 18:23 ` Tom Tromey
2023-03-24 18:28 ` Simon Marchi [this message]
2023-03-24 22:29 ` Tom Tromey
2023-03-31 10:57 ` Willgerodt, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0639b3b-df71-e2a1-fb83-8da756854b0e@simark.ca \
--to=simark@simark.ca \
--cc=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).