From: Keith Seitz <keiths@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove a copy from c-exp.y:parse_number
Date: Wed, 17 Apr 2024 07:21:57 -0700 [thread overview]
Message-ID: <3f50a413-6be8-410a-a518-11764595921b@redhat.com> (raw)
In-Reply-To: <20240417070145.1013104-1-tom@tromey.com>
On 4/17/24 00:01, Tom Tromey wrote:
> parse_number copies its input string, but there is no need to do this.
> This patch removes the copy.
>
> Regression tested on x86-64 Fedora 38.
Out of curiosity, I did a little digging into this, well,
curiosity...
I committed that over a decade ago, and my notes mention some
of the difficulties with generic parser constification I was
having at the time, including having to fudge several places
with alloca.
So if there was a reason for it back then, it was a hack, and
it is now obviously long gone.
Reviewed-by: Keith Seitz <keiths@redhat.com>
Thank you,
Keith
next prev parent reply other threads:[~2024-04-17 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 7:01 Tom Tromey
2024-04-17 14:21 ` Keith Seitz [this message]
2024-04-17 22:10 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f50a413-6be8-410a-a518-11764595921b@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).