From: Tom Tromey <tom@tromey.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove a copy from c-exp.y:parse_number
Date: Wed, 17 Apr 2024 16:10:25 -0600 [thread overview]
Message-ID: <87plunfxny.fsf@tromey.com> (raw)
In-Reply-To: <3f50a413-6be8-410a-a518-11764595921b@redhat.com> (Keith Seitz's message of "Wed, 17 Apr 2024 07:21:57 -0700")
Keith> I committed that over a decade ago, and my notes mention some
Keith> of the difficulties with generic parser constification I was
Keith> having at the time, including having to fudge several places
Keith> with alloca.
Keith> So if there was a reason for it back then, it was a hack, and
Keith> it is now obviously long gone.
I vaguely recall that this area went through constification in stages
and so we had to introduce copies in some spots.
Keith> Reviewed-by: Keith Seitz <keiths@redhat.com>
I'm going to check it in now.
Tom
prev parent reply other threads:[~2024-04-17 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 7:01 Tom Tromey
2024-04-17 14:21 ` Keith Seitz
2024-04-17 22:10 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plunfxny.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).