From: Guinevere Larsen <blarsen@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/dwarf2: Add support for DW_LNS_set_epilogue_begin in line-table
Date: Fri, 22 Dec 2023 17:56:19 +0100 [thread overview]
Message-ID: <414c1389-9b4c-b62d-6a2c-9906878c5569@redhat.com> (raw)
In-Reply-To: <87sf3u19ih.fsf@tromey.com>
On 22/12/2023 17:34, Tom Tromey wrote:
>>>>>> "Guinevere" == Guinevere Larsen <blarsen@redhat.com> writes:
> Guinevere> This commit adds a mechanism for GDB to detect the linetable opcode
> Guinevere> DW_LNS_set_epilogue_begin. This opcode is set by compilers to indicate
> Guinevere> that a certain instruction marks the point where the frame is destroyed.
>
> Thanks for doing this. It looks good to me.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
>
Thanks for approving!
I will follow Carl Love's rule of not pushing something right before
leaving for vacation, and only do it once I'm back from the holidays,
though :)
--
Cheers,
Guinevere Larsen
She/Her/Hers
next prev parent reply other threads:[~2023-12-22 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 10:29 Guinevere Larsen
2023-12-22 16:34 ` Tom Tromey
2023-12-22 16:56 ` Guinevere Larsen [this message]
2024-01-02 9:24 ` Guinevere Larsen
2024-01-10 16:57 ` Simon Marchi
2024-01-10 17:01 ` Guinevere Larsen
2024-01-10 17:59 ` Tom Tromey
2024-01-11 17:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414c1389-9b4c-b62d-6a2c-9906878c5569@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).