From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Use bool in pc_in_* functions
Date: Fri, 20 Jan 2023 12:09:29 -0500 [thread overview]
Message-ID: <42144c46-2268-a613-0356-9860f4982441@simark.ca> (raw)
In-Reply-To: <20230119173836.653968-1-tom@tromey.com>
On 1/19/23 12:38, Tom Tromey wrote:
> I noticed that pc_in_unmapped_range had a weird return type -- it was
> returning a CORE_ADDR but intending to return a bool. This patch
> changes all the pc_in_* functions to return bool instead.
LGTM.
Simon
prev parent reply other threads:[~2023-01-20 17:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 17:38 Tom Tromey
2023-01-20 17:09 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42144c46-2268-a613-0356-9860f4982441@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).