From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb: remove trailing empty line in target-delegates.c
Date: Thu, 27 Jul 2023 13:33:16 -0400 [thread overview]
Message-ID: <469edb6e-42a6-10a9-58ac-e77f2ac93fba@polymtl.ca> (raw)
In-Reply-To: <87pm4dib96.fsf@tromey.com>
On 2023-07-27 12:12, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> In a review [1], I pointed out that applying the patch, git would say:
> Simon> .git/rebase-apply/patch:147: new blank line at EOF.
>
> Simon> However, since the empty line is in target-delegates.c (a generated
> Simon> file), there's nothing the author can do about it. To avoid this
> Simon> comment coming up again in the future, change make-target-delegates.py
> Simon> to avoid the trailing empty line. Do this by making it output empty
> Simon> lines before each entity, not after.
>
> Simon> Since this needs removing a newline output in gdbcopyright, adjust
> Simon> ada-unicode.py and gdbarch.py to avoid changes in the files they
> Simon> generate.
>
> Seems totally fine to me, thank you.
>
> Approved-By: Tom Tromey <tom@tromey.com>
>
>
> Tom
Thanks, pushed.
Simon
prev parent reply other threads:[~2023-07-27 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 19:11 Simon Marchi
2023-07-27 16:12 ` Tom Tromey
2023-07-27 17:33 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469edb6e-42a6-10a9-58ac-e77f2ac93fba@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).