public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] Autogenerate gdb/syscalls/linux-defaults.xml.in (syscall groups) from strace sources
Date: Mon, 27 Feb 2023 14:53:52 +0000	[thread overview]
Message-ID: <491b0be5-578d-96f8-5cc7-b5606d179d78@palves.net> (raw)
In-Reply-To: <ed367bac-a7ea-b5ca-e1cc-39b249123726@suse.de>

On 2023-02-25 9:31 a.m., Tom de Vries wrote:
> On 2/25/23 00:26, Pedro Alves wrote:
>> While working on the step-over-thread-clone/exit series, I noticed
>> that one of the new tests was failing.  The test does "catch syscall
>> clone", and expects that pthread_create calls clone.  Turns out that
>> on the glibc shipped with Ubuntu 22.04, pthread_create calls clone3,
>> not clone.  To make the test cope with that, I thought of switching it
>> to "catch syscall group:process".  Surprisingly, that catches "clone",
>> but not "clone3".
>>
>> This series fixes that, by adding a script that extracts the syscall
>> group info out the strace sources.
>>
> 
> If I understand correctly, this is orthogonal to update-linux-from-src.sh ?

Right.  This generates the linux-defaults.xml.in file, which is not generated
by update-linux-from-src.sh.  The groups info is not found in the kernel.
linux-defaults.xml.in maps between syscall names and groups.  The arch xml.in files
map syscall number to name.  The makefile combines each arch xml.in with
linux-defaults.xml.in generating a final .xml file with maps the number to
name, and to groups.

> [ FWIW, i've just ran update-linux-from-src.sh with linux kernel sources v6.2, and there where no changes. ]

Great, I was wondering whether we needed to re-run that with a recent kernel.  Thanks for
taking care of it.

Pedro Alves

      reply	other threads:[~2023-02-27 14:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24 23:26 Pedro Alves
2023-02-24 23:26 ` [PATCH 1/2] Autogenerate gdb/syscalls/linux-defaults.xml.in (groups) " Pedro Alves
2023-02-25  3:00   ` Simon Marchi
2023-02-27 15:04     ` Pedro Alves
2023-02-24 23:26 ` [PATCH 2/2] Regenerate Linux syscall group info Pedro Alves
2023-02-25  9:31 ` [PATCH 0/2] Autogenerate gdb/syscalls/linux-defaults.xml.in (syscall groups) from strace sources Tom de Vries
2023-02-27 14:53   ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491b0be5-578d-96f8-5cc7-b5606d179d78@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).