From: Simon Marchi <simark@simark.ca>
To: Kevin Buettner <kevinb@redhat.com>,
Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/2] gdb: remove some GCC version checks
Date: Wed, 21 Feb 2024 12:36:25 -0500 [thread overview]
Message-ID: <499636ca-75b0-4a4b-a685-4c84f4523665@simark.ca> (raw)
In-Reply-To: <20240221100928.62ad46c4@f39-zbm-amd>
On 2/21/24 12:09, Kevin Buettner wrote:
> On Wed, 21 Feb 2024 11:46:51 -0500
> Simon Marchi <simon.marchi@efficios.com> wrote:
>
>> New in v2:
>>
>> - remove changes to nat/x86-gcc-cpuid.h
>> - adjust indentation in tracepoint.h
>>
>> Since we now require C++17, and therefore gcc >= 9, it's no longer
>> useful to have gcc version checks for older gcc version.
>
> Both patches LGTM.
>
> Reviewed-by: Kevin Buettner <kevinb@redhat.com>
>
Thanks. I'll wait for a confirmation from Pedro as well, since he gave
comment on v1.
Simon
next prev parent reply other threads:[~2024-02-21 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 16:46 Simon Marchi
2024-02-21 16:46 ` [PATCH v2 2/2] gdbsupport: assume that compiler supports std::{is_trivially_constructible,is_trivially_copyable} Simon Marchi
2024-02-21 17:09 ` [PATCH v2 1/2] gdb: remove some GCC version checks Kevin Buettner
2024-02-21 17:36 ` Simon Marchi [this message]
2024-02-21 17:46 ` Pedro Alves
2024-02-21 18:31 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499636ca-75b0-4a4b-a685-4c84f4523665@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).