From: Simon Marchi <simark@simark.ca>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 08/26] gdbserver: convert free_register_cache into a destructor of regcache
Date: Thu, 21 Dec 2023 15:57:40 -0500 [thread overview]
Message-ID: <49a4d1af-1a22-4ea9-9bd6-e6d169b4c00d@simark.ca> (raw)
In-Reply-To: <dfbc693a0b7edb8b1d51f4611a217332fa57a431.1677582744.git.tankut.baris.aktemur@intel.com>
On 2/28/23 06:28, Tankut Baris Aktemur via Gdb-patches wrote:
> Convert the `free_register_cache` function into a destructor of the
> regcache struct. In one place, we completely remove the call to free
> the regcache object by stack-allocating the object.
>
> We also delete the copy constructor explicitly to prevent the risk of
> copying regcaches and then double-freeing buffers when they are
> destructed.
> ---
> gdbserver/gdbthread.h | 2 +-
> gdbserver/regcache.cc | 15 +++++----------
> gdbserver/regcache.h | 9 +++++----
> gdbserver/server.cc | 8 +++-----
> 4 files changed, 14 insertions(+), 20 deletions(-)
>
> diff --git a/gdbserver/gdbthread.h b/gdbserver/gdbthread.h
> index 493e1dbf6cb..cfd81870af9 100644
> --- a/gdbserver/gdbthread.h
> +++ b/gdbserver/gdbthread.h
> @@ -35,7 +35,7 @@ struct thread_info
>
> ~thread_info ()
> {
> - free_register_cache (this->regcache_data);
> + delete this->regcache_data;
Perhaps in another patch, but you could make regcache_data a unique_ptr
(I quickly skimmed the subjects of the rest of the series and didn't see
a patch that would do that).
> }
>
> /* The id of this thread. */
> diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc
> index be01df342bb..7b6337166ad 100644
> --- a/gdbserver/regcache.cc
> +++ b/gdbserver/regcache.cc
> @@ -165,16 +165,11 @@ regcache::regcache (const target_desc *tdesc)
> initialize (tdesc, nullptr);
> }
>
> -void
> -free_register_cache (struct regcache *regcache)
> +regcache::~regcache ()
> {
> - if (regcache)
> - {
> - if (regcache->registers_owned)
> - free (regcache->registers);
> - free (regcache->register_status);
> - delete regcache;
> - }
> + if (registers_owned)
> + free (registers);
> + free (register_status);
> }
>
> #endif
> @@ -280,7 +275,7 @@ free_register_cache_thread (struct thread_info *thread)
> if (regcache != NULL)
> {
> regcache_invalidate_thread (thread);
> - free_register_cache (regcache);
> + delete regcache;
> set_thread_regcache_data (thread, NULL);
> }
> }
> diff --git a/gdbserver/regcache.h b/gdbserver/regcache.h
> index 32b3a8dccfc..614d5a2561f 100644
> --- a/gdbserver/regcache.h
> +++ b/gdbserver/regcache.h
> @@ -51,6 +51,11 @@ struct regcache : public reg_buffer_common
> /* Constructors. */
> regcache () = default;
> regcache (const target_desc *tdesc);
> + regcache (const regcache &rhs) = delete;
> + regcache &operator= (const regcache &rhs) = delete;
Use DISALLOW_COPY_AND_ASSIGN. And I think it wouldn't hurt to put it
outside of the `#ifndef IN_PROCESS_AGENT`. If you follow my previous
suggestions, the constructor with 2 arguments would also need to be
outside the ifndef.
> +
> + /* Deconstructor. */
> + virtual ~regcache ();
Deconstructor -> Destructor :)
But really, I don't think it's necessary, anybody slightly familiar with
C++ will know this is the destructor... as you wish.
I guess you might need in the rest of the series, but as of now the
destructor doesn't need to be virtual, so I wouldn't make it virtual
in this patch.
Simon
next prev parent reply other threads:[~2023-12-21 20:57 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 11:27 [PATCH 00/26] gdbserver: refactor regcache and allow gradually populating Tankut Baris Aktemur
2023-02-28 11:27 ` [PATCH 01/26] gdbserver: convert init_register_cache into regcache::initialize Tankut Baris Aktemur
2023-12-21 20:12 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 02/26] gdbserver: convert new_register_cache into a regcache constructor Tankut Baris Aktemur
2023-12-21 20:19 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 03/26] gdbserver: by-pass regcache to access tdesc only Tankut Baris Aktemur
2023-12-21 20:22 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 04/26] gdbserver: boolify and defaultize the 'fetch' parameter of get_thread_regcache Tankut Baris Aktemur
2023-12-21 20:24 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 05/26] gdbserver: add a pointer to the owner thread in regcache Tankut Baris Aktemur
2023-12-21 20:28 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 06/26] gdbserver: turn part of get_thread_regcache into regcache::fetch Tankut Baris Aktemur
2023-12-21 20:48 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 07/26] gdbserver: convert regcache_cpy into regcache::copy_from Tankut Baris Aktemur
2023-12-21 20:50 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 08/26] gdbserver: convert free_register_cache into a destructor of regcache Tankut Baris Aktemur
2023-12-21 20:57 ` Simon Marchi [this message]
2023-02-28 11:28 ` [PATCH 09/26] gdbserver: extract out regcache::invalidate and regcache::discard Tankut Baris Aktemur
2023-12-21 21:08 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 10/26] gdbserver: convert registers_to_string into regcache::registers_to_string Tankut Baris Aktemur
2023-12-21 21:13 ` Simon Marchi
2023-12-21 21:19 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 11/26] gdbserver: convert registers_from_string into regcache::registers_from_string Tankut Baris Aktemur
2023-02-28 11:28 ` [PATCH 12/26] gdbserver: convert supply_regblock to regcache::supply_regblock Tankut Baris Aktemur
2023-12-21 21:23 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 13/26] gdbserver: convert register_data into regcache::register_data Tankut Baris Aktemur
2023-12-21 21:26 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 14/26] gdbserver: introduce and use regcache::set_register_status Tankut Baris Aktemur
2023-12-21 21:30 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 15/26] gdbserver: check for nullptr condition in regcache::get_register_status Tankut Baris Aktemur
2023-12-21 21:32 ` Simon Marchi
2023-12-21 21:34 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 16/26] gdbserver: boolify regcache fields Tankut Baris Aktemur
2023-12-22 3:20 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 17/26] gdbserver: rename regcache's registers_valid to registers_fetched Tankut Baris Aktemur
2023-12-22 3:23 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 18/26] gdbsupport: fix a typo in a comment in common-regcache.h Tankut Baris Aktemur
2023-12-22 3:24 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 19/26] gdbserver: fix the declared type of register_status in regcache Tankut Baris Aktemur
2023-12-22 3:35 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 20/26] gdbserver: make some regcache fields private Tankut Baris Aktemur
2023-12-22 3:39 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 21/26] gdbserver: use REG_UNKNOWN for a regcache's register statuses Tankut Baris Aktemur
2023-12-22 4:32 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 22/26] gdbserver: zero-out register values in regcache-discard Tankut Baris Aktemur
2023-12-22 4:36 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 23/26] gdbserver: set register statuses in registers_from_string Tankut Baris Aktemur
2023-12-22 4:40 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 24/26] gdbserver: return tracked register status in regcache_raw_read_unsigned Tankut Baris Aktemur
2023-12-22 4:42 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 25/26] gdbserver: refuse null argument in regcache::supply_regblock Tankut Baris Aktemur
2023-12-22 4:54 ` Simon Marchi
2023-02-28 11:28 ` [PATCH 26/26] gdbserver: allow gradually populating and selectively storing a regcache Tankut Baris Aktemur
2023-12-22 16:25 ` Simon Marchi
2023-03-07 20:39 ` [PATCH 00/26] gdbserver: refactor regcache and allow gradually populating Tom Tromey
2023-03-13 14:33 ` Aktemur, Tankut Baris
2023-03-28 13:42 ` Aktemur, Tankut Baris
2023-06-20 12:58 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a4d1af-1a22-4ea9-9bd6-e6d169b4c00d@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).