From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tromey@adacore.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [gdb/ada] Move identical enums handling later
Date: Fri, 8 Sep 2023 07:56:27 +0200 [thread overview]
Message-ID: <4e8b46d1-434d-acdf-1db8-55905309f097@suse.de> (raw)
In-Reply-To: <87ledim6b8.fsf@tromey.com>
On 9/7/23 16:00, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tom> The problem is here in remove_extra_symbols:
> Tom> ...
> Tom> if (symbols_are_identical_enums (syms))
> Tom> syms.resize (1);
> Tom> ...
> Tom> where one of the two identical enums is picked before the enum_rep handling
> Tom> can resolve lit3 to one of the two.
>
> Tom> Fix this by moving the code to ada_resolve_variable.
>
> Thank you. It's hard to reason about this patch (like, maybe there
> could be some code path that now misses the de-duplication),
True.
> but given
> that you tested it, I think it's ok.
>
Thanks for the review, committed.
- Tom
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
prev parent reply other threads:[~2023-09-08 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 18:01 Tom de Vries
2023-09-07 14:00 ` Tom Tromey
2023-09-08 5:56 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e8b46d1-434d-acdf-1db8-55905309f097@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).