[PATCH 04/10] sim/ppc: don't pass uninitialized value to semctl for GETVAL calls

[Andrew Burgess <aburgess@redhat.com>]

When calling semctl with an GETVAL action, the 'union semun' argument
is unused.

Rather than passing an uninitialized variable (as we currently do),
just pass the integer 0.  This silences some compiler warnings, and is
just as correct (given the argument is ignored).

To be honest, it might be the case that the argument is not needed at
all, however, I'm a little nervous to make this change as the amount
of testing I can do of this code is limited.  Every example I found
online for a semctl/GETVAL call did pass the final argument, so that's
what I've continued to do.
---
 sim/ppc/hw_sem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sim/ppc/hw_sem.c b/sim/ppc/hw_sem.c
index 937e2ad6f81..78e3dda9ae6 100644
--- a/sim/ppc/hw_sem.c
+++ b/sim/ppc/hw_sem.c
@@ -148,7 +148,7 @@ hw_sem_init_data(device *me)
       error("hw_sem_init_data() semget failed\n");
   }
 
-  sem->count = semctl( sem->id, 0, GETVAL, help );
+  sem->count = semctl( sem->id, 0, GETVAL, 0 );
   if (sem->count == -1)
     error("hw_sem_init_data() semctl -- get value failed\n");
   DTRACE(sem, ("semaphore OS value (%d)\n", sem->count) );
@@ -241,7 +241,7 @@ hw_sem_io_read_buffer(device *me,
   }
 
   /* assume target is big endian */
-  u32 = H2T_4(semctl( sem->id, 0, GETVAL, help ));
+  u32 = H2T_4(semctl( sem->id, 0, GETVAL, 0 ));
 
   DTRACE(sem, ("semaphore OS value (%d)\n", u32) );
   if (u32 == 0xffffffff) {
-- 
2.25.4