From: Mike Frysinger <vapier@gentoo.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 10/10] sim/cris/m32c/sh: disable use of -Werror
Date: Sun, 23 Oct 2022 20:02:11 +0545 [thread overview]
Message-ID: <Y1VM5x11OuELGmeZ@vapier> (raw)
In-Reply-To: <42c09bcd56bb7bf0a84d58ffad71894f284b5401.1666192979.git.aburgess@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
On 19 Oct 2022 16:24, Andrew Burgess via Gdb-patches wrote:
> When building the cris, m32c, and sh simulators with Clang I am seeing
> build warnings from a few objects. These three simulators currently
> build with -Werror, and so these warnings cause the build to fail.
>
> When built with gcc I don't see any warnings from these targets, so
> the -Werror is fine.
>
> As the warnings are not new, in this commit, I propose that we disable
> the use of -Werror for these three simulators. With this done it is
> now possible to build the complete simulator tree using clang.
sory, but i don't understand the logic here. the code builds cleanly with gcc
which is why we have -Werror enabled. but when building with clang, you see
errors, so you want to disable -Werror for gcc and allow new issues to slip in
to the tree ?
this change/approach looks wrong to me. if the tree is clean with gcc, leave
it to people interested in clang to figure it out w/out making the situation
worse for GNU users. this is the GNU sim, not the LLVM sim.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-23 15:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 15:24 [PATCH 00/10] Building the sim/ tree with clang Andrew Burgess
2022-10-19 15:24 ` [PATCH 01/10] sim/sh: use fabs instead of abs Andrew Burgess
2022-10-23 13:53 ` Mike Frysinger
2022-10-24 16:05 ` Andrew Burgess
2022-10-19 15:24 ` [PATCH 02/10] sim/ppc: don't try to print an uninitialized variable Andrew Burgess
2022-10-23 13:51 ` Mike Frysinger
2022-10-24 16:05 ` Andrew Burgess
2022-10-19 15:24 ` [PATCH 03/10] sim/ppc: initialize a memory buffer in all cases Andrew Burgess
2022-10-23 13:50 ` Mike Frysinger
2022-10-24 16:25 ` Andrew Burgess
2022-10-19 15:24 ` [PATCH 04/10] sim/ppc: don't pass uninitialized value to semctl for GETVAL calls Andrew Burgess
2022-10-23 14:01 ` Mike Frysinger
2022-10-19 15:24 ` [PATCH 05/10] sim/ppc: fix for operator precedence warning from clang Andrew Burgess
2022-10-23 13:55 ` Mike Frysinger
2022-10-24 16:26 ` Andrew Burgess
2022-10-19 15:24 ` [PATCH 06/10] sim/aarch64: remove two unused functions Andrew Burgess
2022-10-23 13:55 ` Mike Frysinger
2022-10-24 16:26 ` Andrew Burgess
2022-10-19 15:24 ` [PATCH 07/10] sim/rx: delete an unused function Andrew Burgess
2022-10-23 13:54 ` Mike Frysinger
2022-10-19 15:24 ` [PATCH 08/10] sim/h8300: avoid self assignment Andrew Burgess
2022-10-23 13:52 ` Mike Frysinger
2022-10-24 16:26 ` Andrew Burgess
2022-10-19 15:24 ` [PATCH 09/10] sim/lm32: fix some missing function declaration warnings Andrew Burgess
2022-10-23 14:13 ` Mike Frysinger
2022-10-24 16:27 ` Andrew Burgess
2022-10-19 15:24 ` [PATCH 10/10] sim/cris/m32c/sh: disable use of -Werror Andrew Burgess
2022-10-20 3:53 ` Tsukasa OI
2022-10-21 15:58 ` Andrew Burgess
2022-10-24 8:58 ` Tsukasa OI
2022-10-24 16:23 ` Andrew Burgess
2022-10-20 18:36 ` Tom Tromey
2022-10-23 14:17 ` Mike Frysinger [this message]
2022-10-20 18:36 ` [PATCH 00/10] Building the sim/ tree with clang Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1VM5x11OuELGmeZ@vapier \
--to=vapier@gentoo.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).