Re: [PATCH v2 4/5] gdb: introduce ability to disable frame unwinders

[Guinevere Larsen <blarsen@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]

Thanks for the review. I'll fix everything else you mentioned.

On 4/8/24 23:47, Eli Zaretskii wrote:
>> +Disable or enable frame unwinders.  This is meant only as a testing tool, and
>> +@value{GDBN} is not guaranteed to work properly if it is unable to find
>> +valid frame unwinders.
>> +
>> +The meaning of each of the invocations are as follows:
>> +
>> +@table @samp
>> +@item @code{-all}
>> +Disable or enable all unwinders.
>> +@item @code{-name} @var{NAME}
>> +@var{NAME} is the exact name of the unwinder to be disabled or enabled.
>> +@item [@code{-class}] @var{CLASS}
>> +@var{CLASS} is the class of frame unwinders to be disabled or enabled.
>> +The class may include the prefix @code{FRAME_UNWINDER_}, but it is not
>> +required.
>> +@end table
>> +
>> +@var{NAME} and @var{CLASS} are always case insensitive.  If no option
>> +starting wth @code{-} is given, @value{GDBN} assumes @code{-class}.
> I think this command should be moved to after "maint info
> frame-unwinders", and it should say that the list of available
> unwinders is shown by that command.  Also, I suppose what you call
> "class" is what "maint info frame-unwinders" displays as "Type"?  Or
> is it something else?  If the latter, the manual should tell how to
> know which classes are available.

The unwinder class was introduced by patch 2 of this series (which I now 
realize I forgot to add NEWS and doc changes). Where would I add base 
information about frame unwinders like this?

-- 
Cheers,
Guinevere Larsen
She/Her/Hers