From: Lancelot SIX <lsix@lancelotsix.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/5] Rewrite final cleanups
Date: Sun, 3 Mar 2024 16:50:14 +0000 [thread overview]
Message-ID: <535b9754-f25d-4a15-ae59-177126287ccb@lancelotsix.com> (raw)
In-Reply-To: <87edcxvmul.fsf@tromey.com>
On 27/02/2024 17:27, Tom Tromey wrote:
> Lancelot> My train of thought was
> Lancelot> 1) This `system ("rm -rf ...")` could be replaced with
> Lancelot> std::filesystem::remove_all
> Lancelot> 2) At least one overload of remove_all can throw
> Lancelot> 3) What would happen if a cleanup throws (either an existing one, or one
> Lancelot> to change/introduce in the future).
>
> Makes sense.
>
> I filed a bug for this:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=31420
>
> ... and also a C++17 meta-bug, and various C++17 to-do items I've
> thought of in the past.
Thanks for creating the tickets to track this!
I have submitted
https://sourceware.org/pipermail/gdb-patches/2024-March/206982.html to
handle this ticket.
Best,
Lancelot.
next prev parent reply other threads:[~2024-03-03 16:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 21:11 [PATCH 0/5] Restore DAP 'quit' request Tom Tromey
2024-02-23 21:11 ` [PATCH 1/5] Rewrite final cleanups Tom Tromey
2024-02-25 22:30 ` Lancelot SIX
2024-02-26 18:53 ` Tom Tromey
2024-02-27 14:03 ` Lancelot SIX
2024-02-27 17:27 ` Tom Tromey
2024-02-27 17:36 ` Tom Tromey
2024-03-03 16:50 ` Lancelot SIX [this message]
2024-02-23 21:11 ` [PATCH 2/5] Add extension_language_ops::shutdown Tom Tromey
2024-02-23 21:11 ` [PATCH 3/5] Change finalize_values into a final cleanup Tom Tromey
2024-02-23 21:11 ` [PATCH 4/5] Add final cleanup for runnables Tom Tromey
2024-02-23 21:11 ` [PATCH 5/5] Explicitly quit gdb from DAP server thread Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535b9754-f25d-4a15-ae59-177126287ccb@lancelotsix.com \
--to=lsix@lancelotsix.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).