public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 1/5] Rewrite final cleanups
Date: Tue, 27 Feb 2024 10:27:46 -0700	[thread overview]
Message-ID: <87edcxvmul.fsf@tromey.com> (raw)
In-Reply-To: <20240227140331.cavxavrv4uoz4cdr@octopus> (Lancelot SIX's message of "Tue, 27 Feb 2024 14:03:31 +0000")

Lancelot> My train of thought was
Lancelot> 1) This `system ("rm -rf ...")` could be replaced with
Lancelot> std::filesystem::remove_all
Lancelot> 2) At least one overload of remove_all can throw
Lancelot> 3) What would happen if a cleanup throws (either an existing one, or one
Lancelot> to change/introduce in the future).

Makes sense.

I filed a bug for this:

https://sourceware.org/bugzilla/show_bug.cgi?id=31420

... and also a C++17 meta-bug, and various C++17 to-do items I've
thought of in the past.

Lancelot> FWIW, I skimmed through the rest of the series, and looks reasonable to
Lancelot> me.

Thanks.  Normally I would not rush this, but the current state of the
tree is preventing us from doing a merge here at AdaCore, as DAP exiting
is currently broken.

So, I am going to check this in.

Tom

  reply	other threads:[~2024-02-27 17:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 21:11 [PATCH 0/5] Restore DAP 'quit' request Tom Tromey
2024-02-23 21:11 ` [PATCH 1/5] Rewrite final cleanups Tom Tromey
2024-02-25 22:30   ` Lancelot SIX
2024-02-26 18:53     ` Tom Tromey
2024-02-27 14:03       ` Lancelot SIX
2024-02-27 17:27         ` Tom Tromey [this message]
2024-02-27 17:36           ` Tom Tromey
2024-03-03 16:50           ` Lancelot SIX
2024-02-23 21:11 ` [PATCH 2/5] Add extension_language_ops::shutdown Tom Tromey
2024-02-23 21:11 ` [PATCH 3/5] Change finalize_values into a final cleanup Tom Tromey
2024-02-23 21:11 ` [PATCH 4/5] Add final cleanup for runnables Tom Tromey
2024-02-23 21:11 ` [PATCH 5/5] Explicitly quit gdb from DAP server thread Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edcxvmul.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).