From: "jiangshuai_li" <jiangshuai_li@linux.alibaba.com>
To: "Jiangshuai Li via Gdb-patches" <gdb-patches@sourceware.org>,
"Tom Tromey" <tom@tromey.com>
Subject: [PATCH] gdb/csky rm csky_memory_insert/remove_breakpoint
Date: Wed, 21 Sep 2022 16:51:23 +0800 [thread overview]
Message-ID: <537bd63a-eebd-40b2-beb6-d51804cbedce.jiangshuai_li@linux.alibaba.com> (raw)
>>>>>> Jiangshuai Li via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> All the types of breakpoints and watchpoints are inserted or
>> removed by the gdb stub, these two functions are no longer needed.
>
>Does this mean this is a port that will never have a host port of gdb?
You mean native gdb support? I will port native gdb later.
The reason why I deleted these two functions is that CSKY did not use the remote protocol
provided by GDB long ago, but implemented a set of djp protocols for debugging. At this
time, these two functions are useful. And at the same time, when debugging with gdbserver,
software breakpoints are also inserted and deleted through these two interfaces.
However, the GDB Stubs used by CSKY now use the remote protocol provided by GDB, and
gdbserver also supports inserting and deleting software breakpoints, so these two functions
are no longer needed.
I haven't carefully checked whether native gdb needs these two interfaces, if necessary, add
them later.
>
>I guess it's fine in that case. I wonder if there are other ports in
>this situation.
>
Jiangshuai Li
WARNING: multiple messages have this Message-ID
From: "jiangshuai_li" <jiangshuai_li@linux.alibaba.com>
To: "Jiangshuai Li via Gdb-patches" <gdb-patches@sourceware.org>,
"Tom Tromey" <tom@tromey.com>
Subject: [PATCH] gdb/csky rm csky_memory_insert/remove_breakpoint
Date: Wed, 21 Sep 2022 16:51:23 +0800 [thread overview]
Message-ID: <537bd63a-eebd-40b2-beb6-d51804cbedce.jiangshuai_li@linux.alibaba.com> (raw)
Message-ID: <20220921085123.XMsx1YMbw_t4frGUCxEGU0Q7q7nEl81RxsG8EeiAznI@z> (raw)
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
>>>>>> Jiangshuai Li via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> All the types of breakpoints and watchpoints are inserted or
>> removed by the gdb stub, these two functions are no longer needed.
>
>Does this mean this is a port that will never have a host port of gdb?
You mean native gdb support? I will port native gdb later.
The reason why I deleted these two functions is that CSKY did not use the remote protocol
provided by GDB long ago, but implemented a set of djp protocols for debugging. At this
time, these two functions are useful. And at the same time, when debugging with gdbserver,
software breakpoints are also inserted and deleted through these two interfaces.
However, the GDB Stubs used by CSKY now use the remote protocol provided by GDB, and
gdbserver also supports inserting and deleting software breakpoints, so these two functions
are no longer needed.
I haven't carefully checked whether native gdb needs these two interfaces, if necessary, add
them later.
>
>I guess it's fine in that case. I wonder if there are other ports in
>this situation.
>
Jiangshuai Li
next reply other threads:[~2022-09-21 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 8:51 jiangshuai_li [this message]
2022-09-21 8:51 ` jiangshuai_li
-- strict thread matches above, loose matches on Subject: below --
2022-08-31 11:49 Jiangshuai Li
2022-09-20 20:14 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537bd63a-eebd-40b2-beb6-d51804cbedce.jiangshuai_li@linux.alibaba.com \
--to=jiangshuai_li@linux.alibaba.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).