public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Carl Love <cel@linux.ibm.com>
To: Luis Machado <luis.machado@arm.com>,
	blarsen@redhat.com, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
	gdb-patches@sourceware.org
Cc: cel@linux.ibm.com, Pedro Alves <pedro@palves.net>,
	Tom Tromey <tom@tromey.com>, Simon Marchi <simark@simark.ca>
Subject: [ PATCH 0/3] Fix GDB reverse execution behavior
Date: Wed, 22 Nov 2023 15:33:01 -0800	[thread overview]
Message-ID: <5483d77c72088a1e4d5dfed2eded2366643fc659.camel@linux.ibm.com> (raw)
In-Reply-To: <ee4ed81911a3196327c2aea3fa9a77f910a5e798.camel@linux.ibm.com>

GDB developers:

The patch "[PATCH 2/2 ver 8] Fix reverse stepping multiple contiguous
PC ranges over the line table", 

https://sourceware.org/pipermail/gdb-patches/2023-August/201889.html

was posted and pinged several times without any response from the
developers.  It was reviewed by Guinevere Larsen. The original patch 2
was intended to fix failures on PowerPC and AArch64.  An additional
architecture independent change and test was added per feedback from
the community.

Based on some private discussions on how best to get the patch
approved, it was suggested that I should break the patch in two to make
it easier to review.  Specifically, separate out the PowerPC and
AArch64 fixes from the generic architecture independent changes.  The
original patch 2 has been split up as suggested.  The hope is this will
make it easier to review and get approval.

The two new patches are functionally identical to the previously posted
patch 2. 

The patch series now consists of three patches.

Patch 1, adds a new option to gdb_compile to either generate or not
generate the line table information.  No change from the prior version.

Patch 2, fix the specific GDB issues with reverse stepping over a line
with multiple statements in the same line for PowerPC and AArch64. 
Behavior on X86-64 did not change.

Patch 3, fix the behavior of GDB for all architectures when executing
the next command in reverse on a line that contains multiple function
calls.

The series of three patches has been tested on PowerPC, X86 and AArch64
with no regression errors.  Please let me know if these patches are
acceptable for mainline.  Note, Luis Machado did the AArch64 testing.
Thanks.

                            Carl 
             


       reply	other threads:[~2023-11-23  5:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f624c5566d6a8a1014ecc38900ca1ba0202989ef.camel@linux.ibm.com>
     [not found] ` <890101c23dd5fa60fcbf9d4b299cb2a533c260b7.camel@linux.ibm.com>
     [not found]   ` <1e702d8f-e5b4-4719-b1e7-42210f350305@arm.com>
     [not found]     ` <a01f4e5f3fd399e3a9a971421265b34d08e32388.camel@linux.ibm.com>
     [not found]       ` <643afce1-ab9b-4e8b-bcbb-5738dc409a28@arm.com>
     [not found]         ` <9e17008084c34f953f5318933436ec703250120a.camel@linux.ibm.com>
     [not found]           ` <92a751d1-a4b9-4c21-821e-a1dc67207516@arm.com>
     [not found]             ` <ee4ed81911a3196327c2aea3fa9a77f910a5e798.camel@linux.ibm.com>
2023-11-22 23:33               ` Carl Love [this message]
2023-11-30 11:36                 ` Guinevere Larsen
2023-11-30 15:39                   ` Carl Love
2023-11-30 15:43                     ` Luis Machado
2023-12-11 14:40                       ` Luis Machado
2023-12-14 16:10                         ` Carl Love
2024-01-02 22:52                           ` Carl Love
2023-11-30 15:45                     ` Guinevere Larsen
2023-11-22 23:33               ` [ PATCH 1/3] " Carl Love
2023-11-29 11:44                 ` Luis Machado
2023-11-29 16:30                   ` Carl Love
2023-11-29 16:38                     ` Luis Machado
2023-11-22 23:33               ` [ PATCH 2/3] " Carl Love
2023-11-29 11:44                 ` Luis Machado
2023-11-22 23:33               ` [PATCH 3/3] " Carl Love
2023-11-29 11:46                 ` Luis Machado
2023-11-29 16:30                   ` Carl Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5483d77c72088a1e4d5dfed2eded2366643fc659.camel@linux.ibm.com \
    --to=cel@linux.ibm.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@arm.com \
    --cc=pedro@palves.net \
    --cc=simark@simark.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).