From: Carl Love <cel@linux.ibm.com>
To: Luis Machado <luis.machado@arm.com>,
blarsen@redhat.com, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
gdb-patches@sourceware.org
Cc: Pedro Alves <pedro@palves.net>, Tom Tromey <tom@tromey.com>,
Simon Marchi <simark@simark.ca>,
cel@linux.ibm.com
Subject: Re: [ PATCH 1/3] Fix GDB reverse execution behavior
Date: Wed, 29 Nov 2023 08:30:11 -0800 [thread overview]
Message-ID: <9623aa811826c6c20b17daf3ec548a7f7f0dbf99.camel@linux.ibm.com> (raw)
In-Reply-To: <99a2fbb3-23b0-4b55-b177-bbeaa2c5334b@arm.com>
Luis:
On Wed, 2023-11-29 at 11:44 +0000, Luis Machado wrote:
> > + } else {
> > + error "Option gcolumn-info option not supported by
> > compiler."
>
> s/Option gcolumn-info option/Option gcolumn-info
fixed
>
> > + }
> > +
> > + } elseif { $opt == "no-column-info" } {
> > + if {[test_compiler_info {gcc-*}]} {
> > + if {[test_compiler_info {gcc-[1-6]-*}]} {
> > + # In this case, don't add the compile line option
> > and
> > + # the result will be the same as using no-column-
> > info
> > + # on a version that supports the option.
> > + warning "gdb_compile option no-column-info not
> > supported, ignoring."
> > + } else {
> > + lappend new_options "additional_flags=-gno-
> > column-info"
> > + }
> > +
> > + } elseif {[test_compiler_info {clang-*}]} {
> > + lappend new_options "additional_flags=-gno-column-
> > info"
> > +
> > + } else {
> > + error "Option gno-column-info option not supported by
> > compiler."
>
> s/Option gno-column-info option/Option gno-column-info
fixed
I made the fixes to the patches. The changes are fairly trivial so let
s see if anyone else has any comments to add before sending out another
version.
Thanks for reviewing and testing.
Carl
next prev parent reply other threads:[~2023-11-29 16:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f624c5566d6a8a1014ecc38900ca1ba0202989ef.camel@linux.ibm.com>
[not found] ` <890101c23dd5fa60fcbf9d4b299cb2a533c260b7.camel@linux.ibm.com>
[not found] ` <1e702d8f-e5b4-4719-b1e7-42210f350305@arm.com>
[not found] ` <a01f4e5f3fd399e3a9a971421265b34d08e32388.camel@linux.ibm.com>
[not found] ` <643afce1-ab9b-4e8b-bcbb-5738dc409a28@arm.com>
[not found] ` <9e17008084c34f953f5318933436ec703250120a.camel@linux.ibm.com>
[not found] ` <92a751d1-a4b9-4c21-821e-a1dc67207516@arm.com>
[not found] ` <ee4ed81911a3196327c2aea3fa9a77f910a5e798.camel@linux.ibm.com>
2023-11-22 23:33 ` [ PATCH 0/3] " Carl Love
2023-11-30 11:36 ` Guinevere Larsen
2023-11-30 15:39 ` Carl Love
2023-11-30 15:43 ` Luis Machado
2023-12-11 14:40 ` Luis Machado
2023-12-14 16:10 ` Carl Love
2024-01-02 22:52 ` Carl Love
2023-11-30 15:45 ` Guinevere Larsen
2023-11-22 23:33 ` [ PATCH 1/3] " Carl Love
2023-11-29 11:44 ` Luis Machado
2023-11-29 16:30 ` Carl Love [this message]
2023-11-29 16:38 ` Luis Machado
2023-11-22 23:33 ` [ PATCH 2/3] " Carl Love
2023-11-29 11:44 ` Luis Machado
2023-11-22 23:33 ` [PATCH 3/3] " Carl Love
2023-11-29 11:46 ` Luis Machado
2023-11-29 16:30 ` Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9623aa811826c6c20b17daf3ec548a7f7f0dbf99.camel@linux.ibm.com \
--to=cel@linux.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=pedro@palves.net \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).