From: Luis Machado <luis.machado@arm.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH, obv] [AArch64] Fix gdb.base/memtag.exp failure
Date: Wed, 7 Jun 2023 08:00:53 +0100 [thread overview]
Message-ID: <54971642-21eb-17ae-b27e-0482922a1906@arm.com> (raw)
In-Reply-To: <20230606134644.35663-1-luis.machado@arm.com>
On 6/6/23 14:46, Luis Machado via Gdb-patches wrote:
> While running this test on an emulator, I noticed we're failing to match the
> output message when "memory-tag check" is issued with no arguments. That's
> because I coded the message using "error" and missed a period at the end. Other
> similar messages are issued with error_no_arg.
>
> This patch changes that call to use error_no_arg.
>
> Tested on aarch64-linux Ubuntu 20.04/22.04.
> ---
> gdb/printcmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/printcmd.c b/gdb/printcmd.c
> index f9517e6e086..d8d97493bab 100644
> --- a/gdb/printcmd.c
> +++ b/gdb/printcmd.c
> @@ -3196,7 +3196,7 @@ memory_tag_check_command (const char *args, int from_tty)
> show_memory_tagging_unsupported ();
>
> if (args == nullptr)
> - error (_("Argument required (address or pointer)"));
> + error_no_arg (_("address or pointer"));
>
> /* Parse the expression into a value. If the value is an address or
> pointer, then check its logical tag against the allocation tag. */
Pushed now.
prev parent reply other threads:[~2023-06-07 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 13:46 Luis Machado
2023-06-07 7:00 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54971642-21eb-17ae-b27e-0482922a1906@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).