* [PATCH, obv] [AArch64] Fix gdb.base/memtag.exp failure
@ 2023-06-06 13:46 Luis Machado
2023-06-07 7:00 ` Luis Machado
0 siblings, 1 reply; 2+ messages in thread
From: Luis Machado @ 2023-06-06 13:46 UTC (permalink / raw)
To: gdb-patches
While running this test on an emulator, I noticed we're failing to match the
output message when "memory-tag check" is issued with no arguments. That's
because I coded the message using "error" and missed a period at the end. Other
similar messages are issued with error_no_arg.
This patch changes that call to use error_no_arg.
Tested on aarch64-linux Ubuntu 20.04/22.04.
---
gdb/printcmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/printcmd.c b/gdb/printcmd.c
index f9517e6e086..d8d97493bab 100644
--- a/gdb/printcmd.c
+++ b/gdb/printcmd.c
@@ -3196,7 +3196,7 @@ memory_tag_check_command (const char *args, int from_tty)
show_memory_tagging_unsupported ();
if (args == nullptr)
- error (_("Argument required (address or pointer)"));
+ error_no_arg (_("address or pointer"));
/* Parse the expression into a value. If the value is an address or
pointer, then check its logical tag against the allocation tag. */
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH, obv] [AArch64] Fix gdb.base/memtag.exp failure
2023-06-06 13:46 [PATCH, obv] [AArch64] Fix gdb.base/memtag.exp failure Luis Machado
@ 2023-06-07 7:00 ` Luis Machado
0 siblings, 0 replies; 2+ messages in thread
From: Luis Machado @ 2023-06-07 7:00 UTC (permalink / raw)
To: gdb-patches
On 6/6/23 14:46, Luis Machado via Gdb-patches wrote:
> While running this test on an emulator, I noticed we're failing to match the
> output message when "memory-tag check" is issued with no arguments. That's
> because I coded the message using "error" and missed a period at the end. Other
> similar messages are issued with error_no_arg.
>
> This patch changes that call to use error_no_arg.
>
> Tested on aarch64-linux Ubuntu 20.04/22.04.
> ---
> gdb/printcmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/printcmd.c b/gdb/printcmd.c
> index f9517e6e086..d8d97493bab 100644
> --- a/gdb/printcmd.c
> +++ b/gdb/printcmd.c
> @@ -3196,7 +3196,7 @@ memory_tag_check_command (const char *args, int from_tty)
> show_memory_tagging_unsupported ();
>
> if (args == nullptr)
> - error (_("Argument required (address or pointer)"));
> + error_no_arg (_("address or pointer"));
>
> /* Parse the expression into a value. If the value is an address or
> pointer, then check its logical tag against the allocation tag. */
Pushed now.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-07 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-06 13:46 [PATCH, obv] [AArch64] Fix gdb.base/memtag.exp failure Luis Machado
2023-06-07 7:00 ` Luis Machado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).