[PATCH] Fix gdb.dlang testsuite regression

[PATCH] Fix gdb.dlang testsuite regression

[Iain Buclaw]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

Hi,

This fixes up tests that were found to be wrong and corrected in the
libiberty testsuite, but weren't sync'd across when pulled in.

Perhaps the demangle.exp tests should be removed from gdb as
libiberty's is a bit more extensive now in both coverage, and odd
corner cases.  But I don't expect any further alterations to occur,
unless an (unlikely) breaking ABI change is introduced.

Regards
Iain

[-- Attachment #2: dlang-testsuite.patch --]
[-- Type: text/x-diff, Size: 3526 bytes --]

gdb/testsuite/
2015-06-29  Iain Buclaw  <ibuclaw@gdcproject.org>

	* gdb.dlang/demangle.exp: Sync tests from libiberty testsuite.

--- a/gdb/testsuite/gdb.dlang/demangle.exp
+++ b/gdb/testsuite/gdb.dlang/demangle.exp
@@ -150,7 +150,7 @@ proc test_d_demangling {} {
 
     test_demangling "_D8demangle4test6__ctorMFZv" "demangle.test.this()"
     test_demangling "_D8demangle4test6__dtorMFZv" "demangle.test.~this()"
-    test_demangling "_D8demangle4test6__postblitMFZv" "demangle.test.this(this)"
+    test_demangling "_D8demangle4test10__postblitMFZv" "demangle.test.this(this)"
 
     test_demangling "_D8demangle4testFHAbaZv" "demangle.test(char\[bool\[\]\])"
     test_demangling "_D8demangle4testFHG42caZv" "demangle.test(char\[creal\[42\]\])"
@@ -171,11 +171,11 @@ proc test_d_demangling {} {
     test_demangling "_D6object6Object8opEqualsFC6ObjectZi" "object.Object.opEquals(Object)"
     test_demangling "_D8demangle4testFLC6ObjectLDFLiZiZi" "demangle.test(lazy Object, lazy int(lazy int) delegate)"
     test_demangling "_D6plugin8generateFiiZAya" "plugin.generate(int, int)"
-    test_demangling "_D8demangle3fnAFZv3fnBMFZv" "demangle.fnA().fnB()"
-    test_demangling "_D8demangle4mainFZv1S3fnCFZv" "demangle.main().S.fnC()"
-    test_demangling "_D8demangle4mainFZv1S3fnDMFZv" "demangle.main().S.fnD()"
+    test_demangling "_D8demangle3fnAFZ3fnBMFZv" "demangle.fnA().fnB()"
+    test_demangling "_D8demangle4mainFZ1S3fnCMFZv" "demangle.main().S.fnC()"
+    test_demangling "_D8demangle4mainFZ1S3fnDMFZv" "demangle.main().S.fnD()"
     test_demangling "_D8demangle2fnFNgiZNgi" "demangle.fn(inout(int))"
-    test_demangling "_D8demangle4mainFZv5localMFZi" "demangle.main().local()"
+    test_demangling "_D8demangle4mainFZ5localMFZi" "demangle.main().local()"
     test_demangling "_D3std5ascii9uppercaseyAa" "std.ascii.uppercase"
     test_demangling "_D3std6stream9BOMEndianyG5E3std6system6Endian" "std.stream.BOMEndian"
     test_demangling "_D3std8internal7uni_tab10unicodeNkoyS3std8internal3uni12CodepointSet" "std.internal.uni_tab.unicodeNko"
@@ -186,7 +186,7 @@ proc test_d_demangling {} {
     test_demangling "_D3std7process18escapeShellCommandFxAAaXAya" "std.process.escapeShellCommand(const(char\[\]\[\])...)"
     test_demangling "_D4core4sync5mutex5Mutex6__ctorMFC6ObjectZC4core4sync5mutex5Mutex" "core.sync.mutex.Mutex.this(Object)"
     test_demangling "_D6object14TypeInfo_Array8argTypesMFNbNfJC8TypeInfoJC8TypeInfoZi" "object.TypeInfo_Array.argTypes(out TypeInfo, out TypeInfo)"
-    test_demangling "_D2rt6dmain211_d_run_mainUiPPaPUAAaZiZi7tryExecMFMDFZvZv" "rt.dmain2._d_run_main(int, char**, extern(C) int(char\[\]\[\]) function*).tryExec(scope void() delegate)"
+    test_demangling "_D2rt6dmain211_d_run_mainUiPPaPUAAaZiZ7tryExecMFMDFZvZv" "rt.dmain2._d_run_main(int, char**, extern(C) int(char\[\]\[\]) function*).tryExec(scope void() delegate)"
     test_demangling "_D6object9Exception6__ctorMFNaNbNfAyaAyamC6object9ThrowableZC9Exception" "object.Exception.this(immutable(char)\[\], immutable(char)\[\], ulong, object.Throwable)"
     test_demangling "_D3gcc3deh17parse_lsda_headerFPS3gcc6unwind7generic15_Unwind_ContextPhPS3gcc3deh16lsda_header_infoZPh" "gcc.deh.parse_lsda_header(gcc.unwind.generic._Unwind_Context*, ubyte*, gcc.deh.lsda_header_info*)"
     test_demangling "_D3std6socket23UnknownAddressReference6__ctorMFPS4core3sys5posix3sys6socket8sockaddrkZC3std6socket23UnknownAddressReference" "std.socket.UnknownAddressReference.this(core.sys.posix.sys.socket.sockaddr*, uint)"

Re: [PATCH] Fix gdb.dlang testsuite regression

[Pedro Alves]

On 06/29/2015 10:06 PM, Iain Buclaw wrote:
> Hi,
> 
> This fixes up tests that were found to be wrong and corrected in the
> libiberty testsuite, but weren't sync'd across when pulled in.

OK.

> Perhaps the demangle.exp tests should be removed from gdb as
> libiberty's is a bit more extensive now in both coverage, and odd
> corner cases.  But I don't expect any further alterations to occur,
> unless an (unlikely) breaking ABI change is introduced.

Up to you.  :-)

Thanks,
Pedro Alves