Re: [PATCH] Fix =thread-exited not showing up when detaching (PR 15564)

Re: [PATCH] Fix =thread-exited not showing up when detaching (PR 15564)

[Pedro Alves]

On 04/30/2015 07:05 PM, Simon Marchi wrote:
> I sent a patch in 2013 for this (incorrectly named =thread-created):
> 
>   https://cygwin.com/ml/gdb-patches/2013-06/msg00129.html
> 
> Tom Tromey was ok with the change, but suggested to add a test as well.
> Then I forgot about this patch until today. So here it is again, with the
> corresponding test.
> 
> The problem is that the =thread-exited event does not appear when detaching
> from a local process. It does appear with remote though. It's not a really
> big deal, but I'd like it to be consistent.
> 
> Tested with local and remote Linux on my Ubuntu 14.04.
> 
> gdb/ChangeLog:
> 
> 	PR gdb/15564
> 	* inferior.c (detach_inferior): Call exit_inferior_1 with silent = 0.
> 
> gdb/testsuite/ChangeLog:
> 
> 	PR gdb/15564
> 	* gdb.mi/mi-detach.exp: New file.

OK.

Thanks,
Pedro Alves

Re: [PATCH] Fix =thread-exited not showing up when detaching (PR 15564)

[Simon Marchi]

On 15-05-19 09:05 AM, Pedro Alves wrote:
> On 04/30/2015 07:05 PM, Simon Marchi wrote:
>> I sent a patch in 2013 for this (incorrectly named =thread-created):
>>
>>   https://cygwin.com/ml/gdb-patches/2013-06/msg00129.html
>>
>> Tom Tromey was ok with the change, but suggested to add a test as well.
>> Then I forgot about this patch until today. So here it is again, with the
>> corresponding test.
>>
>> The problem is that the =thread-exited event does not appear when detaching
>> from a local process. It does appear with remote though. It's not a really
>> big deal, but I'd like it to be consistent.
>>
>> Tested with local and remote Linux on my Ubuntu 14.04.
>>
>> gdb/ChangeLog:
>>
>> 	PR gdb/15564
>> 	* inferior.c (detach_inferior): Call exit_inferior_1 with silent = 0.
>>
>> gdb/testsuite/ChangeLog:
>>
>> 	PR gdb/15564
>> 	* gdb.mi/mi-detach.exp: New file.
> 
> OK.
> 
> Thanks,
> Pedro Alves

Pushed, thanks!

Re: [PATCH] Fix =thread-exited not showing up when detaching (PR 15564)

[Pedro Alves]

Hi Simon,

On 06/02/2015 08:34 PM, Simon Marchi wrote:

>>> gdb/ChangeLog:
>>>
>>> 	PR gdb/15564
>>> 	* inferior.c (detach_inferior): Call exit_inferior_1 with silent = 0.
>>>
>>> gdb/testsuite/ChangeLog:
>>>
>>> 	PR gdb/15564
>>> 	* gdb.mi/mi-detach.exp: New file.

Just noticed that this test fails with gdbserver:

$ make check RUNTESTFLAGS="--target_board=native-gdbserver mi-detach.exp"
...
Running /home/pedro/gdb/mygit/build/../src/gdb/testsuite/gdb.mi/mi-detach.exp ...
FAIL: gdb.mi/mi-detach.exp: detach

(I bisected this, and it turns out to failed already when it was
first added.)

Thanks,
Pedro Alves

Re: [PATCH] Fix =thread-exited not showing up when detaching (PR 15564)

[Yao Qi]

Pedro Alves <palves@redhat.com> writes:

> $ make check RUNTESTFLAGS="--target_board=native-gdbserver mi-detach.exp"
> ...
> Running
> /home/pedro/gdb/mygit/build/../src/gdb/testsuite/gdb.mi/mi-detach.exp
> ...
> FAIL: gdb.mi/mi-detach.exp: detach
>
> (I bisected this, and it turns out to failed already when it was
> first added.)

Hi Simon,
Could you take a look at this fail?  As Pedro said, it fails when it was added.

-- 
Yao (齐尧)

Re: [PATCH] Fix =thread-exited not showing up when detaching (PR 15564)

[Simon Marchi]

On 15-09-01 06:11 AM, Yao Qi wrote:
> Hi Simon,
> Could you take a look at this fail?  As Pedro said, it fails when it was added.

Ok, I'll take a look.