[PATCH] show configuration --without-python

[PATCH] show configuration --without-python

[Dilyan Palauzov]

Emit information upon "show configuration", if GDB has no Python 
support, as it is done for Guile.

diff --git a/gdb/top.c b/gdb/top.c
index 1e30b1c..bd42641 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1326,6 +1326,10 @@ This GDB was configured as follows:\n\
    fprintf_filtered (stream, _("\
               --with-python=%s%s\n\
  "), WITH_PYTHON_PATH, PYTHON_PATH_RELOCATABLE ? " (relocatable)" : "");
+#else
+  fprintf_filtered (stream, _("\
+             --without-python\n\
+"));
  #endif
  #if HAVE_GUILE
    fprintf_filtered (stream, _("\

Re: [PATCH] show configuration --without-python

[Doug Evans]

Dilyan Palauzov <dilyan.palauzov@aegee.org> writes:

> Emit information upon "show configuration", if GDB has no Python
> support, as it is done for Guile.
>
> diff --git a/gdb/top.c b/gdb/top.c
> index 1e30b1c..bd42641 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -1326,6 +1326,10 @@ This GDB was configured as follows:\n\
>    fprintf_filtered (stream, _("\
>               --with-python=%s%s\n\
>  "), WITH_PYTHON_PATH, PYTHON_PATH_RELOCATABLE ? " (relocatable)" : "");
> +#else
> +  fprintf_filtered (stream, _("\
> +             --without-python\n\
> +"));
>  #endif
>  #if HAVE_GUILE
>    fprintf_filtered (stream, _("\

LGTM
[with requisite changelog entry of course]

[PATCH] show configuration --without-python (2)

[Дилян Палаузов]

Any progress here?

On Tue, 2015-07-14 at 12:45 +0200, Dilyan Palauzov wrote:
> Emit information upon "show configuration", if GDB has no Python 
> support, as it is done for Guile.
> 
> diff --git a/gdb/top.c b/gdb/top.c
> index 1e30b1c..bd42641 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -1326,6 +1326,10 @@ This GDB was configured as follows:\n\
>     fprintf_filtered (stream, _("\
>                --with-python=%s%s\n\
>   "), WITH_PYTHON_PATH, PYTHON_PATH_RELOCATABLE ? " (relocatable)" : "");
> +#else
> +  fprintf_filtered (stream, _("\
> +             --without-python\n\
> +"));
>   #endif
>   #if HAVE_GUILE
>     fprintf_filtered (stream, _("\

Re: [PATCH] show configuration --without-python (2)

[Joel Brobecker]

> Any progress here?

Sorry for the late reply. This looks fine. Do you have write access
to the GDB repository?

> 
> On Tue, 2015-07-14 at 12:45 +0200, Dilyan Palauzov wrote:
> > Emit information upon "show configuration", if GDB has no Python 
> > support, as it is done for Guile.
> > 
> > diff --git a/gdb/top.c b/gdb/top.c
> > index 1e30b1c..bd42641 100644
> > --- a/gdb/top.c
> > +++ b/gdb/top.c
> > @@ -1326,6 +1326,10 @@ This GDB was configured as follows:\n\
> >     fprintf_filtered (stream, _("\
> >                --with-python=%s%s\n\
> >   "), WITH_PYTHON_PATH, PYTHON_PATH_RELOCATABLE ? " (relocatable)" : "");
> > +#else
> > +  fprintf_filtered (stream, _("\
> > +             --without-python\n\
> > +"));
> >   #endif
> >   #if HAVE_GUILE
> >     fprintf_filtered (stream, _("\

-- 
Joel

pushed: [PATCH] show configuration --without-python (2)

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

> Sorry for the late reply. This looks fine. Do you have write access
> to the GDB repository?

Дилян confirmed privately that he does not have write access
to the repository, so I pushed the change for him (attached).

-- 
Joel

[-- Attachment #2: 0001-when-printing-the-GDB-config-explicitly-say-if-confi.patch --]
[-- Type: text/x-diff, Size: 1915 bytes --]

From 50c7c5b8df15aad66a9d2f6759e85689a2a74271 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD=20=D0=9F=D0=B0=D0=BB=D0=B0?=
 =?UTF-8?q?=D1=83=D0=B7=D0=BE=D0=B2?= <dilyan.palauzov@aegee.org>
Date: Fri, 21 Dec 2018 19:09:40 +0400
Subject: [PATCH] when printing the GDB config, explicitly say if configured
 without python

When using the --configuration command line switch, or using
the "show configuration" command with a version of GDB which
was configured without Python supoprt, this patch changes
the resulting output to include...

    --without-python

... instead of not printing anything about Python support.

gdb/ChangeLog:

        * top.c (print_gdb_configuration): Print "--without-python"
        if GDB was configured without Python.

Tested on x86_64-linux by rebuilding GDB with and without Python,
and checking the output of "gdb --configuration" in both cases.
---
 gdb/ChangeLog | 5 +++++
 gdb/top.c     | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 900a4c70e1f..4ead538e674 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-12-21  Дилян Палаузов  <dilyan.palauzov@aegee.org>
+
+	* top.c (print_gdb_configuration): Print "--without-python"
+	if GDB was configured without Python.
+
 2018-12-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* riscv-tdep.c (riscv_scan_prologue): Use plongest to format
diff --git a/gdb/top.c b/gdb/top.c
index 4a0fedb6a87..ac74cb3a226 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1428,6 +1428,10 @@ This GDB was configured as follows:\n\
   fprintf_filtered (stream, _("\
              --with-python=%s%s\n\
 "), WITH_PYTHON_PATH, PYTHON_PATH_RELOCATABLE ? " (relocatable)" : "");
+#else
+  fprintf_filtered (stream, _("\
+             --without-python\n\
+"));
 #endif
 #if HAVE_GUILE
   fprintf_filtered (stream, _("\
-- 
2.17.1