[PATCH] Always organize test artifacts in a directory hierarchy

[PATCH] Always organize test artifacts in a directory hierarchy

[Simon Marchi]

When running tests in parallel, each test puts its generated files in a
different directory, under "testsuite/outputs":

outputs
├── gdb.base
│   ├── break
│   ├── whatis
│   └── ...
├── gdb.python
│   ├── py-type
│   ├── py-value
│   └── ...
└── ...

I think it would be nice if it was always organized like this, even in
serial mode, as it would isolate the test cases a bit more.  An artifact
created by a test wouldn't get overwritten by another test.  It would be
clear which test produced which files.

It would also make it easier to clean up.  Currently, make clean in the
testsuite is broken.  A lot of executables are left all over the place
because their names do not appear in gdb.*/Makefile.  If everything is
in "outputs", then we just have to delete that directory (which we
already do).

At the same time it makes the gdb.foo directories and their Makefiles
useless in the build directory, since they are pretty much only used for
cleaning.

Note: the performance testsuite still produces some files in gdb.perf.
If this is accepted, we can always look at that later.

What do you think?

gdb/testsuite/ChangeLog:

	* Makefile.in (ALL_SUBDIRS): Remove.
	(clean mostlyclean): Do not recurse in ALL_SUBDIRS.
	(distclean maintainer-clean realclean): Likewise.
	* configure.ac (AC_OUTPUT): Remove gdb.*/Makefile.
	* configure: Regenerate.
	* gdb.ada/Makefile.in: Delete.
	* gdb.arch/Makefile.in: Likewise.
	* gdb.asm/Makefile.in: Likewise.
	* gdb.base/Makefile.in: Likewise.
	* gdb.btrace/Makefile.in: Likewise.
	* gdb.cell/Makefile.in: Likewise.
	* gdb.compile/Makefile.in: Likewise.
	* gdb.cp/Makefile.in: Likewise.
	* gdb.disasm/Makefile.in: Likewise.
	* gdb.dlang/Makefile.in: Likewise.
	* gdb.dwarf2/Makefile.in: Likewise.
	* gdb.fortran/Makefile.in: Likewise.
	* gdb.gdb/Makefile.in: Likewise.
	* gdb.go/Makefile.in: Likewise.
	* gdb.guile/Makefile.in: Likewise.
	* gdb.java/Makefile.in: Likewise.
	* gdb.linespec/Makefile.in: Likewise.
	* gdb.mi/Makefile.in: Likewise.
	* gdb.modula2/Makefile.in: Likewise.
	* gdb.multi/Makefile.in: Likewise.
	* gdb.objc/Makefile.in: Likewise.
	* gdb.opencl/Makefile.in: Likewise.
	* gdb.opt/Makefile.in: Likewise.
	* gdb.pascal/Makefile.in: Likewise.
	* gdb.perf/Makefile.in: Likewise.
	* gdb.python/Makefile.in: Likewise.
	* gdb.reverse/Makefile.in: Likewise.
	* gdb.server/Makefile.in: Likewise.
	* gdb.stabs/Makefile.in: Likewise.
	* gdb.threads/Makefile.in: Likewise.
	* gdb.trace/Makefile.in: Likewise.
	* gdb.xml/Makefile.in: Likewise.
	* lib/gdb.exp (make_gdb_parallel_path): Add check for
	GDB_PARALLEL.
	(standard_output_file): Remove check for GDB_PARALLEL, always
	return path in outputs/$subdir/$testname.
---
 gdb/testsuite/Makefile.in              | 24 ------------
 gdb/testsuite/configure                | 34 +----------------
 gdb/testsuite/configure.ac             | 12 +-----
 gdb/testsuite/gdb.ada/Makefile.in      | 66 --------------------------------
 gdb/testsuite/gdb.arch/Makefile.in     | 20 ----------
 gdb/testsuite/gdb.asm/Makefile.in      | 20 ----------
 gdb/testsuite/gdb.base/Makefile.in     | 69 ----------------------------------
 gdb/testsuite/gdb.btrace/Makefile.in   | 19 ----------
 gdb/testsuite/gdb.cell/Makefile.in     | 21 -----------
 gdb/testsuite/gdb.compile/Makefile.in  | 21 -----------
 gdb/testsuite/gdb.cp/Makefile.in       | 28 --------------
 gdb/testsuite/gdb.disasm/Makefile.in   | 14 -------
 gdb/testsuite/gdb.dlang/Makefile.in    | 15 --------
 gdb/testsuite/gdb.dwarf2/Makefile.in   | 46 -----------------------
 gdb/testsuite/gdb.fortran/Makefile.in  | 34 -----------------
 gdb/testsuite/gdb.gdb/Makefile.in      | 15 --------
 gdb/testsuite/gdb.go/Makefile.in       | 21 -----------
 gdb/testsuite/gdb.guile/Makefile.in    | 17 ---------
 gdb/testsuite/gdb.java/Makefile.in     | 22 -----------
 gdb/testsuite/gdb.linespec/Makefile.in | 15 --------
 gdb/testsuite/gdb.mi/Makefile.in       | 30 ---------------
 gdb/testsuite/gdb.modula2/Makefile.in  | 34 -----------------
 gdb/testsuite/gdb.multi/Makefile.in    | 15 --------
 gdb/testsuite/gdb.objc/Makefile.in     | 23 ------------
 gdb/testsuite/gdb.opencl/Makefile.in   | 18 ---------
 gdb/testsuite/gdb.opt/Makefile.in      | 25 ------------
 gdb/testsuite/gdb.pascal/Makefile.in   | 25 ------------
 gdb/testsuite/gdb.perf/Makefile.in     | 15 --------
 gdb/testsuite/gdb.python/Makefile.in   | 22 -----------
 gdb/testsuite/gdb.reverse/Makefile.in  | 21 -----------
 gdb/testsuite/gdb.server/Makefile.in   | 26 -------------
 gdb/testsuite/gdb.stabs/Makefile.in    | 14 -------
 gdb/testsuite/gdb.threads/Makefile.in  | 25 ------------
 gdb/testsuite/gdb.trace/Makefile.in    | 19 ----------
 gdb/testsuite/gdb.xml/Makefile.in      | 14 -------
 gdb/testsuite/lib/gdb.exp              | 14 +++----
 36 files changed, 7 insertions(+), 866 deletions(-)
 delete mode 100644 gdb/testsuite/gdb.ada/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.arch/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.asm/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.base/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.btrace/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.cell/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.compile/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.cp/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.disasm/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.dlang/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.dwarf2/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.fortran/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.gdb/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.go/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.guile/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.java/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.linespec/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.mi/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.modula2/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.multi/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.objc/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.opencl/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.opt/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.pascal/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.perf/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.python/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.reverse/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.server/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.stabs/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.threads/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.trace/Makefile.in
 delete mode 100644 gdb/testsuite/gdb.xml/Makefile.in

diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index fb0d8e5..62942f6 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -32,12 +32,6 @@ SHELL = @SHELL@
 EXEEXT = @EXEEXT@
 SUBDIRS = @subdirs@
 RPATH_ENVVAR = @RPATH_ENVVAR@
-ALL_SUBDIRS = gdb.ada gdb.arch gdb.asm gdb.base gdb.btrace gdb.cell gdb.cp \
-	gdb.disasm gdb.dlang gdb.dwarf2 gdb.fortran gdb.gdb gdb.go \
-	gdb.java gdb.linespec gdb.mi gdb.modula2 gdb.multi \
-	gdb.objc gdb.opencl gdb.opt gdb.pascal gdb.python gdb.server \
-	gdb.stabs gdb.reverse gdb.threads gdb.trace gdb.xml \
-	$(SUBDIRS)
 
 EXTRA_RULES = @EXTRA_RULES@
 
@@ -279,29 +273,11 @@ clean mostlyclean:
 	-rm -rf outputs temp cache
 	-rm -rf gdb.perf/workers gdb.perf/outputs gdb.perf/temp gdb.perf/cache
 	-rm -f read1.so expect-read1
-	if [ x"${ALL_SUBDIRS}" != x ] ; then \
-	    for dir in ${ALL_SUBDIRS}; \
-	    do \
-		    echo "$$dir:"; \
-		    if [ -d $$dir ]; then \
-			    (cd $$dir; $(MAKE) clean); \
-		    fi; \
-	    done ; \
-	else true; fi
 
 distclean maintainer-clean realclean: clean
 	-rm -f *~ core
 	-rm -f Makefile config.status *-init.exp
 	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
-	if [ x"${ALL_SUBDIRS}" != x ] ; then \
-	    for dir in ${ALL_SUBDIRS}; \
-	    do \
-		    echo "$$dir:"; \
-		    if [ -d $$dir ]; then \
-			    (cd $$dir; $(MAKE) distclean); \
-		    fi; \
-	    done ; \
-	else true; fi
 
 Makefile : Makefile.in config.status $(host_makefile_frag)
 	$(SHELL) config.status
diff --git a/gdb/testsuite/configure b/gdb/testsuite/configure
index 687e06d..c600426 100755
--- a/gdb/testsuite/configure
+++ b/gdb/testsuite/configure
@@ -3512,7 +3512,7 @@ program_transform_name=`$as_echo "$program_transform_name" | sed "$ac_script"`
 ac_config_files="$ac_config_files lib/pdtrace"
 
 
-ac_config_files="$ac_config_files Makefile gdb.ada/Makefile gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile gdb.btrace/Makefile gdb.cell/Makefile gdb.compile/Makefile gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile gdb.dlang/Makefile gdb.fortran/Makefile gdb.gdb/Makefile gdb.go/Makefile gdb.server/Makefile gdb.java/Makefile gdb.guile/Makefile gdb.linespec/Makefile gdb.mi/Makefile gdb.modula2/Makefile gdb.multi/Makefile gdb.objc/Makefile gdb.opencl/Makefile gdb.opt/Makefile gdb.pascal/Makefile gdb.perf/Makefile gdb.python/Makefile gdb.reverse/Makefile gdb.stabs/Makefile gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile"
+ac_config_files="$ac_config_files Makefile"
 
 cat >confcache <<\_ACEOF
 # This file is a shell script that caches the results of configure
@@ -4214,38 +4214,6 @@ do
   case $ac_config_target in
     "lib/pdtrace") CONFIG_FILES="$CONFIG_FILES lib/pdtrace" ;;
     "Makefile") CONFIG_FILES="$CONFIG_FILES Makefile" ;;
-    "gdb.ada/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.ada/Makefile" ;;
-    "gdb.arch/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.arch/Makefile" ;;
-    "gdb.asm/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.asm/Makefile" ;;
-    "gdb.base/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.base/Makefile" ;;
-    "gdb.btrace/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.btrace/Makefile" ;;
-    "gdb.cell/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.cell/Makefile" ;;
-    "gdb.compile/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.compile/Makefile" ;;
-    "gdb.cp/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.cp/Makefile" ;;
-    "gdb.disasm/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.disasm/Makefile" ;;
-    "gdb.dwarf2/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.dwarf2/Makefile" ;;
-    "gdb.dlang/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.dlang/Makefile" ;;
-    "gdb.fortran/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.fortran/Makefile" ;;
-    "gdb.gdb/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.gdb/Makefile" ;;
-    "gdb.go/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.go/Makefile" ;;
-    "gdb.server/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.server/Makefile" ;;
-    "gdb.java/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.java/Makefile" ;;
-    "gdb.guile/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.guile/Makefile" ;;
-    "gdb.linespec/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.linespec/Makefile" ;;
-    "gdb.mi/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.mi/Makefile" ;;
-    "gdb.modula2/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.modula2/Makefile" ;;
-    "gdb.multi/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.multi/Makefile" ;;
-    "gdb.objc/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.objc/Makefile" ;;
-    "gdb.opencl/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.opencl/Makefile" ;;
-    "gdb.opt/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.opt/Makefile" ;;
-    "gdb.pascal/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.pascal/Makefile" ;;
-    "gdb.perf/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.perf/Makefile" ;;
-    "gdb.python/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.python/Makefile" ;;
-    "gdb.reverse/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.reverse/Makefile" ;;
-    "gdb.stabs/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.stabs/Makefile" ;;
-    "gdb.threads/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.threads/Makefile" ;;
-    "gdb.trace/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.trace/Makefile" ;;
-    "gdb.xml/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.xml/Makefile" ;;
 
   *) as_fn_error "invalid argument: \`$ac_config_target'" "$LINENO" 5;;
   esac
diff --git a/gdb/testsuite/configure.ac b/gdb/testsuite/configure.ac
index aeaf29a..c372af5 100644
--- a/gdb/testsuite/configure.ac
+++ b/gdb/testsuite/configure.ac
@@ -103,14 +103,4 @@ GDB_AC_TRANSFORM(as, GAS_TRANSFORM_NAME)
 GDB_AC_TRANSFORM(nm, NM_TRANSFORM_NAME)
 AC_CONFIG_FILES([lib/pdtrace], [chmod +x lib/pdtrace])
 
-AC_OUTPUT([Makefile \
-  gdb.ada/Makefile \
-  gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile gdb.btrace/Makefile \
-  gdb.cell/Makefile gdb.compile/Makefile gdb.cp/Makefile gdb.disasm/Makefile \
-  gdb.dwarf2/Makefile gdb.dlang/Makefile gdb.fortran/Makefile gdb.gdb/Makefile \
-  gdb.go/Makefile gdb.server/Makefile gdb.java/Makefile \
-  gdb.guile/Makefile gdb.linespec/Makefile \
-  gdb.mi/Makefile gdb.modula2/Makefile gdb.multi/Makefile \
-  gdb.objc/Makefile gdb.opencl/Makefile gdb.opt/Makefile gdb.pascal/Makefile \
-  gdb.perf/Makefile gdb.python/Makefile gdb.reverse/Makefile gdb.stabs/Makefile \
-  gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile])
+AC_OUTPUT([Makefile])
diff --git a/gdb/testsuite/gdb.ada/Makefile.in b/gdb/testsuite/gdb.ada/Makefile.in
deleted file mode 100644
index d9a3c79..0000000
--- a/gdb/testsuite/gdb.ada/Makefile.in
+++ /dev/null
@@ -1,66 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = \
-  array_bounds/bar \
-  array_return/p \
-  array_subscript_addr/p \
-  arrayidx/p \
-  arrayparam/foo \
-  arrayptr/foo \
-  atomic_enum/foo \
-  catch_ex/foo \
-  char_param/foo \
-  complete/foo \
-  exec_changed/common \
-  exec_changed/first \
-  exec_changed/second \
-  exprs/p \
-  fixed_cmp/fixed \
-  fixed_points/fixed_points \
-  formatted_ref/formatted_ref \
-  frame_args/foo \
-  fun_addr/foo \
-  fun_in_declare/foo \
-  funcall_param/foo \
-  homonym/homonym_main \
-  info_types \
-  interface/foo \
-  lang_switch/lang_switch \
-  nested/hello \
-  null_array/foo \
-  null_record/null_record \
-  packed_array/pa \
-  packed_tagged/comp_bug \
-  print_chars/foo \
-  start/dummy \
-  ptype_field/foo \
-  ref_param/foo \
-  str_ref_cmp/foo \
-  sym_print_name/foo \
-  taft_type/p \
-  tagged/foo \
-  type_coercion/assign \
-  watch_arg/watch
-
-MISCELLANEOUS =
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-find . -name '*.o' -print | xargs rm -f
-	-find . -name '*.ali' -print | xargs rm -f
-	-find . -name 'b~*.ad[sb]' -print | xargs rm -f
-	-rm -f *~ a.out xgdb *.x *.ci *.tmp
-	-rm -f *~ *.o a.out xgdb *.x *.ci *.tmp
-	-find . -name '*.dwo' -print | xargs rm -f
-	-find . -name '*.dwp' -print | xargs rm -f
-	-rm -f core core.coremaker coremaker.core corefile $(EXECUTABLES)
-	-rm -f $(MISCELLANEOUS) twice-tmp.c
-
-distclean maintainer-clean realclean: clean
-	-rm -f *~ core
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.arch/Makefile.in b/gdb/testsuite/gdb.arch/Makefile.in
deleted file mode 100644
index 9aaf1ce..0000000
--- a/gdb/testsuite/gdb.arch/Makefile.in
+++ /dev/null
@@ -1,20 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = altivec-abi altivec-regs amd64-byte amd64-disp-step amd64-dword \
-	amd64-entry-value amd64-i386-address amd64-word i386-bp_permanent \
-	i386-permbkpt i386-avx i386-avx512 i386-signal i386-sse sparc-sysstep
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o a.out *.x *.ci *.tmp gcore.test system-gcore
-	-rm -f core core.coremaker coremaker.core corefile $(EXECUTABLES)
-	-rm -f *.dwo *.dwp
-
-distclean maintainer-clean realclean: clean
-	-rm -f *~ core
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.asm/Makefile.in b/gdb/testsuite/gdb.asm/Makefile.in
deleted file mode 100644
index f3e6e8b..0000000
--- a/gdb/testsuite/gdb.asm/Makefile.in
+++ /dev/null
@@ -1,20 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = asm-source
-MISCELLANEOUS = arch.inc
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o a.out *.x *.ci *.tmp
-	-rm -f *.dwo *.dwp
-	-rm -f core core.coremaker coremaker.core corefile $(EXECUTABLES)
-	-rm -f $(MISCELLANEOUS)
-
-distclean maintainer-clean realclean: clean
-	-rm -f *~ core
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.base/Makefile.in b/gdb/testsuite/gdb.base/Makefile.in
deleted file mode 100644
index dda3169..0000000
--- a/gdb/testsuite/gdb.base/Makefile.in
+++ /dev/null
@@ -1,69 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = a2-run advance all-types annota1 annota1-watch_thread_num \
-	annota3 anon args arrayidx async attach attach-pie-misread \
-	attach2 auxv bang\! bfp-test bigcore bitfields bitfields2 \
-	break break-always break-entry break-interp-test breako2 \
-	breakpoint-shadow break-on-linker-gcd-function \
-	call-ar-st call-rt-st call-sc-t* call-signals \
-	call-strs callexit callfuncs callfwmall charset checkpoint \
-	chng-syms code_elim1 code_elim2 commands compiler completion complex \
-	condbreak consecutive constvars coremaker cursal cvexpr \
-	dbx-test del disasm-end-cu display dprintf-pending dump dup-sect \
-	dup-sect.debug \
-	dup-sect.stripped ending-run execd-prog expand-psymtabs exprs \
-	fileio find finish fixsection float foll-exec foll-fork foll-vfork \
-	frame-args freebpcmd fullname funcargs gcore \
-	gcore-buffer-overflow-012* \
-	gdb1090 gdb11530 gdb11531 gdb1250 gdb1555-main gdb1821 gdbvars \
-	hashline1 hashline2 hashline3 hbreak hook-stop-continue \
-	hook-stop-frame huge included infnan info-target int-type \
-	interrupt jit-main jump label langs lineinc list longjmp long_long \
-	macscp mips_pro miscexprs moribund-step multi-forks nodebug \
-	nofield nostdlib opaque overlays pc-fp pending permission \
-	pie-execl1 pie-execl2 pointers pointers2 pr11022 prelinkt \
-	prelinkt.debug prelinkt.stripped printcmds prologue psymtab \
-	ptr-typedef ptype randomize recurse relational relativedebug \
-	reread reread1 restore return return-nodebug-* return2 run \
-	savedregs scope section_command sep sepdebug sepdebug.stripped \
-	sepdebug2 sepdebug2.debug sepdebug2.stripped sepsymtab \
-	sepsymtab.debug sepsymtab.stripped setshow setvar shmain shreloc \
-	sigall sigaltstack sigbpt sigchld siginfo siginfo-addr \
-	siginfo-infcall siginfo-obj signals signull sigrepeat sigstep \
-	sizeof skip skip-solib solib solib-corrupted solib-display-main \
-	solib-nodir solib-overlap-main-0x40000000 solib-symbol-main solib-weak \
-	solib-weak-lib2 solib_sl so-impl-ld so-indr-cl \
-	stack-checking start step-break step-bt step-line step-resume-infcall \
-	step-test store structs-t* structs2 structs3 \
-	symbol-without-target_section term tui-layout twice-tmp \
-	type-opaque-main ui-redirect unload until unwindonsignal \
-	valgrind-db-attach value-double-free varargs vforked-prog \
-	volatile watch-cond watch-cond-infcall watch-non-mem watch-read \
-	watch-vfork watch_thread_num watchpoint watchpoint-cond-gone \
-	watchpoint-hw watchpoint-hw-hit-once watchpoint-solib watchpoints \
-	wchar whatis whatis-exp catch-syscall \
-	pr10179 gnu_vector
-
-MISCELLANEOUS = coremmap.data dprintf-pendshr.sl ../foobar.baz fixsectshr.sl \
-	pendshr.sl shreloc1.sl shreloc2.sl twice-tmp.c \
-	shr1.sl shr2.sl solib_sl.sl solib1.sl solib2.sl \
-	unloadshr.sl unloadshr2.sl watchpoint-solib-shr.sl \
-	weaklib1.sl weaklib2.sl hashline1.c hashline2.c hashline3.c \
-	auxv.gcore bigcore.corefile *.core *.debug *.stripped \
-	gcore-buffer-overflow.test gcore.test shreloc.txt tmp-fullname.c
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o a.out xgdb *.x *.ci *.tmp
-	-rm -f *.dwo *.dwp
-	-rm -f core core.coremaker coremaker.core corefile $(EXECUTABLES)
-	-rm -f $(MISCELLANEOUS)
-
-distclean maintainer-clean realclean: clean
-	-rm -f *~ core
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.btrace/Makefile.in b/gdb/testsuite/gdb.btrace/Makefile.in
deleted file mode 100644
index c90794f..0000000
--- a/gdb/testsuite/gdb.btrace/Makefile.in
+++ /dev/null
@@ -1,19 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES   = enable function_call_history instruction_history tailcall \
-  exception unknown_functions record_goto delta step stepi \
-  multi-thread-step rn-dl-bind data
-
-MISCELLANEOUS =
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	rm -f *~ *.o *.x *.ci *.sl a.out core
-	rm -f *.dwo *.dwp
-	rm -f $(EXECUTABLES) $(MISCELLANEOUS)
-
-distclean maintainer-clean realclean: clean
-	rm -f Makefile config.status config.log site.* gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.cell/Makefile.in b/gdb/testsuite/gdb.cell/Makefile.in
deleted file mode 100644
index 7771d61..0000000
--- a/gdb/testsuite/gdb.cell/Makefile.in
+++ /dev/null
@@ -1,21 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = break bt coremaker data mem-access size
-
-SPU_EXECUTABLES = break-spu bt-spu bt2-spu coremaker-spu data-spu \
-		  ea-cache-spu ea-standalone ea-test mem-access-spu size-spu
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o a.out core corefile gcore.test
-	-rm -f *.dwo *.dwp
-	-rm -f $(EXECUTABLES) $(SPU_EXECUTABLES)
-
-distclean maintainer-clean realclean: clean
-	-rm -f *~ core
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.compile/Makefile.in b/gdb/testsuite/gdb.compile/Makefile.in
deleted file mode 100644
index 6a1a895..0000000
--- a/gdb/testsuite/gdb.compile/Makefile.in
+++ /dev/null
@@ -1,21 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = \
-	chan handcall hello integers methods package \
-	strings types unsafe
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-find . -name '*.o' -print | xargs rm -f
-	-find . -name '*.ali' -print | xargs rm -f
-	-rm -f *~ a.out
-	-rm -f *.dwo *.dwp
-	-rm -f core core.coremaker coremaker.core corefile $(EXECUTABLES)
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.cp/Makefile.in b/gdb/testsuite/gdb.cp/Makefile.in
deleted file mode 100644
index 2958e24..0000000
--- a/gdb/testsuite/gdb.cp/Makefile.in
+++ /dev/null
@@ -1,28 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = abstract-origin ambiguous annota2 annota3 anon-union \
-	arg-reference bool breakpoint bs15503 call-c casts class2 \
-	classes converts cpexprs cplusfuncs cttiadd derivation \
-	exception expand-sals extern-c formatted-ref fpointer gdb1355 \
-	gdb2384 hang infcall-dlopen inherit koenig local m-data m-static \
-	mb-ctor mb-inline mb-templates member-ptr method misc namespace \
-	namespace-enum namespace-nested-import nextoverthrow noparam nsdecl \
-	nsimport nsnested nsnoimports nsrecurs nsstress nsusing operator \
-	oranking overload overload-const ovldbreak pass-by-ref pr-1023 pr-1210 \
-	pr-574 pr10728 pr12028 pr9631 printmethod psmang ptype-cv-cp \
-	re-set-overloaded ref-typ ref-typ2 rtti shadow smartp temargs \
-	templates try_catch typedef-operator userdef virtbase virtfunc \
-	ref-types ref-params method2 pr9594 gdb2495 virtfunc2 pr9067 \
-	pr1072 pr10687 pr9167
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o *.ci
-	-rm -f *.dwo *.dwp
-	-rm -f core ${EXECUTABLES}
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.disasm/Makefile.in b/gdb/testsuite/gdb.disasm/Makefile.in
deleted file mode 100644
index f4830fa..0000000
--- a/gdb/testsuite/gdb.disasm/Makefile.in
+++ /dev/null
@@ -1,14 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-.PHONY: all clean mostlyclean distclean realclean
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *.o *.diff *~ *.bad core h8300s hppa mn10300 sh3
-	-rm -f *.dwo *.dwp
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.dlang/Makefile.in b/gdb/testsuite/gdb.dlang/Makefile.in
deleted file mode 100644
index 5527c3e..0000000
--- a/gdb/testsuite/gdb.dlang/Makefile.in
+++ /dev/null
@@ -1,15 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES =
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o *.ci
-	-rm -f *.dwo *.dwp
-	-rm -f core ${EXECUTABLES}
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.dwarf2/Makefile.in b/gdb/testsuite/gdb.dwarf2/Makefile.in
deleted file mode 100644
index 02f6a67..0000000
--- a/gdb/testsuite/gdb.dwarf2/Makefile.in
+++ /dev/null
@@ -1,46 +0,0 @@
-# Makefile for regression testing the GNU debugger.
-# Copyright 1992-2016 Free Software Foundation, Inc.
-
-# This file is part of GDB.
-
-# GDB is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3, or (at your option)
-# any later version.
-
-# GDB is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
-
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = *.x pr10770 dw2-cp-infcall-ref-static dw2-inline-param \
-	dw2-noloc dw2-ranges dw2-ref-missing-frame dw2-unresolved gdb-index \
-	dwp-symlink
-
-MISCELLANEOUS = \
-	dwp-symlink.dwp dwp-symlink-thelink dwp-symlink-thelink.dwp \
-	dwp-dir1 dwp-dir2 dwp-dir3
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o a.out *.x *.ci *.tmp
-	-rm -f core core.coremaker coremaker.core corefile
-	-rm -f *.dwo *.dwp
-	-rm -f $(EXECUTABLES)
-	-rm -rf $(MISCELLANEOUS)
-	-rm -f *.gdb-index *.with-index
-
-distclean maintainer-clean realclean: clean
-	-rm -f *~ core
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.fortran/Makefile.in b/gdb/testsuite/gdb.fortran/Makefile.in
deleted file mode 100644
index e9a1f04..0000000
--- a/gdb/testsuite/gdb.fortran/Makefile.in
+++ /dev/null
@@ -1,34 +0,0 @@
-# Makefile for regression testing the GNU debugger.
-# Copyright 1992-2016 Free Software Foundation, Inc.
-
-# This file is part of GDB.
-
-# GDB is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3, or (at your option)
-# any later version.
-
-# GDB is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
-
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = 
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o *.ci
-	-rm -f *.dwo *.dwp
-	-rm -f core ${EXECUTABLES}
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.gdb/Makefile.in b/gdb/testsuite/gdb.gdb/Makefile.in
deleted file mode 100644
index 5527c3e..0000000
--- a/gdb/testsuite/gdb.gdb/Makefile.in
+++ /dev/null
@@ -1,15 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES =
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o *.ci
-	-rm -f *.dwo *.dwp
-	-rm -f core ${EXECUTABLES}
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.go/Makefile.in b/gdb/testsuite/gdb.go/Makefile.in
deleted file mode 100644
index 6a1a895..0000000
--- a/gdb/testsuite/gdb.go/Makefile.in
+++ /dev/null
@@ -1,21 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = \
-	chan handcall hello integers methods package \
-	strings types unsafe
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-find . -name '*.o' -print | xargs rm -f
-	-find . -name '*.ali' -print | xargs rm -f
-	-rm -f *~ a.out
-	-rm -f *.dwo *.dwp
-	-rm -f core core.coremaker coremaker.core corefile $(EXECUTABLES)
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.guile/Makefile.in b/gdb/testsuite/gdb.guile/Makefile.in
deleted file mode 100644
index 37f9cb0..0000000
--- a/gdb/testsuite/gdb.guile/Makefile.in
+++ /dev/null
@@ -1,17 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES =
-
-MISCELLANEOUS =
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o *.ci
-	-rm -f *.dwo *.dwp
-	-rm -f core $(EXECUTABLES) $(MISCELLANEOUS)
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.java/Makefile.in b/gdb/testsuite/gdb.java/Makefile.in
deleted file mode 100644
index 0b0ae1a..0000000
--- a/gdb/testsuite/gdb.java/Makefile.in
+++ /dev/null
@@ -1,22 +0,0 @@
-srcdir = @srcdir@
-VPATH = @srcdir@
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-.SUFFIXES: .java .class .o .exe .exp .check
-
-# Do 'make javamisc.check' to run just the javamisc.exp test.
-
-.exp.check:
-	rootme=`pwd`/; export rootme; \
-	cd .. ; \
-	$(MAKE) just-check RUNTESTFLAGS="${RUNTESTFLAGS} $*.exp" \
-	  EXPECT=${EXPECT}
-
-clean mostlyclean:
-	-rm -f *.o ${OBJS}  *.class *.exe *~ core jmain jmisc jnpe jprint
-	-rm -f *.dwo *.dwp
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.linespec/Makefile.in b/gdb/testsuite/gdb.linespec/Makefile.in
deleted file mode 100644
index 18eadbe..0000000
--- a/gdb/testsuite/gdb.linespec/Makefile.in
+++ /dev/null
@@ -1,15 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = lspec
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o *.ci
-	-rm -f *.dwo *.dwp
-	-rm -f core $(EXECUTABLES)
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.mi/Makefile.in b/gdb/testsuite/gdb.mi/Makefile.in
deleted file mode 100644
index 2ea819d..0000000
--- a/gdb/testsuite/gdb.mi/Makefile.in
+++ /dev/null
@@ -1,30 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-PROGS = basics c_variable cpp_variable var-cmd dw2-ref-missing-frame	\
-	gdb669-pthreads gdb701 gdb792 mi-async mi-basics mi-break	\
-	mi-cli mi-console mi-disassemble mi-dprintf mi-eval mi-file	\
-	mi-file-transfer mi-non-stop mi-non-stop-exit			\
-	mi-ns-stale-regcache mi-nsintrall mi-nsmoribund mi-nsthrexec	\
-	mi-pending mi-pthreads mi-read-memory mi-regs mi-return		\
-	mi-reverse mi-simplerun mi-stack mi-stepi mi-syn-frame		\
-	mi-var-block mi-var-child mi-var-cmd mi-var-cp mi-var-display	\
-	mi-var-invalidate mi-var-invalidate_bis mi-watch		\
-	mi2-amd64-entry-value mi2-basics				\
-	mi2-break mi2-cli mi2-disassemble mi2-eval mi2-file		\
-	mi2-pthreads mi2-regs mi2-return mi2-simplerun mi2-stepi	\
-	mi2-var-block mi2-var-child mi2-var-cmd mi2-var-display		\
-	mi2-watch until
-
-MISCELLANEOUS = mi-pendshr.sl mi-pendshr2.sl
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *.ci *.o $(OBJS) $(PROGS) *~ core
-	-rm -f *.dwo *.dwp
-	-rm -f $(MISCELLANEOUS)
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.modula2/Makefile.in b/gdb/testsuite/gdb.modula2/Makefile.in
deleted file mode 100644
index 39359fc..0000000
--- a/gdb/testsuite/gdb.modula2/Makefile.in
+++ /dev/null
@@ -1,34 +0,0 @@
-# Makefile for regression testing the GNU debugger.
-# Copyright 2007-2016 Free Software Foundation, Inc.
-
-# This file is part of GDB.
-
-# GDB is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3, or (at your option)
-# any later version.
-
-# GDB is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
-
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = unbounded1
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o *.ci
-	-rm -f *.dwo *.dwp
-	-rm -f core ${EXECUTABLES}
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.multi/Makefile.in b/gdb/testsuite/gdb.multi/Makefile.in
deleted file mode 100644
index fe26bae..0000000
--- a/gdb/testsuite/gdb.multi/Makefile.in
+++ /dev/null
@@ -1,15 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = hello hangout goodbye bkpt-multi-exec crashme
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o *.ci
-	-rm -f *.dwo *.dwp
-	-rm -f core $(EXECUTABLES)
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.objc/Makefile.in b/gdb/testsuite/gdb.objc/Makefile.in
deleted file mode 100644
index c9ed32b..0000000
--- a/gdb/testsuite/gdb.objc/Makefile.in
+++ /dev/null
@@ -1,23 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = basicclass
-
-all: 
-	@echo "Nothing to be done for all..."
-
-info:
-install-info:
-dvi:
-install:
-uninstall: force
-installcheck:
-check:
-
-clean mostlyclean:
-	-rm -f *~ *.o *.ci
-	-rm -f *.dwo *.dwp
-	-rm -f core ${EXECUTABLES}
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.opencl/Makefile.in b/gdb/testsuite/gdb.opencl/Makefile.in
deleted file mode 100644
index decf413..0000000
--- a/gdb/testsuite/gdb.opencl/Makefile.in
+++ /dev/null
@@ -1,18 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = callfuncs datatypes vec_comps convs_casts operators
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o a.out core corefile gcore.test
-	-rm -f *.dwo *.dwp
-	-rm -f $(EXECUTABLES)
-
-distclean maintainer-clean realclean: clean
-	-rm -f *~ core
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.opt/Makefile.in b/gdb/testsuite/gdb.opt/Makefile.in
deleted file mode 100644
index 76b305e..0000000
--- a/gdb/testsuite/gdb.opt/Makefile.in
+++ /dev/null
@@ -1,25 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = clobbered-registers-O2 inline-bt inline-cmds inline-locals
-
-MISCELLANEOUS =
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-find . -name '*.o' -print | xargs rm -f
-	-find . -name '*.ali' -print | xargs rm -f
-	-find . -name 'b~*.ad[sb]' -print | xargs rm -f
-	-rm -f *~ a.out xgdb *.x *.ci *.tmp
-	-rm -f *~ *.o a.out xgdb *.x *.ci *.tmp
-	-rm -f *.dwo *.dwp
-	-rm -f core core.coremaker coremaker.core corefile $(EXECUTABLES)
-	-rm -f $(MISCELLANEOUS) twice-tmp.c
-
-distclean maintainer-clean realclean: clean
-	-rm -f *~ core
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.pascal/Makefile.in b/gdb/testsuite/gdb.pascal/Makefile.in
deleted file mode 100644
index d9ad900..0000000
--- a/gdb/testsuite/gdb.pascal/Makefile.in
+++ /dev/null
@@ -1,25 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = hello/hello 
-
-MISCELLANEOUS =
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-find . -name '*.o' -print | xargs rm -f
-	-find . -name '*.ali' -print | xargs rm -f
-	-find . -name 'b~*.ad[sb]' -print | xargs rm -f
-	-rm -f *~ a.out xgdb *.x *.ci *.tmp
-	-rm -f *~ *.o a.out xgdb *.x *.ci *.tmp
-	-rm -f *.dwo *.dwp
-	-rm -f core core.coremaker coremaker.core corefile $(EXECUTABLES)
-	-rm -f $(MISCELLANEOUS) twice-tmp.c
-
-distclean maintainer-clean realclean: clean
-	-rm -f *~ core
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.perf/Makefile.in b/gdb/testsuite/gdb.perf/Makefile.in
deleted file mode 100644
index 2071d12..0000000
--- a/gdb/testsuite/gdb.perf/Makefile.in
+++ /dev/null
@@ -1,15 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-.PHONY: all clean mostlyclean distclean realclean
-
-PROGS = 
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *.o *.diff *~ core $(PROGS)
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.python/Makefile.in b/gdb/testsuite/gdb.python/Makefile.in
deleted file mode 100644
index 0b81507..0000000
--- a/gdb/testsuite/gdb.python/Makefile.in
+++ /dev/null
@@ -1,22 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = py-type py-value py-prettyprint py-template py-block \
-	py-symbol py-mi py-breakpoint py-inferior py-infthread \
-	py-shared python lib-types py-events py-evthreads py-frame \
-	py-mi py-pp-maint py-progspace py-section-script py-objfile \
-	py-finish-breakpoint py-finish-breakpoint2 py-value-cc py-explore \
-	py-explore-cc py-arch
-
-MISCELLANEOUS = py-shared-sl.sl py-events-shlib.so py-events-shlib-nodebug.so 
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o *.ci
-	-rm -f *.dwo *.dwp
-	-rm -f core $(EXECUTABLES) $(MISCELLANEOUS)
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.reverse/Makefile.in b/gdb/testsuite/gdb.reverse/Makefile.in
deleted file mode 100644
index adaf7dd..0000000
--- a/gdb/testsuite/gdb.reverse/Makefile.in
+++ /dev/null
@@ -1,21 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES   = break-reverse consecutive-reverse finish-reverse \
-	i386-precsave i386-reverse i386-sse-reverse \
-	machinestate solib-reverse step-reverse until-reverse \
-	watch-reverse sigall-reverse sigall-precsave
-
-MISCELLANEOUS = 
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	rm -f *~ *.o *.x *.ci *.sl a.out core
-	rm -f *.dwo *.dwp
-	rm -f $(EXECUTABLES) $(MISCELLANEOUS)
-
-distclean maintainer-clean realclean: clean
-	rm -f Makefile config.status config.log site.* gdb.log gdb.sum
-
diff --git a/gdb/testsuite/gdb.server/Makefile.in b/gdb/testsuite/gdb.server/Makefile.in
deleted file mode 100644
index 509fbd8..0000000
--- a/gdb/testsuite/gdb.server/Makefile.in
+++ /dev/null
@@ -1,26 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = ext-attach ext-run file-transfer server-mon server-run \
-	no-thread-db
-
-MISCELLANEOUS =
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-find . -name '*.o' -print | xargs rm -f
-	-find . -name '*.ali' -print | xargs rm -f
-	-find . -name 'b~*.ad[sb]' -print | xargs rm -f
-	-rm -f *~ a.out xgdb *.x *.ci *.tmp
-	-rm -f *~ *.o a.out xgdb *.x *.ci *.tmp
-	-rm -f *.dwo *.dwp
-	-rm -f core core.coremaker coremaker.core corefile $(EXECUTABLES)
-	-rm -f $(MISCELLANEOUS) twice-tmp.c
-
-distclean maintainer-clean realclean: clean
-	-rm -f *~ core
-	-rm -f Makefile config.status config.log
-	-rm -f *-init.exp gdb.log gdb.sum
-	-rm -fr *.log summary detail *.plog *.sum *.psum site.*
diff --git a/gdb/testsuite/gdb.stabs/Makefile.in b/gdb/testsuite/gdb.stabs/Makefile.in
deleted file mode 100644
index f1a5913..0000000
--- a/gdb/testsuite/gdb.stabs/Makefile.in
+++ /dev/null
@@ -1,14 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-all: 
-	@echo "Nothing to be done for all..."
-
-#### host, target, and site specific Makefile frags come in here.
-
-clean mostlyclean:
-	-rm -f *.o *~ core tmp.c tmp.s weird.s errs exclfwd gdb11479
-	-rm -f *.dwo *.dwp
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.threads/Makefile.in b/gdb/testsuite/gdb.threads/Makefile.in
deleted file mode 100644
index 8f9f867..0000000
--- a/gdb/testsuite/gdb.threads/Makefile.in
+++ /dev/null
@@ -1,25 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-EXECUTABLES = attach-into-signal-nothr attach-into-signal-thr \
-	attach-stopped attachstop-mt \
-	bp_in_thread current-lwp-dead execl execl1 fork-child-threads \
-	fork-thread-pending gcore-pthreads hand-call-in-threads \
-	ia64-sigill interrupted-hand-call killed linux-dp \
-	local-watch-wrong-thread manythreads multi-create pending-step \
-	print-threads pthreads pthread_cond_wait schedlock sigthread \
-	staticthreads switch-threads thread-execl thread-specific \
-	thread_check thread_events threadapply threxit-hop-specific \
-	tls tls-main tls-nodebug watchthreads watchthreads-reorder \
-	watchthreads2
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *~ *.o a.out xgdb *.x *.ci *.tmp core core.* $(EXECUTABLES) \
-	 *.core gcore.test
-	-rm -f *.dwo *.dwp
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log config.h gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.trace/Makefile.in b/gdb/testsuite/gdb.trace/Makefile.in
deleted file mode 100644
index 514beab..0000000
--- a/gdb/testsuite/gdb.trace/Makefile.in
+++ /dev/null
@@ -1,19 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-.PHONY: all clean mostlyclean distclean realclean
-
-PROGS = actions-changed ax backtrace deltrace disconnected-tracing \
-	infotrace no-attach-trace packetlen passc-dyn passcount report \
-	save-trace tfile tfind tracecmd tsv unavailable while-dyn while-stepping
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f actions circ collection
-	-rm -f *.o *.diff *~ *.bad core sh3 hppa mn10300 $(PROGS)
-	-rm -f *.dwo *.dwp
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile config.status config.log gdb.log gdb.sum
diff --git a/gdb/testsuite/gdb.xml/Makefile.in b/gdb/testsuite/gdb.xml/Makefile.in
deleted file mode 100644
index b8383ca..0000000
--- a/gdb/testsuite/gdb.xml/Makefile.in
+++ /dev/null
@@ -1,14 +0,0 @@
-VPATH = @srcdir@
-srcdir = @srcdir@
-
-PROGS =
-
-all info install-info dvi install uninstall installcheck check:
-	@echo "Nothing to be done for $@..."
-
-clean mostlyclean:
-	-rm -f *.ci *.o $(OBJS) $(PROGS) *~ core
-	-rm -f *.dwo *.dwp
-
-distclean maintainer-clean realclean: clean
-	-rm -f Makefile gdb.log gdb.sum
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 015e202..69f79fc 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -4307,7 +4307,7 @@ proc default_gdb_init { test_file_name } {
 proc make_gdb_parallel_path { args } {
     global GDB_PARALLEL objdir
     set joiner [list "file" "join" $objdir]
-    if { $GDB_PARALLEL != "yes" } {
+    if { [info exists GDB_PARALLEL] && $GDB_PARALLEL != "yes" } {
 	lappend joiner $GDB_PARALLEL
     }
     set joiner [concat $joiner $args]
@@ -4319,15 +4319,11 @@ proc make_gdb_parallel_path { args } {
 # the directory is returned.
 
 proc standard_output_file {basename} {
-    global objdir subdir gdb_test_file_name GDB_PARALLEL
+    global objdir subdir gdb_test_file_name
 
-    if {[info exists GDB_PARALLEL]} {
-	set dir [make_gdb_parallel_path outputs $subdir $gdb_test_file_name]
-	file mkdir $dir
-	return [file join $dir $basename]
-    } else {
-	return [file join $objdir $subdir $basename]
-    }
+    set dir [make_gdb_parallel_path outputs $subdir $gdb_test_file_name]
+    file mkdir $dir
+    return [file join $dir $basename]
 }
 
 # Return the name of a file in our standard temporary directory.
-- 
2.5.1

Re: [PATCH] Always organize test artifacts in a directory hierarchy

[Pedro Alves]

On 01/08/2016 03:51 PM, Simon Marchi wrote:
> When running tests in parallel, each test puts its generated files in a
> different directory, under "testsuite/outputs":
> 
> outputs
> ├── gdb.base
> │   ├── break
> │   ├── whatis
> │   └── ...
> ├── gdb.python
> │   ├── py-type
> │   ├── py-value
> │   └── ...
> └── ...
> 
> I think it would be nice if it was always organized like this, even in
> serial mode, as it would isolate the test cases a bit more.  An artifact
> created by a test wouldn't get overwritten by another test.  It would be
> clear which test produced which files.
> 

Yao posted a patch that moved sequential runs to a subdir as well:

  https://sourceware.org/ml/gdb-patches/2014-12/msg00236.html

Though I think I too prefer making sequential/parallel the same.

You should cross check your patch with yours.  For e.g., don't you
need to mkdir -p the outputs/ dir for the first time?

> It would also make it easier to clean up.  Currently, make clean in the
> testsuite is broken.  A lot of executables are left all over the place
> because their names do not appear in gdb.*/Makefile.  If everything is
> in "outputs", then we just have to delete that directory (which we
> already do).
> 
> At the same time it makes the gdb.foo directories and their Makefiles
> useless in the build directory, since they are pretty much only used for
> cleaning.

Yeah, I think we all agreed to this in the past.

> 
> Note: the performance testsuite still produces some files in gdb.perf.
> If this is accepted, we can always look at that later.

Agreed.

> 
> What do you think?

I like this.

Thanks,
Pedro Alves

Re: [PATCH] Always organize test artifacts in a directory hierarchy

[Pedro Alves]

On 01/12/2016 04:31 PM, Simon Marchi wrote:

> So it doesn't seem necessary.

Works for me.  The patch LGTM.  Maybe wait a few more days to
give others a chance to chime in though.

Thanks,
Pedro Alves

Re: [PATCH] Always organize test artifacts in a directory hierarchy

[Joel Brobecker]

> > So it doesn't seem necessary.
> 
> Works for me.  The patch LGTM.  Maybe wait a few more days to
> give others a chance to chime in though.

LGTM too; and, for the record, I am very happy about this change.

-- 
Joel

Re: [PATCH] Always organize test artifacts in a directory hierarchy

[Simon Marchi]

On 16-01-17 01:31 AM, Joel Brobecker wrote:
>>> So it doesn't seem necessary.
>>
>> Works for me.  The patch LGTM.  Maybe wait a few more days to
>> give others a chance to chime in though.
> 
> LGTM too; and, for the record, I am very happy about this change.

If there is no objection, I would push this tomorrow.

Re: [PATCH] Always organize test artifacts in a directory hierarchy

[Simon Marchi]

On 16-01-17 01:31 AM, Joel Brobecker wrote:
>>> So it doesn't seem necessary.
>>
>> Works for me.  The patch LGTM.  Maybe wait a few more days to
>> give others a chance to chime in though.
> 
> LGTM too; and, for the record, I am very happy about this change.
> 

Hi Joel (and others),

I was doing some more testing, and found out that this patch breaks testing
Ada when building in-tree.  I would merge the following patch just before
the original one.

How does it look?


From d69875543609365fdf70f09b30862834b790599a Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Mon, 25 Jan 2016 14:01:25 -0500
Subject: [PATCH] Fix in-tree, parallel running of Ada tests

While testing the following patch,

  [PATCH] Always organize test artifacts in a directory hierarchy
  https://sourceware.org/ml/gdb-patches/2016-01/msg00133.html

I noticed that it broke Ada testing.  This lead me to think that
parallel testing when building in-tree didn't work previously in Ada.
It is confirmed by this test:

$ make check TESTS="gdb.ada/fun_addr.exp" -j 2
...
Running ./gdb.ada/fun_addr.exp ...
FAIL: gdb.ada/fun_addr.exp: compilation foo.adb
...

This patch fixes in-tree parallel testing for Ada, and consequently
serial and parallel testing when the aforementioned patch is applied.

The problem originates from the fact that Ada support code cd's to the
builddir before compiling.  In itself it's not a problem, it allows to
place intermediate auto-generated files in that directory.  The Ada
compilation refers to the source file, which is in another directory,
only by its base name (e.g. foo.adb).  In serial mode, that worked
because builddir was the same as the source directory (e.g.
gdb.ada/fun_addr/).  In an out-of-tree build, it works because the
source directory is added as an include directory (note: this is not the
same $srcdir as autoconf's):

  set srcdir [file dirname $source]
  additional_flags=-I$srcdir

which becomes:

  additional_flags=-I/home/emaisin/build/binutils-gdb/gdb/testsuite/gdb.ada/fun_addr

However, when building in-tree, srcdir is relative: ./gdb.ada/fun_addr.
When using parallel or always-in-outputs-directory mode, we are cd'ed in
the outputs directory.  So -I$srcdir is relative to the current
directory, which is wrong.

To fix it, I made the TCL variable srcdir (set in site.exp, from which
everything else is derived) always absolute.  It is done by assigning
autoconf's abs_srcdir instead of autoconf's srcdir.  This way -I$srcdir
will always be good, regardless of where we cd'ed to.  A small apparent
change is that when running tests, DejaGnu will say:

  Running /tmp/binutils-gdb/gdb/testsuite/gdb.ada/fun_addr.exp ...

instead of

  Running ./gdb.ada/fun_addr.exp ...

I hope it's not too much of an annoyance.  I think that it should make
the testsuite a tiny bit more robust against other bugs of the same
class.

Regtested in & out of tree, only with native target.
---
 gdb/testsuite/Makefile.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index 7c251d3..38c3052 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -21,6 +21,7 @@ srcdir = @srcdir@
 prefix = @prefix@
 exec_prefix = @exec_prefix@
 abs_builddir = @abs_builddir@
+abs_srcdir = @abs_srcdir@

 target_alias = @target_noncanonical@
 program_transform_name = @program_transform_name@
@@ -119,7 +120,7 @@ $(abs_builddir)/site.exp site.exp: ./config.status Makefile
 	@echo "set target_alias $(target_alias)" >> ./tmp0
 	@echo "set target_triplet ${target_canonical}" >> ./tmp0
 	@echo "set build_triplet ${build_canonical}" >> ./tmp0
-	@echo "set srcdir ${srcdir}" >> ./tmp0
+	@echo "set srcdir ${abs_srcdir}" >> ./tmp0
 	@echo "set tool gdb" >> ./tmp0
 	@echo 'source $${srcdir}/lib/append_gdb_boards_dir.exp' >> ./tmp0
 	@echo "## All variables above are generated by configure. Do Not Edit ##" >> ./tmp0
-- 
2.5.1

Re: [PATCH] Always organize test artifacts in a directory hierarchy

[Simon Marchi]

On 16-01-25 04:23 PM, Simon Marchi wrote:
> On 16-01-17 01:31 AM, Joel Brobecker wrote:
>>>> So it doesn't seem necessary.
>>>
>>> Works for me.  The patch LGTM.  Maybe wait a few more days to
>>> give others a chance to chime in though.
>>
>> LGTM too; and, for the record, I am very happy about this change.
>>
> 
> Hi Joel (and others),
> 
> I was doing some more testing, and found out that this patch breaks testing
> Ada when building in-tree.  I would merge the following patch just before
> the original one.
> 
> How does it look?

Oops, forgot the ChangeLog:


gdb/testsuite/ChangeLog:

	* Makefile.in (abs_srcdir): Assign @abs_srcdir@.
	(site.exp): Assign abs_srcdir to tcl's srcdir.

Re: [PATCH] Always organize test artifacts in a directory hierarchy

[Simon Marchi]

On 16-01-25 04:23 PM, Simon Marchi wrote:
> On 16-01-17 01:31 AM, Joel Brobecker wrote:
>>>> So it doesn't seem necessary.
>>>
>>> Works for me.  The patch LGTM.  Maybe wait a few more days to
>>> give others a chance to chime in though.
>>
>> LGTM too; and, for the record, I am very happy about this change.
>>
> 
> Hi Joel (and others),
> 
> I was doing some more testing, and found out that this patch breaks testing
> Ada when building in-tree.  I would merge the following patch just before
> the original one.
> 
> How does it look?
> 
> 
> From d69875543609365fdf70f09b30862834b790599a Mon Sep 17 00:00:00 2001
> From: Simon Marchi <simon.marchi@ericsson.com>
> Date: Mon, 25 Jan 2016 14:01:25 -0500
> Subject: [PATCH] Fix in-tree, parallel running of Ada tests
> 
> While testing the following patch,
> 
>   [PATCH] Always organize test artifacts in a directory hierarchy
>   https://sourceware.org/ml/gdb-patches/2016-01/msg00133.html
> 
> I noticed that it broke Ada testing.  This lead me to think that
> parallel testing when building in-tree didn't work previously in Ada.
> It is confirmed by this test:
> 
> $ make check TESTS="gdb.ada/fun_addr.exp" -j 2
> ...
> Running ./gdb.ada/fun_addr.exp ...
> FAIL: gdb.ada/fun_addr.exp: compilation foo.adb
> ...
> 
> This patch fixes in-tree parallel testing for Ada, and consequently
> serial and parallel testing when the aforementioned patch is applied.
> 
> The problem originates from the fact that Ada support code cd's to the
> builddir before compiling.  In itself it's not a problem, it allows to
> place intermediate auto-generated files in that directory.  The Ada
> compilation refers to the source file, which is in another directory,
> only by its base name (e.g. foo.adb).  In serial mode, that worked
> because builddir was the same as the source directory (e.g.
> gdb.ada/fun_addr/).  In an out-of-tree build, it works because the
> source directory is added as an include directory (note: this is not the
> same $srcdir as autoconf's):
> 
>   set srcdir [file dirname $source]
>   additional_flags=-I$srcdir
> 
> which becomes:
> 
>   additional_flags=-I/home/emaisin/build/binutils-gdb/gdb/testsuite/gdb.ada/fun_addr
> 
> However, when building in-tree, srcdir is relative: ./gdb.ada/fun_addr.
> When using parallel or always-in-outputs-directory mode, we are cd'ed in
> the outputs directory.  So -I$srcdir is relative to the current
> directory, which is wrong.
> 
> To fix it, I made the TCL variable srcdir (set in site.exp, from which
> everything else is derived) always absolute.  It is done by assigning
> autoconf's abs_srcdir instead of autoconf's srcdir.  This way -I$srcdir
> will always be good, regardless of where we cd'ed to.  A small apparent
> change is that when running tests, DejaGnu will say:
> 
>   Running /tmp/binutils-gdb/gdb/testsuite/gdb.ada/fun_addr.exp ...
> 
> instead of
> 
>   Running ./gdb.ada/fun_addr.exp ...
> 
> I hope it's not too much of an annoyance.  I think that it should make
> the testsuite a tiny bit more robust against other bugs of the same
> class.
> 
> Regtested in & out of tree, only with native target.
> ---
>  gdb/testsuite/Makefile.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
> index 7c251d3..38c3052 100644
> --- a/gdb/testsuite/Makefile.in
> +++ b/gdb/testsuite/Makefile.in
> @@ -21,6 +21,7 @@ srcdir = @srcdir@
>  prefix = @prefix@
>  exec_prefix = @exec_prefix@
>  abs_builddir = @abs_builddir@
> +abs_srcdir = @abs_srcdir@
> 
>  target_alias = @target_noncanonical@
>  program_transform_name = @program_transform_name@
> @@ -119,7 +120,7 @@ $(abs_builddir)/site.exp site.exp: ./config.status Makefile
>  	@echo "set target_alias $(target_alias)" >> ./tmp0
>  	@echo "set target_triplet ${target_canonical}" >> ./tmp0
>  	@echo "set build_triplet ${build_canonical}" >> ./tmp0
> -	@echo "set srcdir ${srcdir}" >> ./tmp0
> +	@echo "set srcdir ${abs_srcdir}" >> ./tmp0
>  	@echo "set tool gdb" >> ./tmp0
>  	@echo 'source $${srcdir}/lib/append_gdb_boards_dir.exp' >> ./tmp0
>  	@echo "## All variables above are generated by configure. Do Not Edit ##" >> ./tmp0
> 

Ping.

Re: [PATCH] Always organize test artifacts in a directory hierarchy

[Joel Brobecker]

> > However, when building in-tree, srcdir is relative: ./gdb.ada/fun_addr.
> > When using parallel or always-in-outputs-directory mode, we are cd'ed in
> > the outputs directory.  So -I$srcdir is relative to the current
> > directory, which is wrong.
> > 
> > To fix it, I made the TCL variable srcdir (set in site.exp, from which
> > everything else is derived) always absolute.  It is done by assigning
> > autoconf's abs_srcdir instead of autoconf's srcdir.  This way -I$srcdir
> > will always be good, regardless of where we cd'ed to.  A small apparent
> > change is that when running tests, DejaGnu will say:
> > 
> >   Running /tmp/binutils-gdb/gdb/testsuite/gdb.ada/fun_addr.exp ...
> > 
> > instead of
> > 
> >   Running ./gdb.ada/fun_addr.exp ...
> > 
> > I hope it's not too much of an annoyance.  I think that it should make
> > the testsuite a tiny bit more robust against other bugs of the same
> > class.
> > 
> > Regtested in & out of tree, only with native target.
> > ---
> >  gdb/testsuite/Makefile.in | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
> > index 7c251d3..38c3052 100644
> > --- a/gdb/testsuite/Makefile.in
> > +++ b/gdb/testsuite/Makefile.in
> > @@ -21,6 +21,7 @@ srcdir = @srcdir@
> >  prefix = @prefix@
> >  exec_prefix = @exec_prefix@
> >  abs_builddir = @abs_builddir@
> > +abs_srcdir = @abs_srcdir@
> > 
> >  target_alias = @target_noncanonical@
> >  program_transform_name = @program_transform_name@
> > @@ -119,7 +120,7 @@ $(abs_builddir)/site.exp site.exp: ./config.status Makefile
> >  	@echo "set target_alias $(target_alias)" >> ./tmp0
> >  	@echo "set target_triplet ${target_canonical}" >> ./tmp0
> >  	@echo "set build_triplet ${build_canonical}" >> ./tmp0
> > -	@echo "set srcdir ${srcdir}" >> ./tmp0
> > +	@echo "set srcdir ${abs_srcdir}" >> ./tmp0
> >  	@echo "set tool gdb" >> ./tmp0
> >  	@echo 'source $${srcdir}/lib/append_gdb_boards_dir.exp' >> ./tmp0
> >  	@echo "## All variables above are generated by configure. Do Not Edit ##" >> ./tmp0

OK for me!

-- 
Joel

Re: [PATCH] Always organize test artifacts in a directory hierarchy

[Simon Marchi]

On 16-02-07 02:09 AM, Joel Brobecker wrote:
>>> However, when building in-tree, srcdir is relative: ./gdb.ada/fun_addr.
>>> When using parallel or always-in-outputs-directory mode, we are cd'ed in
>>> the outputs directory.  So -I$srcdir is relative to the current
>>> directory, which is wrong.
>>>
>>> To fix it, I made the TCL variable srcdir (set in site.exp, from which
>>> everything else is derived) always absolute.  It is done by assigning
>>> autoconf's abs_srcdir instead of autoconf's srcdir.  This way -I$srcdir
>>> will always be good, regardless of where we cd'ed to.  A small apparent
>>> change is that when running tests, DejaGnu will say:
>>>
>>>   Running /tmp/binutils-gdb/gdb/testsuite/gdb.ada/fun_addr.exp ...
>>>
>>> instead of
>>>
>>>   Running ./gdb.ada/fun_addr.exp ...
>>>
>>> I hope it's not too much of an annoyance.  I think that it should make
>>> the testsuite a tiny bit more robust against other bugs of the same
>>> class.
>>>
>>> Regtested in & out of tree, only with native target.
>>> ---
>>>  gdb/testsuite/Makefile.in | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
>>> index 7c251d3..38c3052 100644
>>> --- a/gdb/testsuite/Makefile.in
>>> +++ b/gdb/testsuite/Makefile.in
>>> @@ -21,6 +21,7 @@ srcdir = @srcdir@
>>>  prefix = @prefix@
>>>  exec_prefix = @exec_prefix@
>>>  abs_builddir = @abs_builddir@
>>> +abs_srcdir = @abs_srcdir@
>>>
>>>  target_alias = @target_noncanonical@
>>>  program_transform_name = @program_transform_name@
>>> @@ -119,7 +120,7 @@ $(abs_builddir)/site.exp site.exp: ./config.status Makefile
>>>  	@echo "set target_alias $(target_alias)" >> ./tmp0
>>>  	@echo "set target_triplet ${target_canonical}" >> ./tmp0
>>>  	@echo "set build_triplet ${build_canonical}" >> ./tmp0
>>> -	@echo "set srcdir ${srcdir}" >> ./tmp0
>>> +	@echo "set srcdir ${abs_srcdir}" >> ./tmp0
>>>  	@echo "set tool gdb" >> ./tmp0
>>>  	@echo 'source $${srcdir}/lib/append_gdb_boards_dir.exp' >> ./tmp0
>>>  	@echo "## All variables above are generated by configure. Do Not Edit ##" >> ./tmp0
> 
> OK for me!

Ok thanks, I pushed this one.

Re: [PATCH] Always organize test artifacts in a directory hierarchy

[Simon Marchi]

On 16-01-17 01:31 AM, Joel Brobecker wrote:
>>> So it doesn't seem necessary.
>>
>> Works for me.  The patch LGTM.  Maybe wait a few more days to
>> give others a chance to chime in though.
> 
> LGTM too; and, for the record, I am very happy about this change.

Ok, I pushed this patch.  I am now waiting to know what I broke.

[testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy]

[Jan Kratochvil]

On Mon, 08 Feb 2016 20:26:41 +0100, Simon Marchi wrote:
> Ok, I pushed this patch.  I am now waiting to know what I broke.

Running /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
PASS: gdb.arch/i386-biarch-core.exp: complete set gnutarget
PASS: gdb.arch/i386-biarch-core.exp: core-file
PASS: gdb.arch/i386-biarch-core.exp: .text is readable
->
Running /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
PASS: gdb.arch/i386-biarch-core.exp: complete set gnutarget
UNTESTED: gdb.arch/i386-biarch-core.exp: failed bzip2

Reproducible with:
	tar xJf gdb-7.10.90.20160211.tar.xz;cd gdb-7.10.90.20160211;./configure;make;make -C gdb check//unix/-m64 RUNTESTFLAGS=gdb.arch/i386-biarch-core.exp
	Running /tmp/gdb-7.10.90.20160211/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
	sh: /tmp/gdb-7.10.90.20160211/gdb/testsuite.unix.-m64/gdb.arch/i386-biarch-core.core: No such file or directory
			=== gdb Summary ===
	# of expected passes		1
	# of untested testcases		1

I have not debugged it more yet.


Jan

Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy]

[Simon Marchi]

On 16-02-11 04:22 PM, Jan Kratochvil wrote:
> On Mon, 08 Feb 2016 20:26:41 +0100, Simon Marchi wrote:
>> Ok, I pushed this patch.  I am now waiting to know what I broke.
> 
> Running /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
> PASS: gdb.arch/i386-biarch-core.exp: complete set gnutarget
> PASS: gdb.arch/i386-biarch-core.exp: core-file
> PASS: gdb.arch/i386-biarch-core.exp: .text is readable
> ->
> Running /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
> PASS: gdb.arch/i386-biarch-core.exp: complete set gnutarget
> UNTESTED: gdb.arch/i386-biarch-core.exp: failed bzip2
> 
> Reproducible with:
> 	tar xJf gdb-7.10.90.20160211.tar.xz;cd gdb-7.10.90.20160211;./configure;make;make -C gdb check//unix/-m64 RUNTESTFLAGS=gdb.arch/i386-biarch-core.exp
> 	Running /tmp/gdb-7.10.90.20160211/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
> 	sh: /tmp/gdb-7.10.90.20160211/gdb/testsuite.unix.-m64/gdb.arch/i386-biarch-core.core: No such file or directory
> 			=== gdb Summary ===
> 	# of expected passes		1
> 	# of untested testcases		1
> 
> I have not debugged it more yet.
> 
> 
> Jan

Hi Jan,

I think this patch should fix it.  It simply makes the test use standard_output_file
for its output directory.

Simon


From c643fde26ecdc63c399ac4f26fd31920148fae77 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Fri, 12 Feb 2016 13:17:32 -0500
Subject: [PATCH] i386-biarch-core.exp: Use standard_output_file

Fix the core file path to use the standard output directory.

gdb/testsuite/ChangeLog:

	* i386-biarch-core.exp: Define corefile using
	standard_output_file.
---
 gdb/testsuite/gdb.arch/i386-biarch-core.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.arch/i386-biarch-core.exp b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
index 607b947..4dc5ba6 100644
--- a/gdb/testsuite/gdb.arch/i386-biarch-core.exp
+++ b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
@@ -40,7 +40,7 @@ gdb_test_multiple "complete set gnutarget " $test {
 }

 set corebz2file ${srcdir}/${subdir}/${testfile}.core.bz2
-set corefile ${objdir}/${subdir}/${testfile}.core
+set corefile [standard_output_file ${testfile}.core]
 # Entry point of the original executable.
 set address 0x400078

-- 
2.5.1

Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy]

[Pedro Alves]

On 02/12/2016 06:34 PM, Simon Marchi wrote:

> From c643fde26ecdc63c399ac4f26fd31920148fae77 Mon Sep 17 00:00:00 2001
> From: Simon Marchi <simon.marchi@ericsson.com>
> Date: Fri, 12 Feb 2016 13:17:32 -0500
> Subject: [PATCH] i386-biarch-core.exp: Use standard_output_file
> 
> Fix the core file path to use the standard output directory.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* i386-biarch-core.exp: Define corefile using
> 	standard_output_file.

Looks obvious to me.

Thanks,
Pedro Alves

Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy]

[Jan Kratochvil]

On Fri, 12 Feb 2016 19:34:16 +0100, Simon Marchi wrote:
> I think this patch should fix it.  It simply makes the test use standard_output_file
> for its output directory.

OK, thanks.  I did not expect almost all the other 42 failed testfiles are
Fedora-only ones so I have to fix them on my own.
	gdb.arch/i386-interface.exp gdb.arch/x86_64-pid0-core.exp gdb.arch/x86_64-vla-typedef.exp gdb.base/attach-32.exp gdb.base/attach-see-vdso.exp gdb.base/charsign.exp gdb.base/corefile.exp gdb.base/datalib.exp gdb.base/execl-update-breakpoints.exp gdb.base/fork-detach.exp gdb.base/gcore-excessive-memory.exp gdb.base/gcorebg.exp gdb.base/lineno-makeup.exp gdb.base/move-dir.exp gdb.base/readline-overflow.exp gdb.base/rhbz981154-misleading-yum-install-warning.exp gdb.base/step-over-trampoline.exp gdb.base/unwind-leak.exp gdb.base/vla-overflow.exp gdb.base/vla.exp gdb.base/watchpoint-cond.exp gdb.base/watchpoint-during-step.exp gdb.cp/b146835.exp gdb.cp/constructortest.exp gdb.cp/namespace-nested-imports.exp gdb.cp/namespace-no-imports.exp gdb.dwarf2/dw2-errno.exp gdb.dwarf2/dw2-errno2.exp gdb.dwarf2/dw2-included.exp gdb.fortran/dynamic.exp gdb.fortran/string.exp gdb.pascal/arrays.exp gdb.pie/attach.exp gdb.pie/break.exp gdb.pie/corefile.exp gdb.threads/bt-clone-stop.exp gdb.threads/simultaneous-step-resume-breakpoint.exp gdb.threads/threadcrash.exp gdb.threads/threaded-exec.exp gdb.threads/tls-rhbz947564.exp gdb.threads/tls-sepdebug.exp gdb.threads/watchthreads-threaded.exp

(gdb.base/corefile.exp gdb.base/execl-update-breakpoints.exp listed there do
not reproduce it for me locally now, I will re-check those.)


Jan

Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy]

[Simon Marchi]

On 16-02-12 01:41 PM, Pedro Alves wrote:
> On 02/12/2016 06:34 PM, Simon Marchi wrote:
> 
>> From c643fde26ecdc63c399ac4f26fd31920148fae77 Mon Sep 17 00:00:00 2001
>> From: Simon Marchi <simon.marchi@ericsson.com>
>> Date: Fri, 12 Feb 2016 13:17:32 -0500
>> Subject: [PATCH] i386-biarch-core.exp: Use standard_output_file
>>
>> Fix the core file path to use the standard output directory.
>>
>> gdb/testsuite/ChangeLog:
>>
>> 	* i386-biarch-core.exp: Define corefile using
>> 	standard_output_file.
> 
> Looks obvious to me.
> 
> Thanks,
> Pedro Alves
> 

Thanks, pushed.

Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy]

[Simon Marchi]

On 16-02-12 01:47 PM, Jan Kratochvil wrote:
> On Fri, 12 Feb 2016 19:34:16 +0100, Simon Marchi wrote:
>> I think this patch should fix it.  It simply makes the test use standard_output_file
>> for its output directory.
> 
> OK, thanks.  I did not expect almost all the other 42 failed testfiles are
> Fedora-only ones so I have to fix them on my own.
> 	gdb.arch/i386-interface.exp gdb.arch/x86_64-pid0-core.exp gdb.arch/x86_64-vla-typedef.exp gdb.base/attach-32.exp gdb.base/attach-see-vdso.exp gdb.base/charsign.exp gdb.base/corefile.exp gdb.base/datalib.exp gdb.base/execl-update-breakpoints.exp gdb.base/fork-detach.exp gdb.base/gcore-excessive-memory.exp gdb.base/gcorebg.exp gdb.base/lineno-makeup.exp gdb.base/move-dir.exp gdb.base/readline-overflow.exp gdb.base/rhbz981154-misleading-yum-install-warning.exp gdb.base/step-over-trampoline.exp gdb.base/unwind-leak.exp gdb.base/vla-overflow.exp gdb.base/vla.exp gdb.base/watchpoint-cond.exp gdb.base/watchpoint-during-step.exp gdb.cp/b146835.exp gdb.cp/constructortest.exp gdb.cp/namespace-nested-imports.exp gdb.cp/namespace-no-imports.exp gdb.dwarf2/dw2-errno.exp gdb.dwarf2/dw2-errno2.exp gdb.dwarf2/dw2-included.exp gdb.fortran/dynamic.exp gdb.fortran/string.exp gdb.pascal/arrays.exp gdb.pie/attach.exp gdb.pie/break.exp gdb.pie/corefile.exp gdb.threads/bt-clone-stop.exp gdb.threads/simul
taneous-step-resume-breakpoint.exp gdb.threads/threadcrash.exp gdb.threads/threaded-exec.exp gdb.threads/tls-rhbz947564.exp gdb.threads/tls-sepdebug.exp gdb.threads/watchthreads-threaded.exp
> 
> (gdb.base/corefile.exp gdb.base/execl-update-breakpoints.exp listed there do
> not reproduce it for me locally now, I will re-check those.)
> 
> 
> Jan

I'll run the testsuite with GDB_INOTIFY=1, it might catch a few problems of the same kind.

Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy]

[Simon Marchi]

On 16-02-12 01:56 PM, Simon Marchi wrote:
> On 16-02-12 01:41 PM, Pedro Alves wrote:
>> On 02/12/2016 06:34 PM, Simon Marchi wrote:
>>
>>> From c643fde26ecdc63c399ac4f26fd31920148fae77 Mon Sep 17 00:00:00 2001
>>> From: Simon Marchi <simon.marchi@ericsson.com>
>>> Date: Fri, 12 Feb 2016 13:17:32 -0500
>>> Subject: [PATCH] i386-biarch-core.exp: Use standard_output_file
>>>
>>> Fix the core file path to use the standard output directory.
>>>
>>> gdb/testsuite/ChangeLog:
>>>
>>> 	* i386-biarch-core.exp: Define corefile using
>>> 	standard_output_file.
>>
>> Looks obvious to me.
>>
>> Thanks,
>> Pedro Alves
>>
> 
> Thanks, pushed.
> 

Hmm actually, should I push it to the 7.11 branch as well?  Is there a special
procedure, or I just cherry-pick and push?

Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy]

[Pedro Alves]

On 02/12/2016 09:54 PM, Simon Marchi wrote:

> Hmm actually, should I push it to the 7.11 branch as well?  

Doesn't hurt.

> Is there a special procedure, or I just cherry-pick and push?

Just cherry-pick, make sure ChangeLog entry is at the top, and push.

Thanks,
Pedro Alves

Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy]

[Simon Marchi]

On 16-02-12 06:01 PM, Pedro Alves wrote:
> On 02/12/2016 09:54 PM, Simon Marchi wrote:
> 
>> Hmm actually, should I push it to the 7.11 branch as well?  
> 
> Doesn't hurt.
> 
>> Is there a special procedure, or I just cherry-pick and push?
> 
> Just cherry-pick, make sure ChangeLog entry is at the top, and push.
> 
> Thanks,
> Pedro Alves

Ok I have pushed it to gdb-7.11-branch.

Simon

[testsuite obv+7.11] Fix more testcases with standard_output_file [Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others]

[Jan Kratochvil]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

On Fri, 12 Feb 2016 19:47:10 +0100, Jan Kratochvil wrote:
> (gdb.base/corefile.exp gdb.base/execl-update-breakpoints.exp listed there do
> not reproduce it for me locally now, I will re-check those.)

I have rechecked it and fixed these.

trunk:
	c99dbb4246fedd500dbdd50514589fc7f95d80c0
7.11:
	8b6bd5aca63189590498195a7a2696cde021c9cd


Jan

[-- Attachment #2: Type: message/rfc822, Size: 3027 bytes --]

From: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: [PATCH] Fix more testcases with standard_output_file.
Date: Mon, 15 Feb 2016 18:54:03 +0100

Since
	commit 2151ccc56c74b55a8f0debf0724a495368f92591
	Author: Simon Marchi <simon.marchi@ericsson.com>
	Date:   Mon Feb 8 14:02:36 2016 -0500
	    Always organize test artifacts in a directory hierarchy
these testfiles could not build.

gdb/testsuite/ChangeLog
2016-02-15  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.arch/i386-gnu-cfi.exp: Use standard_output_file.
	* gdb.arch/i386-prologue.exp: Likewise.
	* gdb.arch/i386-size.exp: Likewise.
---
 gdb/testsuite/ChangeLog                  | 6 ++++++
 gdb/testsuite/gdb.arch/i386-gnu-cfi.exp  | 2 +-
 gdb/testsuite/gdb.arch/i386-prologue.exp | 2 +-
 gdb/testsuite/gdb.arch/i386-size.exp     | 2 +-
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index d945411..9dc5085 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2016-02-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* gdb.arch/i386-gnu-cfi.exp: Use standard_output_file.
+	* gdb.arch/i386-prologue.exp: Likewise.
+	* gdb.arch/i386-size.exp: Likewise.
+
 2016-02-15  Simon Marchi  <simon.marchi@ericsson.com>
 
 	* gdb.base/wrong_frame_bt_full.exp: Use standard_output_file to
diff --git a/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp b/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp
index 247b9ef..b569139 100644
--- a/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp
+++ b/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp
@@ -31,7 +31,7 @@ if { ![is_x86_like_target] } then {
 set testfile "i386-gnu-cfi"
 set srcfilec ${testfile}.c
 set srcfileasm ${testfile}-asm.S
-set binfile ${objdir}/${subdir}/${testfile}
+set binfile [standard_output_file ${testfile}]
 
 # some targets have leading underscores on assembly symbols.
 set additional_flags [gdb_target_symbol_prefix_flags]
diff --git a/gdb/testsuite/gdb.arch/i386-prologue.exp b/gdb/testsuite/gdb.arch/i386-prologue.exp
index 00ccfe5..399c628 100644
--- a/gdb/testsuite/gdb.arch/i386-prologue.exp
+++ b/gdb/testsuite/gdb.arch/i386-prologue.exp
@@ -28,7 +28,7 @@ if { ![is_x86_like_target] } then {
 
 set testfile "i386-prologue"
 set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
+set binfile [standard_output_file ${testfile}]
 
 # some targets have leading underscores on assembly symbols.
 set additional_flags [gdb_target_symbol_prefix_flags]
diff --git a/gdb/testsuite/gdb.arch/i386-size.exp b/gdb/testsuite/gdb.arch/i386-size.exp
index 4d49950..61acf2f 100644
--- a/gdb/testsuite/gdb.arch/i386-size.exp
+++ b/gdb/testsuite/gdb.arch/i386-size.exp
@@ -27,7 +27,7 @@ if { ![is_x86_like_target] } then {
 
 set testfile "i386-size"
 set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
+set binfile [standard_output_file ${testfile}]
 
 # some targets have leading underscores on assembly symbols.
 set additional_flags [gdb_target_symbol_prefix_flags]
-- 
2.5.0